Re: Review request for JDK-8047366 and JDK-8141505

2015-11-12 Thread Sundararajan Athijegannathan 

+1

On 11/11/2015 8:50 PM, Hannes Wallnoefer wrote:

Please review JDK-8047366 and JDK-8141505.

These are two trivial test-only fixes enabled by the recent double 
conversion commit.


http://cr.openjdk.java.net/~hannesw/8047366/webrev/
http://cr.openjdk.java.net/~hannesw/8141505/webrev/

Thanks,
Hannes

Re: Review request for JDK-8142864: Raw types warning in WeakValueCache

2015-11-12 Thread Sundararajan Athijegannathan 

+1

On 11/12/2015 9:06 PM, Hannes Wallnoefer wrote:

Please review JDK-8142864: Raw types warning in WeakValueCache:

http://cr.openjdk.java.net/~hannesw/8142864/webrev/

This removes a warning in WeakValueCache.java, and I also reduced 
methods by combining code as suggested by Attila.


Furthermore I renamed method in isWrappedPrimitiveAndObject in 
ScriptRuntime.java to isPrimitiveAndObject because the primitives are 
not wrapped (at least not in the JavaScript meaning of the word).


Thanks,
Hannes

Re: Review request for JDK-8142864: Raw types warning in WeakValueCache

2015-11-12 Thread Michael Haupt 
Hi Hannes,

lower-case thumbs up.

Best,

Michael

> Am 12.11.2015 um 16:36 schrieb Hannes Wallnoefer 
> :
> 
> Please review JDK-8142864: Raw types warning in WeakValueCache:
> 
> http://cr.openjdk.java.net/~hannesw/8142864/webrev/
> 
> This removes a warning in WeakValueCache.java, and I also reduced methods by 
> combining code as suggested by Attila.
> 
> Furthermore I renamed method in isWrappedPrimitiveAndObject in 
> ScriptRuntime.java to isPrimitiveAndObject because the primitives are not 
> wrapped (at least not in the JavaScript meaning of the word).
> 
> Thanks,
> Hannes

-- 

 
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
  Oracle is committed to developing 
practices and products that help protect the environment

Review request for JDK-8142864: Raw types warning in WeakValueCache

2015-11-12 Thread Hannes Wallnoefer 

Please review JDK-8142864: Raw types warning in WeakValueCache:

http://cr.openjdk.java.net/~hannesw/8142864/webrev/

This removes a warning in WeakValueCache.java, and I also reduced 
methods by combining code as suggested by Attila.


Furthermore I renamed method in isWrappedPrimitiveAndObject in 
ScriptRuntime.java to isPrimitiveAndObject because the primitives are 
not wrapped (at least not in the JavaScript meaning of the word).


Thanks,
Hannes

Re: RFR 8142857: Enable all nashorn "api" tests for jtreg test run

2015-11-12 Thread Michael Haupt 
Hi Sundar,

yep, lower-case thumbs up. It's *good* to cover more tests with jtreg.

Best,

Michael

> Am 12.11.2015 um 14:43 schrieb Sundararajan Athijegannathan 
> :
> 
> Please review http://cr.openjdk.java.net/~sundar/8142857/webrev.00/ for 
> https://bugs.openjdk.java.net/browse/JDK-8142857
> 
> Thanks,
> -Sundar
> 

-- 

 
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
  Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8142857: Enable all nashorn "api" tests for jtreg test run

2015-11-12 Thread Attila Szegedi 
+1

> On Nov 12, 2015, at 2:43 PM, Sundararajan Athijegannathan 
>  wrote:
> 
> Please review http://cr.openjdk.java.net/~sundar/8142857/webrev.00/ for 
> https://bugs.openjdk.java.net/browse/JDK-8142857
> 
> Thanks,
> -Sundar
>

Re: RFR 8142857: Enable all nashorn "api" tests for jtreg test run

2015-11-12 Thread Sundararajan Athijegannathan 

Thanks.

Made that static initializer change and pushed.

Updated webrev for the record: 
http://cr.openjdk.java.net/~sundar/8142857/webrev.01/


-Sundar

On 11/12/2015 7:49 PM, Hannes Wallnoefer wrote:

+1

The static fields in ParseAPITest.java are set twice, if you remove 
the first initializer they could remain final.


Hannes

Am 2015-11-12 um 14:43 schrieb Sundararajan Athijegannathan:
Please review http://cr.openjdk.java.net/~sundar/8142857/webrev.00/ 
for https://bugs.openjdk.java.net/browse/JDK-8142857


Thanks,
-Sundar

Re: RFR 8142857: Enable all nashorn "api" tests for jtreg test run

2015-11-12 Thread Hannes Wallnoefer 

+1

The static fields in ParseAPITest.java are set twice, if you remove the 
first initializer they could remain final.


Hannes

Am 2015-11-12 um 14:43 schrieb Sundararajan Athijegannathan:
Please review http://cr.openjdk.java.net/~sundar/8142857/webrev.00/ 
for https://bugs.openjdk.java.net/browse/JDK-8142857


Thanks,
-Sundar

RFR 8142857: Enable all nashorn "api" tests for jtreg test run

2015-11-12 Thread Sundararajan Athijegannathan 
Please review http://cr.openjdk.java.net/~sundar/8142857/webrev.00/ for 
https://bugs.openjdk.java.net/browse/JDK-8142857


Thanks,
-Sundar

Re: URGENT: JDK 9 RFR of JDK-8142501: nashorn tests failing after recent changes

2015-11-12 Thread Hannes Wallnöfer 

+1


Am Don, 12. Nov, 2015 um 5:43 schrieb Sundararajan Athijegannathan 
:

Hi,

[ Replying based on url from JIRA update. I'm yet to get email from 
nashorn-dev list]


Nashorn team runs test via "ant clean test". Only a subset of tests 
are enabled for jtreg by appropriate jtreg tags. In this case, these 
tests were enabled without running jtreg.


I see that you've fixed the tests to run in jtreg mode - not sure if 
'ant clean test' is okay or not ("test.src" system property and 
default of "." to fetch resources - not sure if ant test is fine). If 
ant run is fine, we can go ahead with your fix.


If not (or if you've not run ant), I propose to disable jtreg mode 
for these tests:


http://cr.openjdk.java.net/~sundar/8142501/webrev.00/

to unblock others and get back to making the test work in both jtreg 
and ant mode by a later fix.


PS. After disabling for jtreg mode, I tested that jtreg mode and ant 
mode are fine.


Thanks,
-Sundar

Re: URGENT: JDK 9 RFR of JDK-8142501: nashorn tests failing after recent changes

2015-11-12 Thread Sundararajan Athijegannathan 
That was in response to this email -> 
http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-November/005562.html


On 11/12/2015 10:13 AM, Sundararajan Athijegannathan wrote:

Hi,

[ Replying based on url from JIRA update. I'm yet to get email from 
nashorn-dev list]


Nashorn team runs test via "ant clean test". Only a subset of tests 
are enabled for jtreg by appropriate jtreg tags. In this case, these 
tests were enabled without running jtreg.


I see that you've fixed the tests to run in jtreg mode - not sure if 
'ant clean test' is okay or not ("test.src" system property and 
default of "." to fetch resources - not sure if ant test is fine). If 
ant run is fine, we can go ahead with your fix.


If not (or if you've not run ant), I propose to disable jtreg mode for 
these tests:


http://cr.openjdk.java.net/~sundar/8142501/webrev.00/

to unblock others and get back to making the test work in both jtreg 
and ant mode by a later fix.


PS. After disabling for jtreg mode, I tested that jtreg mode and ant 
mode are fine.


Thanks,
-Sundar

Re: Review request for JDK-8047366 and JDK-8141505

2015-11-12 Thread Marcus Lagergren 
+1

> On 11 Nov 2015, at 16:26, Sundararajan Athijegannathan 
>  wrote:
> 
> +1
> 
> On 11/11/2015 8:50 PM, Hannes Wallnoefer wrote:
>> Please review JDK-8047366 and JDK-8141505.
>> 
>> These are two trivial test-only fixes enabled by the recent double 
>> conversion commit.
>> 
>> http://cr.openjdk.java.net/~hannesw/8047366/webrev/
>> http://cr.openjdk.java.net/~hannesw/8141505/webrev/
>> 
>> Thanks,
>> Hannes
>