Re: RFR 8144160: Regression: two tests fail on Windows with "ant test" target

2015-11-26 Thread Hannes Wallnoefer

+1 for disabling this for now, assuming it gets fixed later.

Hannes


Am 2015-11-27 um 05:36 schrieb Sundararajan Athijegannathan:
Please review http://cr.openjdk.java.net/~sundar/8144160/ for 
https://bugs.openjdk.java.net/browse/JDK-8144160


Thanks,
-Sundar




Re: RFR 8144150: test262parallel test exclusion does not work and is incomplete

2015-11-26 Thread Hannes Wallnoefer

Hi Sundar,

from the bug description it is not clear if the newly excluded tests are 
supposed to fix running with jdk9-dev. For me they don't, I still see 
that failure when running with jdk9-dev with that patch.


+1 for the file name comparison change.

Hannes

Am 2015-11-26 um 18:26 schrieb Sundararajan Athijegannathan:
Please review http://cr.openjdk.java.net/~sundar/8144150/webrev.00/  
for https://bugs.openjdk.java.net/browse/JDK-8144150


Thanks,
-Sundar




RFR 8144160: Regression: two tests fail on Windows with "ant test" target

2015-11-26 Thread Sundararajan Athijegannathan
Please review http://cr.openjdk.java.net/~sundar/8144160/ for 
https://bugs.openjdk.java.net/browse/JDK-8144160


Thanks,
-Sundar


Re: RFR 8144051: failing test262parallel run leads to successful build

2015-11-26 Thread Hannes Wallnoefer

+1

Am 2015-11-26 um 14:22 schrieb Sundararajan Athijegannathan:
Please review http://cr.openjdk.java.net/~sundar/8144051/webrev.00/ 
for https://bugs.openjdk.java.net/browse/JDK-8144051


3 currently failing test262 tests are excluded - see also

* https://bugs.openjdk.java.net/browse/JDK-8144037
* https://bugs.openjdk.java.net/browse/JDK-8134883

Thanks,
-Sundar




Re: RFR 8144150: test262parallel test exclusion does not work and is incomplete

2015-11-26 Thread Michael Haupt
Hi Sundar,

lower-case thumbs up.

Best,

Michael

> Am 26.11.2015 um 18:26 schrieb Sundararajan Athijegannathan 
> :
> 
> Please review http://cr.openjdk.java.net/~sundar/8144150/webrev.00/  for 
> https://bugs.openjdk.java.net/browse/JDK-8144150
> 
> Thanks,
> -Sundar

-- 

 
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
  Oracle is committed to developing 
practices and products that help protect the environment



Re: RFR 8144051: failing test262parallel run leads to successful build

2015-11-26 Thread Michael Haupt
Hi Sundar,

lower-case thumbs up.

Best,

Michael

> Am 26.11.2015 um 14:22 schrieb Sundararajan Athijegannathan 
> :
> 
> Please review http://cr.openjdk.java.net/~sundar/8144051/webrev.00/ for 
> https://bugs.openjdk.java.net/browse/JDK-8144051
> 
> 3 currently failing test262 tests are excluded - see also
> 
> * https://bugs.openjdk.java.net/browse/JDK-8144037
> * https://bugs.openjdk.java.net/browse/JDK-8134883
> 
> Thanks,
> -Sundar

-- 

 
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
  Oracle is committed to developing 
practices and products that help protect the environment



RFR 8144051: failing test262parallel run leads to successful build

2015-11-26 Thread Sundararajan Athijegannathan
Please review http://cr.openjdk.java.net/~sundar/8144051/webrev.00/ for 
https://bugs.openjdk.java.net/browse/JDK-8144051


3 currently failing test262 tests are excluded - see also

* https://bugs.openjdk.java.net/browse/JDK-8144037
* https://bugs.openjdk.java.net/browse/JDK-8134883

Thanks,
-Sundar


RFR 8144150: test262parallel test exclusion does not work and is incomplete

2015-11-26 Thread Sundararajan Athijegannathan
Please review http://cr.openjdk.java.net/~sundar/8144150/webrev.00/  for 
https://bugs.openjdk.java.net/browse/JDK-8144150


Thanks,
-Sundar


Re: RFR(S): 8143642: Nashorn shebang argument handling is broken

2015-11-26 Thread Hannes Wallnoefer

+1

Since the argument reshuffling is difficult to describe it would be nice 
if you could add an example as well: shebang line, args before, args after.


Hannes

Am 2015-11-26 um 10:42 schrieb Michael Haupt:

Dear all,

please review this change.
Bug: https://bugs.openjdk.java.net/browse/JDK-8143642
Webrev: http://cr.openjdk.java.net/~mhaupt/8143642/webrev.00

It enables passing arguments to scripts when they are run in shebang mode.

Thanks,

Michael





Re: RFR(S): 8143642: Nashorn shebang argument handling is broken

2015-11-26 Thread Michael Haupt
Hi Hannes,

thank you - I'm going to push the change at 
http://cr.openjdk.java.net/~mhaupt/8143642/webrev.01 which sports such an 
example.

Best,

Michael

> Am 26.11.2015 um 11:50 schrieb Hannes Wallnoefer 
> :
> 
> +1
> 
> Since the argument reshuffling is difficult to describe it would be nice if 
> you could add an example as well: shebang line, args before, args after.
> 
> Hannes
> 
> Am 2015-11-26 um 10:42 schrieb Michael Haupt:
>> Dear all,
>> 
>> please review this change.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8143642
>> Webrev: http://cr.openjdk.java.net/~mhaupt/8143642/webrev.00
>> 
>> It enables passing arguments to scripts when they are run in shebang mode.
>> 
>> Thanks,
>> 
>> Michael
>> 
> 

-- 

 
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
  Oracle is committed to developing 
practices and products that help protect the environment



Re: RFR(S): 8143642: Nashorn shebang argument handling is broken

2015-11-26 Thread Sundararajan Athijegannathan

+1

On 11/26/2015 3:12 PM, Michael Haupt wrote:

Dear all,

please review this change.
Bug: https://bugs.openjdk.java.net/browse/JDK-8143642
Webrev: http://cr.openjdk.java.net/~mhaupt/8143642/webrev.00

It enables passing arguments to scripts when they are run in shebang mode.

Thanks,

Michael





RFR(S): 8143642: Nashorn shebang argument handling is broken

2015-11-26 Thread Michael Haupt
Dear all,

please review this change.
Bug: https://bugs.openjdk.java.net/browse/JDK-8143642
Webrev: http://cr.openjdk.java.net/~mhaupt/8143642/webrev.00

It enables passing arguments to scripts when they are run in shebang mode.

Thanks,

Michael

-- 

 
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
  Oracle is committed to developing 
practices and products that help protect the environment