Re: RFR 8144230: Add a sample for pluggable dynalink linker

2015-11-30 Thread Michael Haupt 
Hi Sundar,

lower-case thumbs up!

Best,

Michael

> Am 30.11.2015 um 13:18 schrieb Sundararajan Athijegannathan 
> :
> 
> Please review http://cr.openjdk.java.net/~sundar/8144230/ for 
> https://bugs.openjdk.java.net/browse/JDK-8144230
> 
> Thanks,
> -Sundar

-- 

 
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
  Oracle is committed to developing 
practices and products that help protect the environment

Re: Review request for JDK-8144131: ArrayData.getInt implementations do not convert to int32

2015-11-30 Thread Sundararajan Athijegannathan 

+1

http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-November/005635.html

-Sundar

Re: RFR 8144230: Add a sample for pluggable dynalink linker

2015-11-30 Thread Hannes Wallnoefer 

+1

That's a very powerful demo of what can be done with Dynalink!

Hannes

Am 2015-11-30 um 13:18 schrieb Sundararajan Athijegannathan:
Please review http://cr.openjdk.java.net/~sundar/8144230/ for 
https://bugs.openjdk.java.net/browse/JDK-8144230


Thanks,
-Sundar

RFR 8144230: Add a sample for pluggable dynalink linker

2015-11-30 Thread Sundararajan Athijegannathan 
Please review http://cr.openjdk.java.net/~sundar/8144230/ for 
https://bugs.openjdk.java.net/browse/JDK-8144230


Thanks,
-Sundar

Re: RFR 8144160: Regression: two tests fail on Windows with "ant test" target

2015-11-30 Thread Michael Haupt 
Hi Marcus,

this is tracked here: https://bugs.openjdk.java.net/browse/JDK-8144221

Best,

Michael

> Am 30.11.2015 um 09:28 schrieb Marcus Lagergren :
> 
> +1 for disabling this for now, assuming it gets fixed later. Where is this 
> tracked?
> 
> /M
> 
>> On 27 Nov 2015, at 05:36, Sundararajan Athijegannathan 
>>  wrote:
>> 
>> Please review http://cr.openjdk.java.net/~sundar/8144160/ for 
>> https://bugs.openjdk.java.net/browse/JDK-8144160
>> 
>> Thanks,
>> -Sundar
> 

-- 

 
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
  Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8144186: Update Main.asm sample to use dynalink public API

2015-11-30 Thread Marcus Lagergren 
+1

> On 27 Nov 2015, at 13:12, Sundararajan Athijegannathan 
>  wrote:
> 
> Please review http://cr.openjdk.java.net/~sundar/8144186/webrev.00/ for 
> https://bugs.openjdk.java.net/browse/JDK-8144186
> 
> Thanks,
> -Sundar

Re: RFR 8144051: failing test262parallel run leads to successful build

2015-11-30 Thread Marcus Lagergren 
+1

> On 26 Nov 2015, at 14:22, Sundararajan Athijegannathan 
>  wrote:
> 
> Please review http://cr.openjdk.java.net/~sundar/8144051/webrev.00/ for 
> https://bugs.openjdk.java.net/browse/JDK-8144051
> 
> 3 currently failing test262 tests are excluded - see also
> 
> * https://bugs.openjdk.java.net/browse/JDK-8144037
> * https://bugs.openjdk.java.net/browse/JDK-8134883
> 
> Thanks,
> -Sundar

Re: RFR 8144160: Regression: two tests fail on Windows with "ant test" target

2015-11-30 Thread Marcus Lagergren 
+1 for disabling this for now, assuming it gets fixed later. Where is this 
tracked?

/M

> On 27 Nov 2015, at 05:36, Sundararajan Athijegannathan 
>  wrote:
> 
> Please review http://cr.openjdk.java.net/~sundar/8144160/ for 
> https://bugs.openjdk.java.net/browse/JDK-8144160
> 
> Thanks,
> -Sundar

Re: Review request for JDK-8144131: ArrayData.getInt implementations do not convert to int32

2015-11-30 Thread Marcus Lagergren 
I’m perfectly fine with the combined fix. Looking good.

+1

/M

> On 27 Nov 2015, at 09:03, Hannes Wallnoefer  
> wrote:
> 
> Please review JDK-8144131: ArrayData.getInt implementations do not convert to 
> int32:
> 
> http://cr.openjdk.java.net/~hannesw/8144131/webrev/
> 
> for https://bugs.openjdk.java.net/browse/JDK-8144131
> 
> I piggybacked a small fix to keep unary plus/minus from changing the type of 
> long literals to doubles. I'm not sure if that is serious enough that it 
> should get its own bug, let me know if you think so.
> 
> Hannes