nashorn migration

2015-12-14 Thread Wyatt, Steven 
Hi,

You have listed "nashorn:mozilla_script.js" as the compatibility script instead 
of "nashorn:mozilla_compat.js" in the section "loading compatibility script so 
that script runs on rhino and nashorn".

https://wiki.openjdk.java.net/display/Nashorn/Rhino+Migration+Guide

Steve

_
The information contained in this message is proprietary and/or confidential. 
If you are not the intended recipient, please: (i) delete the message and all 
copies; (ii) do not disclose, distribute or use the message in any manner; and 
(iii) notify the sender immediately. In addition, please be aware that any 
message addressed to our domain is subject to archiving and review by persons 
other than the intended recipient. Thank you.

Re: Use of long in Nashorn

2015-12-14 Thread Hannes Wallnoefer 
For the record, I tried the integer index optimization for array 
iterators, but didn't really see a difference running a microbenchmark 
using Array.prototype.forEach, so I left it out after all.


Hannes

Am 2015-12-11 um 16:30 schrieb Hannes Wallnoefer:

Am 2015-12-11 um 16:21 schrieb Attila Szegedi:
On Dec 11, 2015, at 4:08 PM, Hannes Wallnoefer 
 wrote:


I didn't implement the int/double overloading of array iterator 
actions. Unless I missed something, I would have to implement two 
forEach methods in each subclass, which seem ugly and error prone.
You haven’t missed anything; that’s exactly how that would work. 
Ultimately, if we had macros in Java, this wouldn’t need to look 
ugly, but we don’t have them, so… Performance optimizations are 
sometimes ugly :-) Anyway, this needn’t happen now, although 
ultimately I don’t think it’d be much of a big deal to implement, 
even with the unfortunate code duplication, and we still wouldn’t 
always force-promote the parameter type for the callback functions to 
double.




Ok, you convinced me. I'll add that optimization an upcoming webrev. 
Still waiting for other reviews though.


Hannes

Re: RFR 8145314: jjs tab-completion should support camel case completion

2015-12-14 Thread Hannes Wallnoefer 

+1


Am 2015-12-14 um 16:05 schrieb Sundararajan Athijegannathan:
Please review http://cr.openjdk.java.net/~sundar/8145314/ for 
https://bugs.openjdk.java.net/browse/JDK-8145314


Thanks,
-Sundar

Re: Review request for JDK-8144914: Eagerly lookup browser JS object class in BrowserJSObjectLinker

2015-12-14 Thread Hannes Wallnoefer 

Sorry, I missed the intial request.

+1

Hannes


Am 2015-12-14 um 16:44 schrieb Attila Szegedi:

2nd review, please?

On Tue, Dec 8, 2015 at 12:58 PM, Sundararajan Athijegannathan <
sundararajan.athijegannat...@oracle.com> wrote:


+1

-Sundar


On 12/8/2015 5:23 PM, Attila Szegedi wrote:


Please review JDK-8144914 "Eagerly lookup browser JS object class in
BrowserJSObjectLinker" at <
http://cr.openjdk.java.net/~attila/8144914/webrev.jdk9.jdk> for <
https://bugs.openjdk.java.net/browse/JDK-8144914>

(Note that line 96 replaces “return null” for “return inv” – the
distinction only makes sense in presence of non-standard operations, which
we currently don’t have, but even so that’s pedantically more correct.)

Thanks,
Attila.

Re: RFR 8145314: jjs tab-completion should support camel case completion

2015-12-14 Thread Michael Haupt 
Hi Sundar,

lower-case thumbs up.

Best,

Michael

> Am 14.12.2015 um 16:05 schrieb Sundararajan Athijegannathan 
> :
> 
> Please review http://cr.openjdk.java.net/~sundar/8145314/ for 
> https://bugs.openjdk.java.net/browse/JDK-8145314
> 
> Thanks,
> -Sundar

-- 

 
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
  Oracle is committed to developing 
practices and products that help protect the environment

Re: Review request for JDK-8144914: Eagerly lookup browser JS object class in BrowserJSObjectLinker

2015-12-14 Thread Attila Szegedi 
2nd review, please?

On Tue, Dec 8, 2015 at 12:58 PM, Sundararajan Athijegannathan <
sundararajan.athijegannat...@oracle.com> wrote:

> +1
>
> -Sundar
>
>
> On 12/8/2015 5:23 PM, Attila Szegedi wrote:
>
>> Please review JDK-8144914 "Eagerly lookup browser JS object class in
>> BrowserJSObjectLinker" at <
>> http://cr.openjdk.java.net/~attila/8144914/webrev.jdk9.jdk> for <
>> https://bugs.openjdk.java.net/browse/JDK-8144914>
>>
>> (Note that line 96 replaces “return null” for “return inv” – the
>> distinction only makes sense in presence of non-standard operations, which
>> we currently don’t have, but even so that’s pedantically more correct.)
>>
>> Thanks,
>>Attila.
>>
>
>

RFR 8145314: jjs tab-completion should support camel case completion

2015-12-14 Thread Sundararajan Athijegannathan 
Please review http://cr.openjdk.java.net/~sundar/8145314/ for 
https://bugs.openjdk.java.net/browse/JDK-8145314


Thanks,
-Sundar

Re: JFokus VM Tech Day 2016

2015-12-14 Thread Marcus Lagergren 
Guys. Sadly Paul couldn’t make it, but we have replaced him with Simon Ritter, 
who will be wearing his new Azul hat. You are all welcome to attend!

https://www.jfokus.se/jfokus/jvmtech.jsp 


/M

/M

> On 19 Nov 2015, at 17:17, Marcus Lagergren  wrote:
> 
> And all talks have now been finalized: 
> https://www.jfokus.se/jfokus/jvmtech.jsp
> 
> A VM tech day without Martin Thompson is no VM tech day!
> 
> Regards
> Marcus
> 
>> On 11 Nov 2015, at 09:35, Marcus Lagergren  wrote:
>> 
>> Greetings community members!
>> 
>> I am coordinator for the JFokus VM Tech Day at the JFokus conference in 
>> February 2016. This is the second year running we have this event, and it 
>> was a great success last year. This year we have received significantly more 
>> contributions, and the hardest part was sifting through all quality material 
>> that we were given.
>> 
>> We are in the process of finalizing the speaker list, but 5 out of 6 slots 
>> are now filled and the current agenda looks like this: 
>> https://www.jfokus.se/jfokus/jvmtech.jsp
>> 
>> This year, Brian Goetz, Java Language Architect from Oracle opens the tech 
>> day, and talks about project Valhalla and how the OpenJDK is getting there.
>> 
>> Brian is followed by Charlie Gracie, IBM, who will cover what is some of the 
>> most exciting news in the runtime world for a very long time: The open 
>> sourcing of the J9 JVM and its APIs, and example applications in the dynamic 
>> language space.
>> 
>> We are also proud (as always) to host the formidable Mr. Aleksey Shipilev, 
>> performance czar extraordinare, always balancing on the fine line between 
>> brilliant and crazy. Aleksey's presentation is about String compaction, and 
>> String optimisations with invokedynamic in Java 9. Hopefully we have room 
>> for him at the ordinary JFokus conference as well, as the man spouts 
>> excellent tech presentations like a fountain.
>> 
>> Charlie Nutter also joins us to discuss JRuby 9000, which was released this 
>> summer, and about using the JVM as a platform for multi language development.
>> 
>> Paul Sandoz, a man who can do anything from REST services down to bare 
>> silicone magic in his job, will tell us about how VarHandles are implemented 
>> in the JVM, performance aspects and why no one should miss sun.misc.Unsafe.
>> 
>> Our sixth and final speaker slot is being allocated real soon now. Watch 
>> this space.
>> 
>> As usual there is time allocated for breakout sessions, improvised 
>> unscheduled lightning talks and discussions / Q&A.
>> 
>> Join the best VM internals conference initiative since JVMLS, and the first 
>> of its kind in the old world.
>> 
>> Regards
>> Marcus Lagergren
>> 
>

Re: RFR(S): 8144221: fix Nashorn shebang argument handling on Mac/Linux

2015-12-14 Thread Jim Laskey (Oracle) 
+1

> On Dec 14, 2015, at 6:09 AM, Michael Haupt  wrote:
> 
> Dear all,
> 
> please review this change.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8144221
> Webrev: http://cr.openjdk.java.net/~mhaupt/8144221/webrev.00
> 
> The fix for Cygwin is pending and tracked by JDK-8145305.
> 
> Thanks,
> 
> Michael
> 
> -- 
> 
> 
> Dr. Michael Haupt | Principal Member of Technical Staff
> Phone: +49 331 200 7277 | Fax: +49 331 200 7561
> Oracle Java Platform Group | LangTools Team | Nashorn
> Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
> Oracle is committed to developing 
> practices and products that help protect the environment
>

Re: Review request for JDK-8144020: Remove long as an internal numeric type

2015-12-14 Thread Marcus Lagergren 
+1. This is awesome work, Hannes!

/M

> On 11 Dec 2015, at 16:15, Hannes Wallnoefer  
> wrote:
> 
> Please review JDK-8144020: Remove long as an internal numeric type:
> 
> http://cr.openjdk.java.net/~hannesw/8144020/webrev.01/
> 
> Attila already reviewed a previous version of this patch:
> 
> http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-December/005669.html
> 
> This version contains most of the changes he suggested.
> 
> Thanks,
> Hannes

Re: RFR(S): 8144221: fix Nashorn shebang argument handling on Mac/Linux

2015-12-14 Thread Marcus Lagergren 
+1

> On 14 Dec 2015, at 11:09, Michael Haupt  wrote:
> 
> Dear all,
> 
> please review this change.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8144221
> Webrev: http://cr.openjdk.java.net/~mhaupt/8144221/webrev.00
> 
> The fix for Cygwin is pending and tracked by JDK-8145305.
> 
> Thanks,
> 
> Michael
> 
> --
> 
> 
> Dr. Michael Haupt | Principal Member of Technical Staff
> Phone: +49 331 200 7277 | Fax: +49 331 200 7561
> Oracle Java Platform Group | LangTools Team | Nashorn
> Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
> Oracle is committed to developing 
> practices and products that help protect the environment
>

RFR(S): 8144221: fix Nashorn shebang argument handling on Mac/Linux

2015-12-14 Thread Michael Haupt 
Dear all,

please review this change.
Bug: https://bugs.openjdk.java.net/browse/JDK-8144221
Webrev: http://cr.openjdk.java.net/~mhaupt/8144221/webrev.00

The fix for Cygwin is pending and tracked by JDK-8145305.

Thanks,

Michael

-- 

 
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
  Oracle is committed to developing 
practices and products that help protect the environment