Re: RFR(M): 8144113: enable jjs testing

[Michael Haupt]

Hi Attila,

in addition to Sundar's remark about this only being a @subtest, I can report 
successful execution of "which" on Cygwin. :-)

Best,

Michael

> Am 19.01.2016 um 15:04 schrieb Attila Szegedi :
> 
> Wouldn't test/script/nosecurity/jjs-common.js.html also need @runif 
> os.not.windows? It executes “which”, which I seem to remember doesn’t exist 
> on Windows. (Windows has “where” instead, which might or might not be good 
> enough; I don’t know…)
> 
>> On Jan 19, 2016, at 2:56 PM, Michael Haupt  wrote:
>> 
>> Dear all,
>> 
>> please review this change by Srinivas Dama, which I'm sponsoring.
>> RFE: https://bugs.openjdk.java.net/browse/JDK-8144113
>> Webrev: http://cr.openjdk.java.net/~mhaupt/8144113/webrev.00
>> 
>> The change contains some tests for the jjs executable. They are implemented 
>> in JavaScript themselves and extensively use the scripting capabilities of 
>> Nashorn. 
>> 
>> Thanks,
>> 
>> Michael


-- 

 
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
  Oracle is committed to developing 
practices and products that help protect the environment

Review request for backport of JDK-8144020: Remove long as an internal numeric type

[Hannes Wallnoefer]

Please review backport to 8u-dev of JDK-8144020: Remove long as an 
internal numeric type:


http://cr.openjdk.java.net/~hannesw/8144020/webrev-8u/

There was some manual merging necessary in the following files:

src/jdk/nashorn/internal/codegen/LocalVariableTypesCalculator.java
src/jdk/nashorn/internal/codegen/SpillObjectCreator.java
src/jdk/nashorn/internal/ir/debug/NashornTextifier.java
src/jdk/nashorn/internal/objects/NativeArray.java
src/jdk/nashorn/internal/parser/Lexer.java
src/jdk/nashorn/internal/runtime/JSType.java
src/jdk/nashorn/internal/runtime/OptimisticReturnFilters.java
src/jdk/nashorn/internal/runtime/ScriptObject.java
src/jdk/nashorn/internal/runtime/arrays/LongArrayData.java

I chose to omit the changes to ir/debug/NashornTextifier.java and 
runtime/linker/NashornCallSiteDescriptor.java (cleaning up bytecode 
printing) as it is not an essential part of this patch and would have 
required more changes in NashornTextifier.java.


Thanks
Hannes

Re: RFR(M): 8144113: enable jjs testing

[Michael Haupt]

Hi Attila,

indeed the "ant test" task will fail for those tests that rely on Cygwin 
binaries when executed from the cmd.exe shell prompt. The number of tests that 
do so is minuscule. Still, since tests failing in such circumstances is untidy, 
these should be enabled for Win/Cygwin only. Filed as 
https://bugs.openjdk.java.net/browse/JDK-8147788.

Best,

Michael

> Am 20.01.2016 um 12:05 schrieb Attila Szegedi :
> Nice. Although, it is obvious Cygwin would provide a “which". Are our Windows 
> tests supposed to run on Cygwin only, not on vanilla Windows?
> 
>> On Jan 20, 2016, at 9:49 AM, Michael Haupt  wrote:
>> 
>> Hi Attila,
>> 
>> in addition to Sundar's remark about this only being a @subtest, I can 
>> report successful execution of "which" on Cygwin. :-)
>> 
>> Best,
>> 
>> Michael
>> 
>>> Am 19.01.2016 um 15:04 schrieb Attila Szegedi :
>>> 
>>> Wouldn't test/script/nosecurity/jjs-common.js.html also need @runif 
>>> os.not.windows? It executes “which”, which I seem to remember doesn’t exist 
>>> on Windows. (Windows has “where” instead, which might or might not be good 
>>> enough; I don’t know…)
>>> 
 On Jan 19, 2016, at 2:56 PM, Michael Haupt  
 wrote:
 
 Dear all,
 
 please review this change by Srinivas Dama, which I'm sponsoring.
 RFE: https://bugs.openjdk.java.net/browse/JDK-8144113
 Webrev: http://cr.openjdk.java.net/~mhaupt/8144113/webrev.00
 
 The change contains some tests for the jjs executable. They are 
 implemented in JavaScript themselves and extensively use the scripting 
 capabilities of Nashorn. 
 
 Thanks,
 
 Michael


-- 

 
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
  Oracle is committed to developing 
practices and products that help protect the environment

Review request for backport of JDK-8143896: java.lang.Long is implicitly converted to double

[Hannes Wallnoefer]

Please review backport of JDK-8143896: java.lang.Long is implicitly 
converted to double:


http://cr.openjdk.java.net/~hannesw/8143896/webrev-8u/

This builds on the JDK-8144020 backport which I posted earlier. Some 
manual merging was necessary in runtime/JSType.java and 
objects/NativeNumber.java. The backport also does not contain the 
changes to the Parser API test as that is not available in JDK 8.


Thanks,
Hannes