Re: RFR: 8159031: jjs throws NoSuchFileException if ~/.jjs.history does not exist

2016-06-08 Thread Michael Haupt 
Hi Hannes,

lower-case thumbs up for both the JDK and Nashorn changes.

Best,

Michael

> Am 08.06.2016 um 13:18 schrieb Hannes Wallnöfer 
> :
> 
> Please review the following changes:
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8159031
> JDK webrev: http://cr.openjdk.java.net/~hannesw/8159031/jdk/webrev.00/
> Nashorn webrev: http://cr.openjdk.java.net/~hannesw/8159031/nashorn/webrev.00/
> 
> These are two one-liners that add a file existence check in Nashorn and a 
> null check in jline.
> 
> Thanks, 
> Hannes
> 

-- 

 
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
  Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8159034: 4 nashorn ant tests fail with latest jdk9-dev build with IncompatibleClassChangeError

2016-06-08 Thread Jim Laskey (Oracle) 
+1

> On Jun 8, 2016, at 9:01 AM, Sundararajan Athijegannathan 
>  wrote:
> 
> Please review http://cr.openjdk.java.net/~sundar/8159034/webrev.00/ for
> https://bugs.openjdk.java.net/browse/JDK-8159034
> 
> No new regression test added as there are already tests cover calling
> inherited default methods on interfaces.
> 
> Thanks,
> 
> -Sundar
>

Re: RFR 8159034: 4 nashorn ant tests fail with latest jdk9-dev build with IncompatibleClassChangeError

2016-06-08 Thread Hannes Wallnöfer 
+1

> Am 08.06.2016 um 14:01 schrieb Sundararajan Athijegannathan 
> :
> 
> Please review http://cr.openjdk.java.net/~sundar/8159034/webrev.00/ for
> https://bugs.openjdk.java.net/browse/JDK-8159034
> 
> No new regression test added as there are already tests cover calling
> inherited default methods on interfaces.
> 
> Thanks,
> 
> -Sundar
>

RFR 8159034: 4 nashorn ant tests fail with latest jdk9-dev build with IncompatibleClassChangeError

2016-06-08 Thread Sundararajan Athijegannathan 
Please review http://cr.openjdk.java.net/~sundar/8159034/webrev.00/ for
https://bugs.openjdk.java.net/browse/JDK-8159034

No new regression test added as there are already tests cover calling
inherited default methods on interfaces.

Thanks,

-Sundar

Re: RFR: 8159031: jjs throws NoSuchFileException if ~/.jjs.history does not exist

2016-06-08 Thread Sundararajan Athijegannathan 
+1


On 6/8/2016 4:48 PM, Hannes Wallnöfer wrote:
> Please review the following changes:
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8159031
> JDK webrev: http://cr.openjdk.java.net/~hannesw/8159031/jdk/webrev.00/
> Nashorn webrev: http://cr.openjdk.java.net/~hannesw/8159031/nashorn/webrev.00/
>
> These are two one-liners that add a file existence check in Nashorn and a 
> null check in jline.
>
> Thanks, 
> Hannes
>

RFR: 8159031: jjs throws NoSuchFileException if ~/.jjs.history does not exist

2016-06-08 Thread Hannes Wallnöfer 
Please review the following changes:

Bug: https://bugs.openjdk.java.net/browse/JDK-8159031
JDK webrev: http://cr.openjdk.java.net/~hannesw/8159031/jdk/webrev.00/
Nashorn webrev: http://cr.openjdk.java.net/~hannesw/8159031/nashorn/webrev.00/

These are two one-liners that add a file existence check in Nashorn and a null 
check in jline.

Thanks, 
Hannes