Re: RFR: 8187962: Optimistic types ignore JavaAdapter return types

2017-09-26 Thread Sundararajan Athijegannathan 

+1

-Sundar

On 26/09/17, 10:35 PM, Hannes Wallnöfer wrote:

Please review:

Bug: https://bugs.openjdk.java.net/browse/JDK-8187962
Webrev: http://cr.openjdk.java.net/~hannesw/8187962/webrev/

Thanks,
Hannes

RFR: 8187962: Optimistic types ignore JavaAdapter return types

2017-09-26 Thread Hannes Wallnöfer 
Please review:

Bug: https://bugs.openjdk.java.net/browse/JDK-8187962
Webrev: http://cr.openjdk.java.net/~hannesw/8187962/webrev/

Thanks,
Hannes

Re: RFR 8187965: dynalink samples under $jdk10/src/sample/nashorn/dynalink are broken

2017-09-26 Thread Hannes Wallnöfer 
+1

Hannes


> Am 26.09.2017 um 16:41 schrieb Jim Laskey (Oracle) :
> 
> +1 nicer too
> 
> 
>> On Sep 26, 2017, at 10:58 AM, Sundararajan Athijegannathan 
>>  wrote:
>> 
>> Please review.
>> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8187965
>> 
>> Webrev: http://cr.openjdk.java.net/~sundar/8187965/webrev.00/
>> 
>> Dynalink samples are broken because of wildcard usage in jar command.
>> 
>> PS. Piggybacking another sample script base64.js
>> 
>> Thanks,
>> -Sundar
>

Re: RFR 8187965: dynalink samples under $jdk10/src/sample/nashorn/dynalink are broken

2017-09-26 Thread Jim Laskey (Oracle) 
+1 nicer too


> On Sep 26, 2017, at 10:58 AM, Sundararajan Athijegannathan 
>  wrote:
> 
> Please review.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8187965
> 
> Webrev: http://cr.openjdk.java.net/~sundar/8187965/webrev.00/
> 
> Dynalink samples are broken because of wildcard usage in jar command.
> 
> PS. Piggybacking another sample script base64.js
> 
> Thanks,
> -Sundar