Re: RFR: 8191819: String.prototype.match should follow ES6 specification

[Sundararajan Athijegannathan]

+1

-Sundar

On 23/11/17, 8:12 PM, Hannes Wallnöfer wrote:

Sorry, the test in the first webrev uses replace() instead of match(), which 
already works as expected.

New webrev with correct test is here:  
http://cr.openjdk.java.net/~hannesw/8191819/webrev.01/

Hannes



Am 23.11.2017 um 14:18 schrieb Hannes Wallnöfer:

Please review:

Bug: https://bugs.openjdk.java.net/browse/JDK-8191819
Webrev: http://cr.openjdk.java.net/~hannesw/8191819/webrev/

Thanks,
Hannes

Re: RFR: 8191819: String.prototype.match should follow ES6 specification

[Hannes Wallnöfer]

Sorry, the test in the first webrev uses replace() instead of match(), which 
already works as expected.

New webrev with correct test is here:  
http://cr.openjdk.java.net/~hannesw/8191819/webrev.01/

Hannes

 
> Am 23.11.2017 um 14:18 schrieb Hannes Wallnöfer 
> :
> 
> Please review: 
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8191819
> Webrev: http://cr.openjdk.java.net/~hannesw/8191819/webrev/
> 
> Thanks,
> Hannes

RFR: 8191819: String.prototype.match should follow ES6 specification

[Hannes Wallnöfer]

Please review: 

Bug: https://bugs.openjdk.java.net/browse/JDK-8191819
Webrev: http://cr.openjdk.java.net/~hannesw/8191819/webrev/

Thanks,
Hannes

Re: RFR 8191810: jjs should avoid hard coded javadoc base url for shift-tab documentation feature

[Hannes Wallnöfer]

+1

Hannes

> Am 23.11.2017 um 09:52 schrieb Sundararajan Athijegannathan 
> :
> 
> Please review.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8191810
> Webrev: http://cr.openjdk.java.net/~sundar/8191810/webrev.00/
> 
> Thanks,
> -Sundar

RFR 8191810: jjs should avoid hard coded javadoc base url for shift-tab documentation feature

[Sundararajan Athijegannathan]

Please review.

Bug: https://bugs.openjdk.java.net/browse/JDK-8191810
Webrev: http://cr.openjdk.java.net/~sundar/8191810/webrev.00/

Thanks,
-Sundar