Re: Review request for JDK-8191878: Reduce code duplication in BeanLinker

2017-11-27 Thread Sundararajan Athijegannathan 

Looks good

-Sundar

On 27/11/17, 12:21 AM, Attila Szegedi wrote:

Hey folks,

I’m able to spend some free time again on OpenJDK development, and one thing I 
have on my plate is adding a REMOVE operation to Dynalink.

This CR however, is not yet it: that will require a CCC sponsorship etc. as 
I’ll be adding a new enum value to StandardOperations, and I will follow up 
separately once I’m done with it.

What this is a refactoring of BeanLinker code to eliminate most of the code 
duplication between getElementGetter and getElementSetter methods. This would 
be justified on its own, but once I need to add the getElementRemover method, 
it will really pay off as then we won’t have triplication of similar code.

With that in mind, please review JDK-8191878 "Reduce code duplication in BeanLinker" 
at  
for

Thanks,
   Attila.

Re: Review request for JDK-8191878: Reduce code duplication in BeanLinker

2017-11-27 Thread Hannes Wallnöfer 
Hi Attila,

> Am 26.11.2017 um 19:51 schrieb Attila Szegedi :
> 
> I’m able to spend some free time again on OpenJDK development, and one thing 
> I have on my plate is adding a REMOVE operation to Dynalink.
> 

great!

> This CR however, is not yet it: that will require a CCC sponsorship etc. as 
> I’ll be adding a new enum value to StandardOperations, and I will follow up 
> separately once I’m done with it. 

I was going to point you to the new CSR issue type, but I see you found your 
way already.

> What this is a refactoring of BeanLinker code to eliminate most of the code 
> duplication between getElementGetter and getElementSetter methods. This would 
> be justified on its own, but once I need to add the getElementRemover method, 
> it will really pay off as then we won’t have triplication of similar code.
> 
> With that in mind, please review JDK-8191878 "Reduce code duplication in 
> BeanLinker" at  for 
> 
> 

+1

Hannes

> Thanks,
>  Attila.
>

Re: RFR 8135178: importPackage not working even with load "Mozilla compatibility script"

2017-11-27 Thread Hannes Wallnöfer 
+1

Hannes


> Am 27.11.2017 um 11:24 schrieb Sundararajan Athijegannathan 
> :
> 
> Please review.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8135178
> Webrev:  http://cr.openjdk.java.net/~sundar/8135178/webrev.00/
> 
> Thanks,
> -Sundar

RFR 8135178: importPackage not working even with load "Mozilla compatibility script"

2017-11-27 Thread Sundararajan Athijegannathan 

Please review.

Bug: https://bugs.openjdk.java.net/browse/JDK-8135178
Webrev:  http://cr.openjdk.java.net/~sundar/8135178/webrev.00/

Thanks,
-Sundar