RFR:8157251:BeanLinker relinks array length operations for array types

2018-01-08 Thread Priya Lakshmi Muthuswamy

Hi,

Please review JDK-8157251 : BeanLinker relinks array length operations 
for array types


JBS : https://bugs.openjdk.java.net/browse/JDK-8157251
webrev : http://cr.openjdk.java.net/~pmuthuswamy/8157251/webrev.00/

Thanks,
Priya


Re: JavaScript/Nashorn mailing list?

2018-01-08 Thread Sundararajan Athijegannathan
Not all ES6 features are implemented - only a small subset is in jdk 9. 
Please report with the exact issue...


-Sundar

On 08/01/18, 9:45 PM, Michel Trudeau wrote:

Olivier,

Nashorn-dev   is the best mailing list 
to ask questions.


Re: JavaScript/Nashorn mailing list?

2018-01-08 Thread Michel Trudeau

Olivier,

Nashorn-dev   is the best mailing list to 
ask questions.

--
Thanks,
Michel




Olivier 
January 8, 2018 at 8:08 AM
Hello Michel, and happy 2018!
Quick question for you: I am trying to run some ES6 scripts from Java, 
using Nashorn.
What would be a good mailing list (or Slack channel, or what not) for 
me to ask some questions about that?


I found the "nashorn.args" property, with the value "--language=es6", 
but I am still facing some issues when I want to import modules...


Any pointer would help,
Thank you!
- Olivier




Re: RFR: 8193567: Conversion of comparison nodes affects local slots in optimistic continuation

2018-01-08 Thread Hannes Wallnöfer
Thanks for the review, Attila. 

I didn’t look at the contents of the local slots. I think the root of the 
problem is that the comparison is represented as RuntimeNode in some cases and 
as BinaryNode in others, and it can switch between the two between optimistic 
recompilations (see LocalVariableTypesCalculator.leaveBinaryNode on how 
comparison nodes are replaced with RuntimeNodes depending on the types of 
sub-expressions). I doubt it is possible to guarantee these representations use 
a compatible slot layout, and even if there is, I think for JDK 10 it’s best to 
take the safe path.

Hannes


> Am 25.12.2017 um 17:27 schrieb Attila Szegedi :
> 
> A sad +1. I too wish this were easier to solve. Can you point me to the code 
> parts that cause differences in local slot assignment? I guess I could try to 
> figure it out myself from that terrible expression in the test, but if you 
> have a quick explanation…
> 
> Thanks,
>  Attila.
> 
>> On Dec 21, 2017, at 4:36 PM, Hannes Wallnöfer  
>> wrote:
>> 
>> Please review:
>> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8193567
>> Webrev: http://cr.openjdk.java.net/~hannesw/8193567/webrev.00/
>> 
>> I’ve tried finding a smaller fix like just tagging the child nodes of all 
>> comparisons as non-optimistic, but that didn't fix the problem as those 
>> nodes could still have optimistic children.
>> 
>> Hannes
>