Re: RFR: 8198816: AbstractScriptEngine.getScriptContext creation of SimpleScriptContext is inefficient

[Sundararajan Athijegannathan]

+1

-Sundar

On 23/04/18, 8:34 AM, Hannes Wallnöfer wrote:

Please review:

Bug: https://bugs.openjdk.java.net/browse/JDK-8198816
Webrev: http://cr.openjdk.java.net/~hannesw/8198816/webrev/

Thanks,
Hannes

Re: RFR: 8198816: AbstractScriptEngine.getScriptContext creation of SimpleScriptContext is inefficient

[Jim Laskey]

+1


> On Apr 23, 2018, at 12:34 PM, Hannes Wallnöfer  
> wrote:
> 
> Please review:
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8198816
> Webrev: http://cr.openjdk.java.net/~hannesw/8198816/webrev/
> 
> Thanks,
> Hannes

RFR: 8198816: AbstractScriptEngine.getScriptContext creation of SimpleScriptContext is inefficient

[Hannes Wallnöfer]

Please review:

Bug: https://bugs.openjdk.java.net/browse/JDK-8198816
Webrev: http://cr.openjdk.java.net/~hannesw/8198816/webrev/

Thanks,
Hannes

Re: RFR: 8201466: Nashorn: defineProperty setters/getters on prototype object ignored with numeric property names

[Jim Laskey]

+1


> On Apr 23, 2018, at 10:49 AM, Hannes Wallnöfer  
> wrote:
> 
> Please review: 
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8201466
> Webrev: http://cr.openjdk.java.net/~hannesw/8201466/webrev/
> 
> Thanks,
> Hannes

Re: RFR: 8201466: Nashorn: defineProperty setters/getters on prototype object ignored with numeric property names

[Sundararajan Athijegannathan]

Looks good.

-Sundar

On 23/04/18, 6:49 AM, Hannes Wallnöfer wrote:

Please review:

Bug: https://bugs.openjdk.java.net/browse/JDK-8201466
Webrev: http://cr.openjdk.java.net/~hannesw/8201466/webrev/

Thanks,
Hannes

RFR: 8201466: Nashorn: defineProperty setters/getters on prototype object ignored with numeric property names

[Hannes Wallnöfer]

Please review: 

Bug: https://bugs.openjdk.java.net/browse/JDK-8201466
Webrev: http://cr.openjdk.java.net/~hannesw/8201466/webrev/

Thanks,
Hannes