Re: RFR: 8230709: Array index out of bounds in ES6 mode

2019-09-09 Thread Attila Szegedi
+1. Ugh. I guess our default lexical context stack is 16 deep.

> On 2019. Sep 9., at 16:38, Hannes Wallnöfer  
> wrote:
> 
> Please review this off-by-one array index fix that was recently reported on 
> this list:
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8230709
> Webrev: http://cr.openjdk.java.net/~hannesw/8230709/webrev.00/
> 
> Thanks,
> Hannes



Re: RFR: 8230766: Changed message in IllegalMonitorStateException

2019-09-09 Thread Attila Szegedi
+1

> On 2019. Sep 9., at 16:41, Hannes Wallnöfer  
> wrote:
> 
> Please review this fix for a test failing because of a changed exception 
> message in java.lang.Object.wait():
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8230766
> Webrev: http://cr.openjdk.java.net/~hannesw/8230766/webrev.00/
> 
> Thanks,
> Hannes



RFR: 8230766: Changed message in IllegalMonitorStateException

2019-09-09 Thread Hannes Wallnöfer
Please review this fix for a test failing because of a changed exception 
message in java.lang.Object.wait():

JBS: https://bugs.openjdk.java.net/browse/JDK-8230766
Webrev: http://cr.openjdk.java.net/~hannesw/8230766/webrev.00/

Thanks,
Hannes

RFR: 8230709: Array index out of bounds in ES6 mode

2019-09-09 Thread Hannes Wallnöfer
Please review this off-by-one array index fix that was recently reported on 
this list:

JBS: https://bugs.openjdk.java.net/browse/JDK-8230709
Webrev: http://cr.openjdk.java.net/~hannesw/8230709/webrev.00/

Thanks,
Hannes