Re: RFR 8142857: Enable all nashorn "api" tests for jtreg test run

[Michael Haupt]

Hi Sundar,

yep, lower-case thumbs up. It's *good* to cover more tests with jtreg.

Best,

Michael

> Am 12.11.2015 um 14:43 schrieb Sundararajan Athijegannathan 
> :
> 
> Please review http://cr.openjdk.java.net/~sundar/8142857/webrev.00/ for 
> https://bugs.openjdk.java.net/browse/JDK-8142857
> 
> Thanks,
> -Sundar
> 

-- 

 
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
  Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8142857: Enable all nashorn "api" tests for jtreg test run

[Hannes Wallnoefer]

+1

The static fields in ParseAPITest.java are set twice, if you remove the 
first initializer they could remain final.


Hannes

Am 2015-11-12 um 14:43 schrieb Sundararajan Athijegannathan:
Please review http://cr.openjdk.java.net/~sundar/8142857/webrev.00/ 
for https://bugs.openjdk.java.net/browse/JDK-8142857


Thanks,
-Sundar

RFR 8142857: Enable all nashorn "api" tests for jtreg test run

[Sundararajan Athijegannathan]

Please review http://cr.openjdk.java.net/~sundar/8142857/webrev.00/ for 
https://bugs.openjdk.java.net/browse/JDK-8142857


Thanks,
-Sundar

Re: RFR 8142857: Enable all nashorn "api" tests for jtreg test run

[Sundararajan Athijegannathan]

Thanks.

Made that static initializer change and pushed.

Updated webrev for the record: 
http://cr.openjdk.java.net/~sundar/8142857/webrev.01/


-Sundar

On 11/12/2015 7:49 PM, Hannes Wallnoefer wrote:

+1

The static fields in ParseAPITest.java are set twice, if you remove 
the first initializer they could remain final.


Hannes

Am 2015-11-12 um 14:43 schrieb Sundararajan Athijegannathan:
Please review http://cr.openjdk.java.net/~sundar/8142857/webrev.00/ 
for https://bugs.openjdk.java.net/browse/JDK-8142857


Thanks,
-Sundar