Re: RFR 8144150: test262parallel test exclusion does not work and is incomplete

2015-11-27 Thread Sundararajan Athijegannathan 

Actually, I see one more failure (not in excluded list):

[java] Test(compile, run): 
test\script\external\test262\test\suite\ch11\11.4\11.4.1\11.4.1-4.a-17.js


BUILD FAILED
D:\src\jdk9-dev\nashorn\make\build.xml:635: Java returned: -1073740940

So, I am not going ahead with this workaround fix at all..

Thanks,
-Sundar


On 11/27/2015 1:43 PM, Sundararajan Athijegannathan wrote:

Hi Hannes,

Thanks.

No, if does not result in a clean build (after exclusion), that 
implies exclusion does *not* still work or there are more tests 
failing. I don't know which test fails for you. In either case, this 
workaround fix is useless unless we get clean test262parallel run. I'm 
*not* pushing this fix unless I'm sure.


-Sundar

On 11/27/2015 12:38 PM, Hannes Wallnoefer wrote:

Hi Sundar,

from the bug description it is not clear if the newly excluded tests 
are supposed to fix running with jdk9-dev. For me they don't, I still 
see that failure when running with jdk9-dev with that patch.


+1 for the file name comparison change.

Hannes

Am 2015-11-26 um 18:26 schrieb Sundararajan Athijegannathan:
Please review http://cr.openjdk.java.net/~sundar/8144150/webrev.00/  
for https://bugs.openjdk.java.net/browse/JDK-8144150


Thanks,
-Sundar

Re: RFR 8144150: test262parallel test exclusion does not work and is incomplete

2015-11-27 Thread Sundararajan Athijegannathan 

Hi Hannes,

Thanks.

No, if does not result in a clean build (after exclusion), that implies 
exclusion does *not* still work or there are more tests failing. I don't 
know which test fails for you. In either case, this workaround fix is 
useless unless we get clean test262parallel run. I'm *not* pushing this 
fix unless I'm sure.


-Sundar

On 11/27/2015 12:38 PM, Hannes Wallnoefer wrote:

Hi Sundar,

from the bug description it is not clear if the newly excluded tests 
are supposed to fix running with jdk9-dev. For me they don't, I still 
see that failure when running with jdk9-dev with that patch.


+1 for the file name comparison change.

Hannes

Am 2015-11-26 um 18:26 schrieb Sundararajan Athijegannathan:
Please review http://cr.openjdk.java.net/~sundar/8144150/webrev.00/  
for https://bugs.openjdk.java.net/browse/JDK-8144150


Thanks,
-Sundar

Re: RFR 8144150: test262parallel test exclusion does not work and is incomplete

2015-11-26 Thread Hannes Wallnoefer 

Hi Sundar,

from the bug description it is not clear if the newly excluded tests are 
supposed to fix running with jdk9-dev. For me they don't, I still see 
that failure when running with jdk9-dev with that patch.


+1 for the file name comparison change.

Hannes

Am 2015-11-26 um 18:26 schrieb Sundararajan Athijegannathan:
Please review http://cr.openjdk.java.net/~sundar/8144150/webrev.00/  
for https://bugs.openjdk.java.net/browse/JDK-8144150


Thanks,
-Sundar

Re: RFR 8144150: test262parallel test exclusion does not work and is incomplete

2015-11-26 Thread Michael Haupt 
Hi Sundar,

lower-case thumbs up.

Best,

Michael

> Am 26.11.2015 um 18:26 schrieb Sundararajan Athijegannathan 
> :
> 
> Please review http://cr.openjdk.java.net/~sundar/8144150/webrev.00/  for 
> https://bugs.openjdk.java.net/browse/JDK-8144150
> 
> Thanks,
> -Sundar

-- 

 
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
  Oracle is committed to developing 
practices and products that help protect the environment

RFR 8144150: test262parallel test exclusion does not work and is incomplete

2015-11-26 Thread Sundararajan Athijegannathan 
Please review http://cr.openjdk.java.net/~sundar/8144150/webrev.00/  for 
https://bugs.openjdk.java.net/browse/JDK-8144150


Thanks,
-Sundar