Re: RFR 8145186: jjs package completion should have a fallback when javac is not available

[Sundararajan Athijegannathan]

Will fix comment and push it.

Thanks,
-Sundar

On 12/11/2015 7:41 PM, Hannes Wallnoefer wrote:

+1

"atleast" should be two words (in a comment)

Hannes

Am 2015-12-11 um 14:31 schrieb Sundararajan Athijegannathan:
Please review http://cr.openjdk.java.net/~sundar/8145186/ for 
https://bugs.openjdk.java.net/browse/JDK-8145186


Thanks,
-Sundar

Re: RFR 8145186: jjs package completion should have a fallback when javac is not available

[Michael Haupt]

Hi Sundar,

lower-case thumbs up.

Best,

Michael

> Am 11.12.2015 um 14:31 schrieb Sundararajan Athijegannathan 
> :
> 
> Please review http://cr.openjdk.java.net/~sundar/8145186/ for 
> https://bugs.openjdk.java.net/browse/JDK-8145186
> 
> Thanks,
> -Sundar

-- 

 
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
  Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8145186: jjs package completion should have a fallback when javac is not available

[Hannes Wallnoefer]

+1

"atleast" should be two words (in a comment)

Hannes

Am 2015-12-11 um 14:31 schrieb Sundararajan Athijegannathan:
Please review http://cr.openjdk.java.net/~sundar/8145186/ for 
https://bugs.openjdk.java.net/browse/JDK-8145186


Thanks,
-Sundar

RFR 8145186: jjs package completion should have a fallback when javac is not available

[Sundararajan Athijegannathan]

Please review http://cr.openjdk.java.net/~sundar/8145186/ for 
https://bugs.openjdk.java.net/browse/JDK-8145186


Thanks,
-Sundar