Re: RFR 8150731: Nashorn JSObject linker should be exposed as a service provider

2016-05-06 Thread Sundararajan Athijegannathan 
Thanks. Removed that unused import and pushed the changes.

-Sundar


On 5/6/2016 6:22 PM, Hannes Wallnoefer wrote:
> +1
>
> Minor issue: there's an unused import of java.util.ArrayList in
> Bootstrap.java
>
> Hannes
>
> Am 2016-05-05 um 06:39 schrieb Sundararajan Athijegannathan:
>> http://mail.openjdk.java.net/pipermail/nashorn-dev/2016-March/006026.html
>>
>>
>> Please review http://cr.openjdk.java.net/~sundar/8150731/webrev.02/
>>
>> I've update the webrev to use provider clause in module-info.java
>> instead of the older META-INF/services way of exposing a service.
>>
>> Also, I've split the test as suggested by Michael Haupt suggested
>> earlier.
>>
>> Thanks,
>>
>> -Sundar
>>
>

Re: RFR 8150731: Nashorn JSObject linker should be exposed as a service provider

2016-05-06 Thread Hannes Wallnoefer 

+1

Minor issue: there's an unused import of java.util.ArrayList in 
Bootstrap.java


Hannes

Am 2016-05-05 um 06:39 schrieb Sundararajan Athijegannathan:

http://mail.openjdk.java.net/pipermail/nashorn-dev/2016-March/006026.html

Please review http://cr.openjdk.java.net/~sundar/8150731/webrev.02/

I've update the webrev to use provider clause in module-info.java
instead of the older META-INF/services way of exposing a service.

Also, I've split the test as suggested by Michael Haupt suggested earlier.

Thanks,

-Sundar

Re: RFR 8150731: Nashorn JSObject linker should be exposed as a service provider

2016-05-05 Thread Jim Laskey (Oracle) 
+1

> On May 5, 2016, at 1:39 AM, Sundararajan Athijegannathan 
>  wrote:
> 
> http://mail.openjdk.java.net/pipermail/nashorn-dev/2016-March/006026.html
> 
> Please review http://cr.openjdk.java.net/~sundar/8150731/webrev.02/
> 
> I've update the webrev to use provider clause in module-info.java
> instead of the older META-INF/services way of exposing a service.
> 
> Also, I've split the test as suggested by Michael Haupt suggested earlier.
> 
> Thanks,
> 
> -Sundar
>

Re: RFR 8150731: Nashorn JSObject linker should be exposed as a service provider

2016-05-04 Thread Sundararajan Athijegannathan 
http://mail.openjdk.java.net/pipermail/nashorn-dev/2016-March/006026.html

Please review http://cr.openjdk.java.net/~sundar/8150731/webrev.02/

I've update the webrev to use provider clause in module-info.java
instead of the older META-INF/services way of exposing a service.

Also, I've split the test as suggested by Michael Haupt suggested earlier.

Thanks,

-Sundar

Re: RFR 8150731: Nashorn JSObject linker should be exposed as a service provider

2016-03-14 Thread Marcus Lagergren 
+1

> On 10 Mar 2016, at 10:06, Sundararajan Athijegannathan 
>  wrote:
> 
> Please review http://cr.openjdk.java.net/~sundar/8150731/webrev.01/ for
> https://bugs.openjdk.java.net/browse/JDK-8150731
> 
> Thanks,
> -Sundar

Re: RFR 8150731: Nashorn JSObject linker should be exposed as a service provider

2016-03-10 Thread Attila Szegedi 
+1

> On Mar 10, 2016, at 10:06 AM, Sundararajan Athijegannathan 
>  wrote:
> 
> Please review http://cr.openjdk.java.net/~sundar/8150731/webrev.01/ for
> https://bugs.openjdk.java.net/browse/JDK-8150731
> 
> Thanks,
> -Sundar

Re: RFR 8150731: Nashorn JSObject linker should be exposed as a service provider

2016-03-10 Thread Michael Haupt 
Hi Sundar,

lower-case thumbs up, with one remark about the test. It seems the lower part 
of the test method is independent of the upper part; separate aspects should 
IMHO be tested separetely, i.e., in two different methods.

Best,

Michael

> Am 10.03.2016 um 10:06 schrieb Sundararajan Athijegannathan 
> :
> 
> Please review http://cr.openjdk.java.net/~sundar/8150731/webrev.01/ for
> https://bugs.openjdk.java.net/browse/JDK-8150731
> 
> Thanks,
> -Sundar

-- 

 
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
  Oracle is committed to developing 
practices and products that help protect the environment

RFR 8150731: Nashorn JSObject linker should be exposed as a service provider

2016-03-10 Thread Sundararajan Athijegannathan 
Please review http://cr.openjdk.java.net/~sundar/8150731/webrev.01/ for
https://bugs.openjdk.java.net/browse/JDK-8150731

Thanks,
-Sundar