Re: RFR 8158250: nashorn ant javadoc targets are broken

2016-06-01 Thread Marcus Lagergren
+1

> On 31 May 2016, at 17:00, Sundararajan Athijegannathan 
>  wrote:
> 
> Please review  http://cr.openjdk.java.net/~sundar/8158250/webrev.00/ for
> https://bugs.openjdk.java.net/browse/JDK-8158250
> 
> Thanks,
> 
> -Sundar
> 



Re: RFR 8158250: nashorn ant javadoc targets are broken

2016-05-31 Thread Michael Haupt
Hi Sundar,

lower-case thumbs up!

Best,

Michael

> Am 31.05.2016 um 17:00 schrieb Sundararajan Athijegannathan 
> :
> 
> Please review  http://cr.openjdk.java.net/~sundar/8158250/webrev.00/ for
> https://bugs.openjdk.java.net/browse/JDK-8158250
> 
> Thanks,
> 
> -Sundar
> 

-- 

 
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
  Oracle is committed to developing 
practices and products that help protect the environment



Re: RFR 8158250: nashorn ant javadoc targets are broken

2016-05-31 Thread Hannes Wallnoefer

Looks good!

Am 2016-05-31 um 17:00 schrieb Sundararajan Athijegannathan:

Please review  http://cr.openjdk.java.net/~sundar/8158250/webrev.00/ for
https://bugs.openjdk.java.net/browse/JDK-8158250

Thanks,

-Sundar





RFR 8158250: nashorn ant javadoc targets are broken

2016-05-31 Thread Sundararajan Athijegannathan
Please review  http://cr.openjdk.java.net/~sundar/8158250/webrev.00/ for
https://bugs.openjdk.java.net/browse/JDK-8158250

Thanks,

-Sundar