Re: RFR 8188023: Avoid -source and -target javac options in nashorn ant compilation

2017-09-27 Thread Hannes Wallnöfer 
+1

Hannes


> Am 27.09.2017 um 14:07 schrieb Jim Laskey (Oracle) :
> 
> +1
> 
>> On Sep 27, 2017, at 8:59 AM, Sundararajan Athijegannathan 
>>  wrote:
>> 
>> Please review.
>> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8188023
>> Webrev: http://cr.openjdk.java.net/~sundar/8188023/webrev.00/index.html
>> 
>> Piggybacking to take care of few javac warnings as well.
>> 
>> Thanks,
>> -Sundar
>

Re: RFR 8188023: Avoid -source and -target javac options in nashorn ant compilation

2017-09-27 Thread Jim Laskey (Oracle) 
+1

> On Sep 27, 2017, at 8:59 AM, Sundararajan Athijegannathan 
>  wrote:
> 
> Please review.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8188023
> Webrev: http://cr.openjdk.java.net/~sundar/8188023/webrev.00/index.html
> 
> Piggybacking to take care of few javac warnings as well.
> 
> Thanks,
> -Sundar

RFR 8188023: Avoid -source and -target javac options in nashorn ant compilation

2017-09-27 Thread Sundararajan Athijegannathan 

Please review.

Bug: https://bugs.openjdk.java.net/browse/JDK-8188023
Webrev: http://cr.openjdk.java.net/~sundar/8188023/webrev.00/index.html

Piggybacking to take care of few javac warnings as well.

Thanks,
-Sundar