Re: RFR 8190698: jjs tool of jdk.scripting.nashorn.shell module should not statically depend on java.desktop

2017-11-03 Thread Hannes Wallnöfer 
+1

Hannes

> Am 03.11.2017 um 10:10 schrieb Sundararajan Athijegannathan 
> :
> 
> Please review.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8190698
> Webrev: http://cr.openjdk.java.net/~sundar/8190698/webrev.00
> 
> Thanks,
> -Sundar

Re: RFR 8190698: jjs tool of jdk.scripting.nashorn.shell module should not statically depend on java.desktop

2017-11-03 Thread Sundararajan Athijegannathan 
Thanks. Yes, jshell has similar dependencies for the UI part. i.e., no 
direct dependency on java.desktop from jdk.jshell module.


-Sundar

On 03/11/17, 6:27 PM, Jim Laskey (Oracle) wrote:

+1

Does jshell have similar dependencies?


On Nov 3, 2017, at 6:10 AM, Sundararajan 
Athijegannathan  wrote:

Please review.

Bug: https://bugs.openjdk.java.net/browse/JDK-8190698
Webrev: http://cr.openjdk.java.net/~sundar/8190698/webrev.00

Thanks,
-Sundar

Re: RFR 8190698: jjs tool of jdk.scripting.nashorn.shell module should not statically depend on java.desktop

2017-11-03 Thread Jim Laskey (Oracle) 
+1

Does jshell have similar dependencies?

> On Nov 3, 2017, at 6:10 AM, Sundararajan Athijegannathan 
>  wrote:
> 
> Please review.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8190698
> Webrev: http://cr.openjdk.java.net/~sundar/8190698/webrev.00
> 
> Thanks,
> -Sundar

RFR 8190698: jjs tool of jdk.scripting.nashorn.shell module should not statically depend on java.desktop

2017-11-03 Thread Sundararajan Athijegannathan 

Please review.

Bug: https://bugs.openjdk.java.net/browse/JDK-8190698
Webrev: http://cr.openjdk.java.net/~sundar/8190698/webrev.00

Thanks,
-Sundar