Re: RFR 8200215: 17th loop of "let foo = ''"; throws ReferenceError

[Attila Szegedi]

+1


> On 2018. Mar 26., at 15:27, Sundararajan Athijegannathan 
>  wrote:
> 
> Updated: http://cr.openjdk.java.net/~sundar/8200215/webrev.01/
> 
> Please review.
> 
> -Sundar
> 
> On 26/03/18, 6:03 PM, Hannes Wallnöfer wrote:
>> The new ScriptObject.declareAndSet method is almost identical, so the 
>> existing one could be rewritten to make use of the new one.
>> 
>> Otherwise looks good.
>> 
>> Hannes
>> 
>> 
>>> Am 26.03.2018 um 14:00 schrieb Sundararajan 
>>> Athijegannathan:
>>> 
>>> Please review http://cr.openjdk.java.net/~sundar/8200215/webrev.00/
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8200215
>>> 
>>> Thanks,
>>> -Sundar

Re: RFR 8200215: 17th loop of "let foo = ''"; throws ReferenceError

[Hannes Wallnöfer]

+1

Hannes


> Am 26.03.2018 um 15:27 schrieb Sundararajan Athijegannathan 
> :
> 
> Updated: http://cr.openjdk.java.net/~sundar/8200215/webrev.01/
> 
> Please review.
> 
> -Sundar
> 
> On 26/03/18, 6:03 PM, Hannes Wallnöfer wrote:
>> The new ScriptObject.declareAndSet method is almost identical, so the 
>> existing one could be rewritten to make use of the new one.
>> 
>> Otherwise looks good.
>> 
>> Hannes
>> 
>> 
>>> Am 26.03.2018 um 14:00 schrieb Sundararajan 
>>> Athijegannathan:
>>> 
>>> Please review http://cr.openjdk.java.net/~sundar/8200215/webrev.00/
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8200215
>>> 
>>> Thanks,
>>> -Sundar

Re: RFR 8200215: 17th loop of "let foo = ''"; throws ReferenceError

[Sundararajan Athijegannathan]

Updated: http://cr.openjdk.java.net/~sundar/8200215/webrev.01/

Please review.

-Sundar

On 26/03/18, 6:03 PM, Hannes Wallnöfer wrote:

The new ScriptObject.declareAndSet method is almost identical, so the existing 
one could be rewritten to make use of the new one.

Otherwise looks good.

Hannes



Am 26.03.2018 um 14:00 schrieb Sundararajan 
Athijegannathan:

Please review http://cr.openjdk.java.net/~sundar/8200215/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8200215

Thanks,
-Sundar

Re: RFR 8200215: 17th loop of "let foo = ''"; throws ReferenceError

[Hannes Wallnöfer]

The new ScriptObject.declareAndSet method is almost identical, so the existing 
one could be rewritten to make use of the new one. 

Otherwise looks good.

Hannes


> Am 26.03.2018 um 14:00 schrieb Sundararajan Athijegannathan 
> :
> 
> Please review http://cr.openjdk.java.net/~sundar/8200215/webrev.00/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8200215
> 
> Thanks,
> -Sundar

Re: RFR 8200215: 17th loop of "let foo = ''"; throws ReferenceError

[Sundararajan Athijegannathan]

Hi Attila,

Yes, new Map has to be created with a property with modified flags. And 
yes, 17 was the clue :)


Thanks,
-Sundar

On 26/03/18, 5:48 PM, Attila Szegedi wrote:

+1, looks good. Presumably this happened on reversal to megamorphic so 
setObject was linked and it didn’t properly handle this case… the crux of the 
matter, if I understand it correctly is that once the property is set, the 
NEEDS_DECLARATION flag needs to be removed, right?

I presume the fast-linked (non-megamorphic) paths handle this correctly 
already, otherwise we would’ve seen the bug on first iteration, not on 17th :-)

Attila.


On 2018. Mar 26., at 14:00, Sundararajan 
Athijegannathan  wrote:

Please review http://cr.openjdk.java.net/~sundar/8200215/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8200215

Thanks,
-Sundar

Re: RFR 8200215: 17th loop of "let foo = ''"; throws ReferenceError

[Jim Laskey]

+1

> On Mar 26, 2018, at 9:00 AM, Sundararajan Athijegannathan 
>  wrote:
> 
> Please review http://cr.openjdk.java.net/~sundar/8200215/webrev.00/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8200215
> 
> Thanks,
> -Sundar

RFR 8200215: 17th loop of "let foo = ''"; throws ReferenceError

[Sundararajan Athijegannathan]

Please review http://cr.openjdk.java.net/~sundar/8200215/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8200215

Thanks,
-Sundar