Re: Review request for JDK-8139884: Use privileged blocks when working with class loaders

[Attila Szegedi]

Hi Michael,

I agree with that in general. I’m using lambdas for doPrivileged here and 
there; in fact my initial version of the code used them, but then I changed 
them back to explicit PrivilegedAction objects as this particular change looks 
like a candidate for backporting to 8u-dev and there we unfortunately can’t use 
lambdas because of Nashorn’s “-source 1.7” requirement, so I’ll avoid them here.

Attila.

> On Oct 19, 2015, at 4:33 PM, Michael Haupt  wrote:
> 
> Hi Attila,
> 
> lower-case thumbs up, with just the remark that lambdas could make the code 
> more concise.
> 
> Best,
> 
> Michael
> 
>> Am 19.10.2015 um 15:53 schrieb Attila Szegedi :
>> 
>> Please review JDK-8139884 "Use privileged blocks when working with class 
>> loaders" at  for 
>> 
>> 
>> Thanks,
>> Attila.
> 
> 

Re: Review request for JDK-8139884: Use privileged blocks when working with class loaders

[Michael Haupt]

Hi Attila,

lower-case thumbs up, with just the remark that lambdas could make the code 
more concise.

Best,

Michael

> Am 19.10.2015 um 15:53 schrieb Attila Szegedi :
> 
> Please review JDK-8139884 "Use privileged blocks when working with class 
> loaders" at  for 
> 
> 
> Thanks,
>  Attila.

Re: Review request for JDK-8139884: Use privileged blocks when working with class loaders

[Sundararajan Athijegannathan]

+1

On 10/19/2015 7:23 PM, Attila Szegedi wrote:

Please review JDK-8139884 "Use privileged blocks when working with class loaders" at 
 for 


Thanks,
   Attila.

Re: Review request for JDK-8139884: Use privileged blocks when working with class loaders

[Hannes Wallnoefer]

+1

Am 2015-10-19 um 15:53 schrieb Attila Szegedi:

Please review JDK-8139884 "Use privileged blocks when working with class loaders" at 
 for 


Thanks,
   Attila.