Re: Review request for JDK-8142864: Raw types warning in WeakValueCache

2015-11-18 Thread Marcus Lagergren 
+1

> On 12 Nov 2015, at 16:36, Hannes Wallnoefer  
> wrote:
> 
> Please review JDK-8142864: Raw types warning in WeakValueCache:
> 
> http://cr.openjdk.java.net/~hannesw/8142864/webrev/
> 
> This removes a warning in WeakValueCache.java, and I also reduced methods by 
> combining code as suggested by Attila.
> 
> Furthermore I renamed method in isWrappedPrimitiveAndObject in 
> ScriptRuntime.java to isPrimitiveAndObject because the primitives are not 
> wrapped (at least not in the JavaScript meaning of the word).
> 
> Thanks,
> Hannes

Re: Review request for JDK-8142864: Raw types warning in WeakValueCache

2015-11-12 Thread Sundararajan Athijegannathan 

+1

On 11/12/2015 9:06 PM, Hannes Wallnoefer wrote:

Please review JDK-8142864: Raw types warning in WeakValueCache:

http://cr.openjdk.java.net/~hannesw/8142864/webrev/

This removes a warning in WeakValueCache.java, and I also reduced 
methods by combining code as suggested by Attila.


Furthermore I renamed method in isWrappedPrimitiveAndObject in 
ScriptRuntime.java to isPrimitiveAndObject because the primitives are 
not wrapped (at least not in the JavaScript meaning of the word).


Thanks,
Hannes

Re: Review request for JDK-8142864: Raw types warning in WeakValueCache

2015-11-12 Thread Michael Haupt 
Hi Hannes,

lower-case thumbs up.

Best,

Michael

> Am 12.11.2015 um 16:36 schrieb Hannes Wallnoefer 
> :
> 
> Please review JDK-8142864: Raw types warning in WeakValueCache:
> 
> http://cr.openjdk.java.net/~hannesw/8142864/webrev/
> 
> This removes a warning in WeakValueCache.java, and I also reduced methods by 
> combining code as suggested by Attila.
> 
> Furthermore I renamed method in isWrappedPrimitiveAndObject in 
> ScriptRuntime.java to isPrimitiveAndObject because the primitives are not 
> wrapped (at least not in the JavaScript meaning of the word).
> 
> Thanks,
> Hannes

-- 

 
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
  Oracle is committed to developing 
practices and products that help protect the environment

Review request for JDK-8142864: Raw types warning in WeakValueCache

2015-11-12 Thread Hannes Wallnoefer 

Please review JDK-8142864: Raw types warning in WeakValueCache:

http://cr.openjdk.java.net/~hannesw/8142864/webrev/

This removes a warning in WeakValueCache.java, and I also reduced 
methods by combining code as suggested by Attila.


Furthermore I renamed method in isWrappedPrimitiveAndObject in 
ScriptRuntime.java to isPrimitiveAndObject because the primitives are 
not wrapped (at least not in the JavaScript meaning of the word).


Thanks,
Hannes