Re: Review request for JDK-8144711: (x) => x + 1 causes Assertion failure instead of SyntaxError

2016-05-04 Thread Sundararajan Athijegannathan 
+1


On 5/4/2016 4:06 PM, Hannes Wallnoefer wrote:
> Thanks Michael,
>
> I uploaded a new webrev that makes sure code does not pass.
>
> http://cr.openjdk.java.net/~hannesw/8144711/webrev.01/
>
> Hannes
>
>
> Am 2016-05-04 um 11:08 schrieb Michael Haupt:
>> Hi Hannes,
>>
>> hang on; one note: the test will "succeed" if the parser throws no
>> exception. It should probably verify that there is an exception in
>> the first place:
>>
>> caught = false
>> try {
>>...
>> } catch (e) {
>>assert ...
>>caught = true
>> }
>> Assert.assertTrue(caught)
>>
>> Best,
>>
>> Michael
>>
>>> Am 04.05.2016 um 11:05 schrieb Michael Haupt
>>> :
>>>
>>> Hi Hannes,
>>>
>>> lower-case thumbs up!
>>>
>>> Best,
>>>
>>> Michael
>>>
 Am 04.05.2016 um 10:49 schrieb Hannes Wallnoefer
 >:

 Please review JDK-8144711: (x) => x + 1 causes Assertion failure
 instead of SyntaxError:

 http://cr.openjdk.java.net/~hannesw/8144711/
 

 Thanks,
 Hannes
>>
>

Re: Review request for JDK-8144711: (x) => x + 1 causes Assertion failure instead of SyntaxError

2016-05-04 Thread Hannes Wallnoefer 

Thanks Michael,

I uploaded a new webrev that makes sure code does not pass.

http://cr.openjdk.java.net/~hannesw/8144711/webrev.01/

Hannes


Am 2016-05-04 um 11:08 schrieb Michael Haupt:

Hi Hannes,

hang on; one note: the test will "succeed" if the parser throws no exception. 
It should probably verify that there is an exception in the first place:

caught = false
try {
   ...
} catch (e) {
   assert ...
   caught = true
}
Assert.assertTrue(caught)

Best,

Michael


Am 04.05.2016 um 11:05 schrieb Michael Haupt :

Hi Hannes,

lower-case thumbs up!

Best,

Michael


Am 04.05.2016 um 10:49 schrieb Hannes Wallnoefer >:

Please review JDK-8144711: (x) => x + 1 causes Assertion failure instead of 
SyntaxError:

http://cr.openjdk.java.net/~hannesw/8144711/ 


Thanks,
Hannes

Re: Review request for JDK-8144711: (x) => x + 1 causes Assertion failure instead of SyntaxError

2016-05-04 Thread Michael Haupt 
Hi Hannes,

hang on; one note: the test will "succeed" if the parser throws no exception. 
It should probably verify that there is an exception in the first place:

caught = false
try {
  ...
} catch (e) {
  assert ...
  caught = true
}
Assert.assertTrue(caught)

Best,

Michael

> Am 04.05.2016 um 11:05 schrieb Michael Haupt :
> 
> Hi Hannes,
> 
> lower-case thumbs up!
> 
> Best,
> 
> Michael
> 
>> Am 04.05.2016 um 10:49 schrieb Hannes Wallnoefer 
>> >:
>> 
>> Please review JDK-8144711: (x) => x + 1 causes Assertion failure instead of 
>> SyntaxError:
>> 
>> http://cr.openjdk.java.net/~hannesw/8144711/ 
>> 
>> 
>> Thanks,
>> Hannes


-- 

 
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
  Oracle is committed to developing 
practices and products that help protect the environment

Re: Review request for JDK-8144711: (x) => x + 1 causes Assertion failure instead of SyntaxError

2016-05-04 Thread Michael Haupt 
Hi Hannes,

lower-case thumbs up!

Best,

Michael

> Am 04.05.2016 um 10:49 schrieb Hannes Wallnoefer 
> :
> 
> Please review JDK-8144711: (x) => x + 1 causes Assertion failure instead of 
> SyntaxError:
> 
> http://cr.openjdk.java.net/~hannesw/8144711/
> 
> Thanks,
> Hannes

-- 

 
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
  Oracle is committed to developing 
practices and products that help protect the environment

Review request for JDK-8144711: (x) => x + 1 causes Assertion failure instead of SyntaxError

2016-05-04 Thread Hannes Wallnoefer 
Please review JDK-8144711: (x) => x + 1 causes Assertion failure instead 
of SyntaxError:


http://cr.openjdk.java.net/~hannesw/8144711/

Thanks,
Hannes