hg: jdk8/tl/jdk: 8006409: ThreadLocalRandom should dropping padding fields from its serialized form
Changeset: 7d272e524768 Author:chegar Date: 2013-02-28 12:39 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7d272e524768 8006409: ThreadLocalRandom should dropping padding fields from its serialized form Reviewed-by: dl, martin, alanb, shade ! src/share/classes/java/util/concurrent/ThreadLocalRandom.java
hg: jdk8/tl/langtools: 3 new changesets
Changeset: 133a0a0c2cbc Author:mcimadamore Date: 2013-02-28 14:00 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/133a0a0c2cbc 8008723: Graph Inference: bad graph calculation leads to assertion error Summary: Dependencies are not propagated correctly through merged nodes during inference graph initialization Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Infer.java + test/tools/javac/lambda/TargetType65.java Changeset: 332f23993353 Author:mcimadamore Date: 2013-02-28 14:05 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/332f23993353 8008813: Structural most specific fails when method reference is passed to overloaded method Summary: Bad logic for checking most specific method reference type Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/lambda/MostSpecific08.java Changeset: 08782b8b03ce Author:mcimadamore Date: 2013-02-28 14:05 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/08782b8b03ce 8008537: Missing method reference lookup error when unbound search finds a static method Summary: Static-ness check should be applied after member reference resolution Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/diags/examples/NonStaticCantBeRefFragment.java + test/tools/javac/diags/examples/StaticMethodInUnboundLookup.java ! test/tools/javac/lambda/MethodReference22.java ! test/tools/javac/lambda/MethodReference22.out ! test/tools/javac/lambda/MethodReference28.out ! test/tools/javac/lambda/MethodReference51.out ! test/tools/javac/lambda/TargetType60.java ! test/tools/javac/lambda/TargetType60.out
Re: ChunkedOutputStream missing last CRLF
Clearly sun.net.www.http.ChunkedOutpuStream is not a public API, so its
direct use is not supported, or recommended.
Users of the HttpURLConnection API can only get indirect references to
ChunkedOutputStream, and these are wrapped in a StreamingOutputStream
[1]. The StreamingOutputStream.close will write the trailing CRLF.
-Chris.
[1]
http://hg.openjdk.java.net/jdk8/tl/jdk/file/7d272e524768/src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java
On 02/28/2013 03:15 PM, Zhong Yu wrote:
HTTP chunked body should be ended with
0 CRLF CRLF
See http://tools.ietf.org/html/rfc2616#section-3.6.1
However sun.net.www.http.ChunkedOutputStream ends only with
0 CRLF
missing the last CRLF.
This is a serious framing error. If an HTTP connection is reused, the
next message head will be considered trailer for the chunked body and
ignored, and the next message body will be parsed as head. If the HTTP
connection is not reused, the other end may be waiting indefinitely
for the chunked body to end.
Test code:
public static void main(String[] args) throws IOException
{
ByteArrayOutputStream out = new ByteArrayOutputStream();
ChunkedOutputStream chunked = new ChunkedOutputStream(new
PrintStream(out));
chunked.close();
out.close();
for(byte b : out.toByteArray())
System.out.println(b);
}
produces 0 CR LF, while it should produce 0 CR LF CR LF.
Zhong Yu
RFR: 8009251 - Add proxy handling and keep-alive fixes to jsse
Hi folks, I'd like to port some changes around proxy handling, keep alive and tunnelling to the HttpsClient. These should have been done along with the HttpClient. Webrev is at: http://cr.openjdk.java.net/~robm/8009251/webrev.01/ related issues: https://jbs.oracle.com/bugs/browse/JDK-7199219 https://jbs.oracle.com/bugs/browse/JDK-7199862 Thanks, -Rob
