Re: RFR: 8230220: java/net/HttpURLConnection/HttpURLProxySelectionTest.java fails intermittently
Hi Jaikiran, It's pushed! Thanks for providing a fix so quickly. best regards, -- daniel On 27/08/2019 13:20, Jaikiran Pai wrote: Thank you. I've updated the webrev at the same location[1] to just include you in the Reviewed-by. No other changes done. [1]http://cr.openjdk.java.net/~jpai/webrev/8230220/2/webrev/ -Jaikiran
Re: RFR: 8230220: java/net/HttpURLConnection/HttpURLProxySelectionTest.java fails intermittently
Hi Daniel, On 27/08/19 5:43 PM, Daniel Fuchs wrote: > Looks good to me Jaikiran. > > Do you want me to sponsor this for you? Yes, please. > > You can count me as Reviewer. Thank you. I've updated the webrev at the same location[1] to just include you in the Reviewed-by. No other changes done. [1] http://cr.openjdk.java.net/~jpai/webrev/8230220/2/webrev/ -Jaikiran
Re: RFR: 8230220: java/net/HttpURLConnection/HttpURLProxySelectionTest.java fails intermittently
Looks good to me Jaikiran. Do you want me to sponsor this for you? You can count me as Reviewer. best regards, -- daniel On 27/08/2019 12:55, Jaikiran Pai wrote: Understood. Here's an updated webrev to include this change http://cr.openjdk.java.net/~jpai/webrev/8230220/2/webrev/ -Jaikiran
Re: RFR: 8230220: java/net/HttpURLConnection/HttpURLProxySelectionTest.java fails intermittently
Hi Daniel,
On 27/08/19 4:49 PM, Daniel Fuchs wrote:
> Hi Jaikiran,
>
> Looks good.
>
> While you're at it, would you mind using
> jdk.test.lib.net.URIBuilder from the /test/lib
> library instead of composing the URL string by hand?
>
> Something like:
>
> URL targetURL = URIBuilder.newBuilder()
> .scheme("http")
> .host(server.getAddress().getAddress())
> .port(server.getAddress().getPort())
> .path(WEB_APP_CONTEXT)
> .toURL();
>
>
> I've come across some host configurations where:
>
> InetAddress.getLoopbackAddress().getHostName() => "localhost"
> but InetAddress.getByName("localhost") returns the external IP (and
> not the loopback). It all depends on what is listed in /etc/hosts.
>
> Using URIBuilder as above will ensure that the host address is
> used (instead of the host name) and that "[" "]" are inserted
> if the address is an IPv6 literal.
Understood. Here's an updated webrev to include this change
http://cr.openjdk.java.net/~jpai/webrev/8230220/2/webrev/
-Jaikiran
RFR: 8230220: java/net/HttpURLConnection/HttpURLProxySelectionTest.java fails intermittently
Can I please get a review and a sponsor for a patch which fixes the issue noted in [1]? The patch is available as a webrev at [2]. This is a newly added testcase as part of a patch that I recently contributed for [3]. As noted by Daniel in [1], the intermittent failure is a result of a race condition in dealing with the member variables, used in the test, across 2 different threads. [1] https://bugs.openjdk.java.net/browse/JDK-8230220 [2] http://cr.openjdk.java.net/~jpai/webrev/8230220/1/webrev/ [3] https://bugs.openjdk.java.net/browse/JDK-8177648 -Jaikiran
RE: RFR [XS] : 8229706: java/net/MulticastSocket/NoLoopbackPackets.java fails on some AIX machines
Thanks for the reviews . I removed the comment and pushed the change . Best regards, Matthias > -Original Message- > From: Langer, Christoph > Sent: Montag, 26. August 2019 16:10 > To: Chris Hegarty ; Baesken, Matthias > > Cc: net-dev@openjdk.java.net > Subject: RE: RFR [XS] : 8229706: > java/net/MulticastSocket/NoLoopbackPackets.java fails on some AIX > machines > > Hi Matthias, > > looks good to me, too. And +1 for dropping the comment. > > Best regards > Christoph > > > -Original Message- > > From: net-dev On Behalf Of Chris > > Hegarty > > Sent: Freitag, 16. August 2019 13:44 > > To: Baesken, Matthias > > Cc: net-dev@openjdk.java.net > > Subject: Re: RFR [XS] : 8229706: > > java/net/MulticastSocket/NoLoopbackPackets.java fails on some AIX > > machines > > > > > > > On 16 Aug 2019, at 10:51, Baesken, Matthias > > > wrote: > > > > > > Thanks alot ! > > > > > > I guess I can push this as trivial (but a second reviewer would be good > too > > ). > > > > The change looks fine. > > > > You could probably drop the comment, I don’t think that > > it’s really needed. > > > > > Best regards, Matthias > > > > > >> -Original Message- > > >> From: Daniel Fuchs > > >> ... > > >> > > >> I haven't observed any failures over 50 runs on all > > >> platforms tested. macosx is problem listed for this > > >> test so it wasn't run there - but all others platforms > > >> passed with your changes. > > > > The set of checks in the NetworkConfiguration for > > has_testableipv6address could probably be expanded to > > include macOS. The maybe the test could be removed > > from the ProblemList ( for mac ). But that is a separate > > issue, for a follow-on, verification, testing, etc. > > > > -Chris.
