Re: RFR: 8077155: LoginContext Subject ignored by jdk8 sun.net.www.protocol.http.HttpURLConnection

2015-05-20 Thread Michael McMahon 

Looks good.

Michael.

On 20/05/15 13:59, Rob McKenna wrote:

Gah, sorry, should have paid more attention to the original change:

http://cr.openjdk.java.net/~robm/8077155/webrev.02/

-Rob

On 20/05/15 13:34, Michael McMahon wrote:

Rob,

There are a few more places where the same limited doPrivileged call 
occurs

in HttpURLConnection and which need the same change.

Michael

On 20/05/15 13:24, Rob McKenna wrote:

Hi folks,

Looking for a review of this webrev:

http://cr.openjdk.java.net/~robm/8077155/webrev.01/

Basically the subjects credentials are not available to
HttpURLConnection.getInputStream0 since it now runs in a doPrivileged
block. Changing that to doPrivilegedWithCombiner allows
getInputStream0 access to the AccessControlContext's DomainCombiner
and the subjects associated credentials.

-Rob

RFR: 8077155: LoginContext Subject ignored by jdk8 sun.net.www.protocol.http.HttpURLConnection

2015-05-20 Thread Rob McKenna 

Hi folks,

Looking for a review of this webrev:

http://cr.openjdk.java.net/~robm/8077155/webrev.01/

Basically the subjects credentials are not available to 
HttpURLConnection.getInputStream0 since it now runs in a doPrivileged 
block. Changing that to doPrivilegedWithCombiner allows getInputStream0 
access to the AccessControlContext's DomainCombiner and the subjects 
associated credentials.


-Rob

Re: RFR: 8077155: LoginContext Subject ignored by jdk8 sun.net.www.protocol.http.HttpURLConnection

2015-05-20 Thread Michael McMahon 

Rob,

There are a few more places where the same limited doPrivileged call occurs
in HttpURLConnection and which need the same change.

Michael

On 20/05/15 13:24, Rob McKenna wrote:

Hi folks,

Looking for a review of this webrev:

http://cr.openjdk.java.net/~robm/8077155/webrev.01/

Basically the subjects credentials are not available to 
HttpURLConnection.getInputStream0 since it now runs in a doPrivileged 
block. Changing that to doPrivilegedWithCombiner allows 
getInputStream0 access to the AccessControlContext's DomainCombiner 
and the subjects associated credentials.


-Rob

Re: RFR: 8077155: LoginContext Subject ignored by jdk8 sun.net.www.protocol.http.HttpURLConnection

2015-05-20 Thread Weijun Wang 

Hi Rob

The src change is good.

As for the test, this line will return the Subject you want

   Context.fromUserPass(WEB_USER, WEB_PASS, false).s()

Thanks
Max


On 5/20/2015 8:24 PM, Rob McKenna wrote:

Hi folks,

Looking for a review of this webrev:

http://cr.openjdk.java.net/~robm/8077155/webrev.01/

Basically the subjects credentials are not available to
HttpURLConnection.getInputStream0 since it now runs in a doPrivileged
block. Changing that to doPrivilegedWithCombiner allows getInputStream0
access to the AccessControlContext's DomainCombiner and the subjects
associated credentials.

 -Rob