Re: RFR: 8259631: Reapply pattern match instanceof use in HttpClientImpl

2021-01-13 Thread Chris Hegarty 
On Tue, 12 Jan 2021 16:05:01 GMT, Aleksei Efimov  wrote:

> Hi,
> 
> The proposed change adds back [1] `instanceof` pattern match use to 
> `HttpClientImpl` class. It was previously removed by 
> [JDK-8258696](https://bugs.openjdk.java.net/browse/JDK-8258696) due to docs 
> build failure.
> 
> Aleksei
> 
> [1] `git rollback be41468c --no-commit`

Marked as reviewed by chegar (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/2051

Re: RFR: 8259631: Reapply pattern match instanceof use in HttpClientImpl

2021-01-12 Thread Daniel Fuchs 
On Tue, 12 Jan 2021 16:05:01 GMT, Aleksei Efimov  wrote:

> Hi,
> 
> The proposed change adds back [1] `instanceof` pattern match use to 
> `HttpClientImpl` class. It was previously removed by 
> [JDK-8258696](https://bugs.openjdk.java.net/browse/JDK-8258696) due to docs 
> build failure.
> 
> Aleksei
> 
> [1] `git rollback be41468c --no-commit`

Approved - provided that tier1 tests are passing ;-)

-

Marked as reviewed by dfuchs (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2051