Code review needed for 6737819

2009-09-15 Thread Jean-Christophe Collet 

Here are the changes for 6737819.
This allows for the previously hard-coded, always in, values for 
http.nonProxyHosts and ftp.nonProxyHosts to be overridden when necessary.
I.E. before it was never possible to reach localhost (and its 
variations) via a proxy (hard coded exemption). These changes keep that 
behavior by default, but make it possible to change it.


http://cr.openjdk.java.net/~jccollet/6737819/webrev.00/

Re: Code review needed for 6737819

2009-09-15 Thread Christopher Hegarty - Sun Microsystems Ireland 

Looks good.

-Chris.

On 15/09/2009 15:36, Jean-Christophe Collet wrote:

Here are the changes for 6737819.
This allows for the previously hard-coded, always in, values for 
http.nonProxyHosts and ftp.nonProxyHosts to be overridden when necessary.
I.E. before it was never possible to reach localhost (and its 
variations) via a proxy (hard coded exemption). These changes keep that 
behavior by default, but make it possible to change it.


http://cr.openjdk.java.net/~jccollet/6737819/webrev.00/

hg: jdk7/tl/langtools: 6882235: invalid exponent causes silent javac crash

2009-09-15 Thread jonathan . gibbons 
Changeset: 9dd34ed62341
Author:jjg
Date:  2009-09-15 12:20 -0700
URL:   http://hg.openjdk.java.net/jdk7/tl/langtools/rev/9dd34ed62341

6882235: invalid exponent causes silent javac crash
Reviewed-by: darcy

! src/share/classes/com/sun/tools/javac/parser/JavacParser.java
+ test/tools/javac/T6882235.java
+ test/tools/javac/T6882235.out

hg: jdk7/tl/langtools: 6860965: Project Coin: binary literals; ...

2009-09-15 Thread jonathan . gibbons 
Changeset: 69eaccd3ea85
Author:jjg
Date:  2009-09-15 18:36 -0700
URL:   http://hg.openjdk.java.net/jdk7/tl/langtools/rev/69eaccd3ea85

6860965: Project Coin: binary literals
6860973: Project Coin: Underscores in literals
Summary: [Portions contributed by Bruce Chapman]
Reviewed-by: darcy

! src/share/classes/com/sun/tools/javac/code/Source.java
! src/share/classes/com/sun/tools/javac/parser/Scanner.java
! src/share/classes/com/sun/tools/javac/resources/compiler.properties
! test/tools/javac/enum/6384542/T6384542.out
+ test/tools/javac/literals/BadBinaryLiterals.6.out
+ test/tools/javac/literals/BadBinaryLiterals.7.out
+ test/tools/javac/literals/BadBinaryLiterals.java
+ test/tools/javac/literals/BadUnderscoreLiterals.6.out
+ test/tools/javac/literals/BadUnderscoreLiterals.7.out
+ test/tools/javac/literals/BadUnderscoreLiterals.java
+ test/tools/javac/literals/BinaryLiterals.java
+ test/tools/javac/literals/UnderscoreLiterals.java

hg: jdk7/tl/jdk: 6882363: 4/4 typos in java.util.logging javadocs

2009-09-15 Thread daniel . daugherty 
Changeset: e8c2dd4b8bac
Author:dcubed
Date:  2009-09-15 22:11 -0600
URL:   http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e8c2dd4b8bac

6882363: 4/4 typos in java.util.logging javadocs
Summary: Fix typos, some grammar and some inconsistencies in phrasing.
Reviewed-by: tbell

! src/share/classes/java/util/logging/ErrorManager.java
! src/share/classes/java/util/logging/FileHandler.java
! src/share/classes/java/util/logging/Formatter.java
! src/share/classes/java/util/logging/Handler.java
! src/share/classes/java/util/logging/Level.java
! src/share/classes/java/util/logging/LogRecord.java
! src/share/classes/java/util/logging/Logger.java
! src/share/classes/java/util/logging/LoggingMXBean.java
! src/share/classes/java/util/logging/MemoryHandler.java
! src/share/classes/java/util/logging/StreamHandler.java