RFR: 8024508 Fix doclint issues in com.sun.nio.sctp
Trivial doclint issues in the com.sun.nio.sctp public package.
diff -r 4fd7abaf0a5f src/share/classes/com/sun/nio/sctp/Association.java
--- a/src/share/classes/com/sun/nio/sctp/Association.java Mon Sep
09 13:44:30 2013 +0100
+++ b/src/share/classes/com/sun/nio/sctp/Association.java Tue Sep
10 10:08:09 2013 +0100
@@ -58,6 +58,13 @@ public class Association {
/**
* Initializes a new instance of this class.
+ *
+ * @param associationID
+ * The association ID
+ * @param maxInStreams
+ * The maximum number of inbound streams
+ * @param maxOutStreams
+ * The maximum number of outbound streams
*/
protected Association(int associationID,
int maxInStreams,
diff -r 4fd7abaf0a5f
src/share/classes/com/sun/nio/sctp/IllegalReceiveException.java
--- a/src/share/classes/com/sun/nio/sctp/IllegalReceiveException.java
Mon Sep 09 13:44:30 2013 +0100
+++ b/src/share/classes/com/sun/nio/sctp/IllegalReceiveException.java
Tue Sep 10 10:08:09 2013 +0100
@@ -41,6 +41,9 @@ public class IllegalReceiveException ext
/**
* Constructs an instance of this class with the specified message.
+ *
+ * @param msg
+ * The String that contains a detailed message
*/
public IllegalReceiveException(String msg) {
super(msg);
diff -r 4fd7abaf0a5f
src/share/classes/com/sun/nio/sctp/IllegalUnbindException.java
--- a/src/share/classes/com/sun/nio/sctp/IllegalUnbindException.java
Mon Sep 09 13:44:30 2013 +0100
+++ b/src/share/classes/com/sun/nio/sctp/IllegalUnbindException.java
Tue Sep 10 10:08:09 2013 +0100
@@ -41,6 +41,9 @@ public class IllegalUnbindException exte
/**
* Constructs an instance of this class with the specified
detailed message.
+ *
+ * @param msg
+ * The String that contains a detailed message
*/
public IllegalUnbindException(String msg) {
super(msg);
diff -r 4fd7abaf0a5f
src/share/classes/com/sun/nio/sctp/InvalidStreamException.java
--- a/src/share/classes/com/sun/nio/sctp/InvalidStreamException.java
Mon Sep 09 13:44:30 2013 +0100
+++ b/src/share/classes/com/sun/nio/sctp/InvalidStreamException.java
Tue Sep 10 10:08:09 2013 +0100
@@ -40,6 +40,9 @@ public class InvalidStreamException exte
/**
* Constructs an instance of this class with the specified
detailed message.
+ *
+ * @param msg
+ * The String that contains a detailed message
*/
public InvalidStreamException(String msg) {
super(msg);
diff -r 4fd7abaf0a5f src/share/classes/com/sun/nio/sctp/MessageInfo.java
--- a/src/share/classes/com/sun/nio/sctp/MessageInfo.java Mon Sep
09 13:44:30 2013 +0100
+++ b/src/share/classes/com/sun/nio/sctp/MessageInfo.java Tue Sep
10 10:08:09 2013 +0100
@@ -48,7 +48,7 @@ import java.net.SocketAddress;
* longer required to be sent after the time period expires. It is not
a hard
* timeout and may be influenced by whether the association supports
the partial
* reliability extension, href=http://www.ietf.org/rfc/rfc3758.txt>RFC 3758
- *
+ * .
*
* {@code MessageInfo} instances are not safe for use by multiple
concurrent
* threads. If a MessageInfo is to be used by more than one thread
then access
diff -r 4fd7abaf0a5f src/share/classes/com/sun/nio/sctp/Notification.java
--- a/src/share/classes/com/sun/nio/sctp/Notification.java Mon Sep
09 13:44:30 2013 +0100
+++ b/src/share/classes/com/sun/nio/sctp/Notification.java Tue Sep
10 10:08:09 2013 +0100
@@ -40,6 +40,8 @@ public interface Notification {
public interface Notification {
/**
* Returns the association that this notification is applicable to.
+ *
+ * @return The association
*/
public Association association();
}
diff -r 4fd7abaf0a5f src/share/classes/com/sun/nio/sctp/SctpChannel.java
--- a/src/share/classes/com/sun/nio/sctp/SctpChannel.java Mon Sep
09 13:44:30 2013 +0100
+++ b/src/share/classes/com/sun/nio/sctp/SctpChannel.java Tue Sep
10 10:08:09 2013 +0100
@@ -59,7 +59,7 @@ import java.nio.channels.SelectionKey;
* {@link #setOption(SctpSocketOption,Object) setOption} method. An SCTP
* channel support the following options:
*
- *
+ *
*
* Option Name
* Description
@@ -636,6 +636,9 @@ public abstract class SctpChannel
/**
* Returns the value of a socket option.
*
+ * @param
+ * The type of the socket option value
+ *
* @param name
* The socket option
*
@@ -658,6 +661,9 @@ public abstract class SctpChannel
/**
* Sets the value of a socket option.
+ *
+ * @param
+ * The type of the socket option value
*
* @param name
* The socket option
@@ -752,6 +758,9 @@ public abstract class SctpChannel
* the {@code receive} method of this channel, if it does an
* {@lin
Re: RFR: 8024508 Fix doclint issues in com.sun.nio.sctp
On 10/09/2013 10:09, Chris Hegarty wrote: Trivial doclint issues in the com.sun.nio.sctp public package. Looks okay to me. I'd suggest checking the bug database as there are existing bugs for this same issue. -Alan
Re: RFR: 8024508 Fix doclint issues in com.sun.nio.sctp
Minor hint, the copyright header year update is missing.
Andreas
On 10.09.2013 11:09, Chris Hegarty wrote:
Trivial doclint issues in the com.sun.nio.sctp public package.
diff -r 4fd7abaf0a5f src/share/classes/com/sun/nio/sctp/Association.java
--- a/src/share/classes/com/sun/nio/sctp/Association.java Mon Sep 09
13:44:30 2013 +0100
+++ b/src/share/classes/com/sun/nio/sctp/Association.java Tue Sep 10
10:08:09 2013 +0100
@@ -58,6 +58,13 @@ public class Association {
/**
* Initializes a new instance of this class.
+ *
+ * @param associationID
+ * The association ID
+ * @param maxInStreams
+ * The maximum number of inbound streams
+ * @param maxOutStreams
+ * The maximum number of outbound streams
*/
protected Association(int associationID,
int maxInStreams,
diff -r 4fd7abaf0a5f
src/share/classes/com/sun/nio/sctp/IllegalReceiveException.java
--- a/src/share/classes/com/sun/nio/sctp/IllegalReceiveException.java
Mon Sep 09 13:44:30 2013 +0100
+++ b/src/share/classes/com/sun/nio/sctp/IllegalReceiveException.java
Tue Sep 10 10:08:09 2013 +0100
@@ -41,6 +41,9 @@ public class IllegalReceiveException ext
/**
* Constructs an instance of this class with the specified message.
+ *
+ * @param msg
+ * The String that contains a detailed message
*/
public IllegalReceiveException(String msg) {
super(msg);
diff -r 4fd7abaf0a5f
src/share/classes/com/sun/nio/sctp/IllegalUnbindException.java
--- a/src/share/classes/com/sun/nio/sctp/IllegalUnbindException.java
Mon Sep 09 13:44:30 2013 +0100
+++ b/src/share/classes/com/sun/nio/sctp/IllegalUnbindException.java
Tue Sep 10 10:08:09 2013 +0100
@@ -41,6 +41,9 @@ public class IllegalUnbindException exte
/**
* Constructs an instance of this class with the specified
detailed message.
+ *
+ * @param msg
+ * The String that contains a detailed message
*/
public IllegalUnbindException(String msg) {
super(msg);
diff -r 4fd7abaf0a5f
src/share/classes/com/sun/nio/sctp/InvalidStreamException.java
--- a/src/share/classes/com/sun/nio/sctp/InvalidStreamException.java
Mon Sep 09 13:44:30 2013 +0100
+++ b/src/share/classes/com/sun/nio/sctp/InvalidStreamException.java
Tue Sep 10 10:08:09 2013 +0100
@@ -40,6 +40,9 @@ public class InvalidStreamException exte
/**
* Constructs an instance of this class with the specified
detailed message.
+ *
+ * @param msg
+ * The String that contains a detailed message
*/
public InvalidStreamException(String msg) {
super(msg);
diff -r 4fd7abaf0a5f src/share/classes/com/sun/nio/sctp/MessageInfo.java
--- a/src/share/classes/com/sun/nio/sctp/MessageInfo.java Mon Sep 09
13:44:30 2013 +0100
+++ b/src/share/classes/com/sun/nio/sctp/MessageInfo.java Tue Sep 10
10:08:09 2013 +0100
@@ -48,7 +48,7 @@ import java.net.SocketAddress;
* longer required to be sent after the time period expires. It is
not a hard
* timeout and may be influenced by whether the association supports
the partial
* reliability extension, href=http://www.ietf.org/rfc/rfc3758.txt>RFC 3758
- *
+ * .
*
* {@code MessageInfo} instances are not safe for use by multiple
concurrent
* threads. If a MessageInfo is to be used by more than one thread
then access
diff -r 4fd7abaf0a5f src/share/classes/com/sun/nio/sctp/Notification.java
--- a/src/share/classes/com/sun/nio/sctp/Notification.java Mon Sep 09
13:44:30 2013 +0100
+++ b/src/share/classes/com/sun/nio/sctp/Notification.java Tue Sep 10
10:08:09 2013 +0100
@@ -40,6 +40,8 @@ public interface Notification {
public interface Notification {
/**
* Returns the association that this notification is applicable to.
+ *
+ * @return The association
*/
public Association association();
}
diff -r 4fd7abaf0a5f src/share/classes/com/sun/nio/sctp/SctpChannel.java
--- a/src/share/classes/com/sun/nio/sctp/SctpChannel.java Mon Sep 09
13:44:30 2013 +0100
+++ b/src/share/classes/com/sun/nio/sctp/SctpChannel.java Tue Sep 10
10:08:09 2013 +0100
@@ -59,7 +59,7 @@ import java.nio.channels.SelectionKey;
* {@link #setOption(SctpSocketOption,Object) setOption} method. An SCTP
* channel support the following options:
*
- *
+ *
*
* Option Name
* Description
@@ -636,6 +636,9 @@ public abstract class SctpChannel
/**
* Returns the value of a socket option.
*
+ * @param
+ * The type of the socket option value
+ *
* @param name
* The socket option
*
@@ -658,6 +661,9 @@ public abstract class SctpChannel
/**
* Sets the value of a socket option.
+ *
+ * @param
+ * The type of the socket option value
*
* @param name
* The socket option
@@ -752,6 +758,9 @@ public abstract class SctpChannel
* the {@c
Re: RFR: 8024508 Fix doclint issues in com.sun.nio.sctp
On 10/09/2013 10:27, Andreas Rieber wrote: Minor hint, the copyright header year update is missing. Andreas We're not strictly required to do that each time, it's a confusing point that comes up regularly (with the result that we are inconsistent). There's a script checked into the top-level repo that can be used to do bulk updates. I don't know how often it is run, hopefully at least once a year. -Alan
Re: RFR: 8024508 Fix doclint issues in com.sun.nio.sctp
On 10.09.2013 11:36, Alan Bateman wrote: On 10/09/2013 10:27, Andreas Rieber wrote: Minor hint, the copyright header year update is missing. Andreas We're not strictly required to do that each time, it's a confusing point that comes up regularly (with the result that we are inconsistent). There's a script checked into the top-level repo that can be used to do bulk updates. I don't know how often it is run, hopefully at least once a year. -Alan OK, thanks for the info. Just most of the time i see that the year gets also updated with changes if not done already. Andreas
hg: jdk8/tl/jdk: 8023878: (fs) TEST_BUG java/nio/file/WatchService/SensitivityModifier.java fails intermittently
Changeset: 909aced59bef Author:alanb Date: 2013-09-10 10:42 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/909aced59bef 8023878: (fs) TEST_BUG java/nio/file/WatchService/SensitivityModifier.java fails intermittently Reviewed-by: alanb Contributed-by: yiming.w...@oracle.com ! test/java/nio/file/WatchService/SensitivityModifier.java
Re: RFR: 8024508 Fix doclint issues in com.sun.nio.sctp
As a point of process, and since the copyright year range update is not strictly required, I typically leave it out of individual "bug" fixes. I have seen too many times where it has caused unnecessary conflicts when sync'ing or backporting. -Chris. On 09/10/2013 10:44 AM, Andreas Rieber wrote: On 10.09.2013 11:36, Alan Bateman wrote: On 10/09/2013 10:27, Andreas Rieber wrote: Minor hint, the copyright header year update is missing. Andreas We're not strictly required to do that each time, it's a confusing point that comes up regularly (with the result that we are inconsistent). There's a script checked into the top-level repo that can be used to do bulk updates. I don't know how often it is run, hopefully at least once a year. -Alan OK, thanks for the info. Just most of the time i see that the year gets also updated with changes if not done already. Andreas
hg: jdk8/tl/langtools: 8024414: javac, should facilitate the use of the bootstrap compiler for debugging
Changeset: d87f017ec217 Author:mcimadamore Date: 2013-09-10 16:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d87f017ec217 8024414: javac, should facilitate the use of the bootstrap compiler for debugging Reviewed-by: jjg ! make/netbeans/langtools/build.xml ! make/tools/anttasks/SelectToolTask.java
hg: jdk8/tl/jdk: 8024501: sun.security.mscapi.Key has no definition of serialVersionUID
Changeset: c9083205e6eb Author:xuelei Date: 2013-09-10 21:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c9083205e6eb 8024501: sun.security.mscapi.Key has no definition of serialVersionUID Reviewed-by: weijun ! src/windows/classes/sun/security/mscapi/Key.java
hg: jdk8/tl/jdk: 8024141: Unexpected timezone display name
Changeset: 13ee370ee8b3 Author:okutsu Date: 2013-09-11 15:29 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/13ee370ee8b3 8024141: Unexpected timezone display name Reviewed-by: peytoia ! src/share/classes/sun/util/locale/provider/LocaleResources.java + test/sun/util/locale/provider/Bug8024141.java
