hg: jdk8/tl/langtools: 8025050: Doclint doesn't recognize tag
Changeset: 96dcb66e6b0a Author:jjg Date: 2013-09-24 10:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/96dcb66e6b0a 8025050: Doclint doesn't recognize tag Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclint/HtmlTag.java ! test/tools/doclint/html/InlineTagsTest.java
hg: jdk8/tl/langtools: 8025246: [doclint] doclint is showing error on anchor already defined when it's not
Changeset: 503338f16d2b Author:jjg Date: 2013-09-24 10:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/503338f16d2b 8025246: [doclint] doclint is showing error on anchor already defined when it's not Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclint/Checker.java + test/tools/doclint/anchorTests/p/Test.java + test/tools/doclint/anchorTests/p/Test.javac.out + test/tools/doclint/anchorTests/p/Test.out + test/tools/doclint/anchorTests/p/package-info.java + test/tools/doclint/anchorTests/p/package-info.javac.out + test/tools/doclint/anchorTests/p/package-info.out
hg: jdk8/tl/langtools: 8025272: doclint needs to check for valid usage of @value tag
Changeset: 6a05a713450d Author:jjg Date: 2013-09-24 11:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6a05a713450d 8025272: doclint needs to check for valid usage of @value tag Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclint/Checker.java ! src/share/classes/com/sun/tools/doclint/resources/doclint.properties + test/tools/doclint/ValueTest.java + test/tools/doclint/ValueTest.out
hg: jdk8/tl/langtools: 8002154: [doclint] doclint should check for issues which are errors in javadoc
Changeset: 3ae62331a56f Author:jjg Date: 2013-09-24 13:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3ae62331a56f 8002154: [doclint] doclint should check for issues which are errors in javadoc Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclint/Checker.java ! src/share/classes/com/sun/tools/doclint/resources/doclint.properties ! test/tools/doclint/ReferenceTest.java ! test/tools/doclint/ReferenceTest.out
hg: jdk8/tl/langtools: 8025407: TypeAnnotations does not use Context
Changeset: 5043e7056be8 Author:jjg Date: 2013-09-25 11:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5043e7056be8 8025407: TypeAnnotations does not use Context Reviewed-by: jfranck ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java
hg: jdk8/tl/langtools: 8025412: Add legal header and comments to test/tools/doclint/tidy/util/Main.java
Changeset: 3d61984b077c Author:jjg Date: 2013-09-25 14:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3d61984b077c 8025412: Add legal header and comments to test/tools/doclint/tidy/util/Main.java Reviewed-by: bpatel ! test/tools/doclint/tidy/util/Main.java ! test/tools/doclint/tidy/util/tidy.sh
hg: jdk8/tl/langtools: 8022163: javac exits with 0 status and no messages on error to construct an ann-procesor
Changeset: 2fa6ced325cc Author:jjg Date: 2013-10-04 13:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2fa6ced325cc 8022163: javac exits with 0 status and no messages on error to construct an ann-procesor Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java + test/tools/javac/processing/errors/TestBadProcessor.java
hg: jdk8/tl/langtools: 6525408: DiagnosticListener should receive MANDATORY_WARNING in standard compiler mode
Changeset: 515d54c1b063 Author:jjg Date: 2013-10-04 14:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/515d54c1b063 6525408: DiagnosticListener should receive MANDATORY_WARNING in standard compiler mode Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/javax/tools/Diagnostic.java
hg: jdk8/tl/langtools: 8025970: Spurious characters in JavaCompiler
Changeset: 3e3c321710be Author:jjg Date: 2013-10-04 15:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3e3c321710be 8025970: Spurious characters in JavaCompiler Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java
hg: jdk8/tl/langtools: 8026294: 8025633 breaks langtools/test/com/sun/javadoc/testRepeatedAnnotations/TestRepeatedAnnotations.java
Changeset: f068d235c4f7 Author:jjg Date: 2013-10-10 17:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f068d235c4f7 8026294: 8025633 breaks langtools/test/com/sun/javadoc/testRepeatedAnnotations/TestRepeatedAnnotations.java Reviewed-by: darcy ! test/com/sun/javadoc/testRepeatedAnnotations/TestRepeatedAnnotations.java
hg: jdk8/tl/langtools: 8026368: doclint does not report empty tags when tag closed implicitly
Changeset: b024fe427d24 Author:jjg Date: 2013-10-14 12:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b024fe427d24 8026368: doclint does not report empty tags when tag closed implicitly Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/Checker.java ! test/tools/doclint/HtmlAttrsTest.java ! test/tools/doclint/HtmlAttrsTest.out ! test/tools/doclint/tidy/BadEnd.out ! test/tools/doclint/tidy/TrimmingEmptyTag.java ! test/tools/doclint/tidy/TrimmingEmptyTag.out
hg: jdk8/tl/langtools: 8026371: "tidy" issues in langtools/src/**/*.html files
Changeset: b9e3b55a908c Author:jjg Date: 2013-10-14 16:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b9e3b55a908c 8026371: "tidy" issues in langtools/src/**/*.html files Reviewed-by: darcy + src/share/classes/com/sun/javadoc/package-info.java - src/share/classes/com/sun/javadoc/package.html + src/share/classes/com/sun/tools/classfile/package-info.java - src/share/classes/com/sun/tools/classfile/package.html + src/share/classes/com/sun/tools/doclets/formats/html/markup/package-info.java - src/share/classes/com/sun/tools/doclets/formats/html/markup/package.html + src/share/classes/com/sun/tools/doclets/formats/html/package-info.java - src/share/classes/com/sun/tools/doclets/formats/html/package.html + src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/package-info.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/package.html + src/share/classes/com/sun/tools/doclets/internal/toolkit/package-info.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/package.html + src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/package-info.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/package.html + src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/package-info.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/package.html + src/share/classes/com/sun/tools/doclets/internal/toolkit/util/package-info.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/util/package.html + src/share/classes/com/sun/tools/doclets/package-info.java - src/share/classes/com/sun/tools/doclets/package.html + src/share/classes/com/sun/tools/javap/package-info.java - src/share/classes/com/sun/tools/javap/package.html ! src/share/classes/javax/lang/model/overview.html ! src/share/classes/javax/tools/overview.html
hg: jdk8/tl/langtools: 8025693: recent javadoc changes cause com/sun/javadoc/testLinkOption/TestLinkOption.java to fail
Changeset: 7d266a2b31b2 Author:jjg Date: 2013-10-14 22:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7d266a2b31b2 8025693: recent javadoc changes cause com/sun/javadoc/testLinkOption/TestLinkOption.java to fail Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java + test/tools/javadoc/8025693/Test.java
hg: jdk8/tl/langtools: 8025998: Missing LV table in lambda bodies
Changeset: 09a414673570 Author:jjg Date: 2013-10-14 23:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/09a414673570 8025998: Missing LV table in lambda bodies Reviewed-by: vromero ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java + test/tools/javac/lambda/LocalVariableTable.java
hg: jdk8/tl/langtools: 8026564: import changes from type-annotations forest
Changeset: b0c086cd4520 Author:jjg Date: 2013-10-15 15:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b0c086cd4520 8026564: import changes from type-annotations forest Reviewed-by: jjg Contributed-by: wdi...@gmail.com, steve.si...@oracle.com ! make/build.properties ! make/build.xml ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/code/SymbolMetadata.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/javax/lang/model/AnnotatedConstruct.java ! test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java ! test/com/sun/javadoc/typeAnnotations/smoke/TestSmoke.java ! test/tools/javac/T7042623.java ! test/tools/javac/annotations/typeAnnotations/classfile/ClassfileTestHelper.java + test/tools/javac/annotations/typeAnnotations/classfile/Scopes.java ! test/tools/javac/annotations/typeAnnotations/failures/AnnotatedImport.java ! test/tools/javac/annotations/typeAnnotations/failures/AnnotatedPackage1.java ! test/tools/javac/annotations/typeAnnotations/failures/AnnotatedPackage1.out ! test/tools/javac/annotations/typeAnnotations/failures/AnnotatedPackage2.java ! test/tools/javac/annotations/typeAnnotations/failures/AnnotationVersion.java ! test/tools/javac/annotations/typeAnnotations/failures/AnnotationVersion.out ! test/tools/javac/annotations/typeAnnotations/failures/AnnotationVersion7.out ! test/tools/javac/annotations/typeAnnotations/failures/BadCast.java ! test/tools/javac/annotations/typeAnnotations/failures/BadCast.out + test/tools/javac/annotations/typeAnnotations/failures/CantAnnotatePackages.java + test/tools/javac/annotations/typeAnnotations/failures/CantAnnotatePackages.out + test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateScoping.java + test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateScoping.out ! test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass.java - test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass.out + test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass2.java + test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass2.out + test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass3.java + test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass3.out ! test/tools/javac/annotations/typeAnnotations/failures/IncompleteArray.java ! test/tools/javac/annotations/typeAnnotations/failures/IncompleteArray.out - test/tools/javac/annotations/typeAnnotations/failures/IncompleteVararg.java - test/tools/javac/annotations/typeAnnotations/failures/IncompleteVararg.out ! test/tools/javac/annotations/typeAnnotations/failures/IndexArray.java ! test/tools/javac/annotations/typeAnnotations/failures/IndexArray.out ! test/tools/javac/annotations/typeAnnotations/failures/LintCast.out ! test/tools/javac/annotations/typeAnnotations/failures/OldArray.java + test/tools/javac/annotations/typeAnnotations/failures/OldArray.out ! test/tools/javac/annotations/typeAnnotations/failures/Scopes.java ! test/tools/javac/annotations/typeAnnotations/failures/Scopes.out ! test/tools/javac/annotations/typeAnnotations/failures/StaticFields.java ! test/tools/javac/annotations/typeAnnotations/failures/StaticFields.out - test/tools/javac/annotations/typeAnnotations/failures/StaticMethods.java - test/tools/javac/annotations/typeAnnotations/failures/StaticMethods.out ! test/tools/javac/annotations/typeAnnotations/failures/TypeVariableCycleTest.java + test/tools/javac/annotations/typeAnnotations/failures/TypeVariableMissingTA.java + test/tools/javac/annotations/typeAnnotations/failures/TypeVariableMissingTA.out - test/tools/javac/diags/examples/CantAnnotateNestedType.java + test/tools/javac/diags/examples/CantAnnotateScoping.java + test/tools/javac/diags/examples/CantAnnotateScoping1.java - test/tools/javac/diags/examples/CantAnnotateStaticClass.java ! test/tools/javac/lib/DPrinter.java ! test/tools/javac/processing/model/type/BasicAnnoTests.java
hg: jdk8/tl/langtools: 8026704: Build failure with --enable-debug
Changeset: d7e155f874a7 Author:jjg Date: 2013-10-16 10:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d7e155f874a7 8026704: Build failure with --enable-debug Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java - test/tools/javac/lambda/LocalVariableTable.java
hg: jdk8/tl/langtools: 8026749: Missing LV table in lambda bodies
Changeset: 7de97abc4a5c Author:jjg Date: 2013-10-18 15:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7de97abc4a5c 8026749: Missing LV table in lambda bodies Reviewed-by: vromero, jlahoda ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java + test/tools/javac/lambda/LocalVariableTable.java
hg: jdk8/tl/langtools: 8025109: Better encapsulation for AnnotatedType
Changeset: e5d3cd43c85e Author:jjg Date: 2013-10-20 12:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e5d3cd43c85e 8025109: Better encapsulation for AnnotatedType Reviewed-by: jjg Contributed-by: wdi...@gmail.com ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java
hg: jdk8/tl/langtools: 8026791: wrong type_path encoded for method_return on an inner class constructor
Changeset: ae4f5cb78ebd Author:jjg Date: 2013-10-20 12:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ae4f5cb78ebd 8026791: wrong type_path encoded for method_return on an inner class constructor Reviewed-by: jjg Contributed-by: wdi...@gmail.com ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/Constructors.java
hg: jdk8/tl/langtools: 2 new changesets
Changeset: 351d6808c1a5 Author:jjg Date: 2013-10-22 17:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/351d6808c1a5 8027119: Cleanup javadoc comments for taglet API Reviewed-by: mduigou ! src/share/classes/com/sun/javadoc/Tag.java Changeset: 41d3ffca22ff Author:jjg Date: 2013-10-22 17:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/41d3ffca22ff Merge
hg: jdk8/tl/langtools: 8028318: [doclint] doclint will reject existing user-written doc comments using custom tags that follow the recommended rules
Changeset: a78f51d6bd5e Author:jjg Date: 2013-11-25 17:42 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a78f51d6bd5e 8028318: [doclint] doclint will reject existing user-written doc comments using custom tags that follow the recommended rules Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/parser/DocCommentParser.java ! test/tools/doclint/CustomTagTest.java ! test/tools/doclint/CustomTagTest.out ! test/tools/doclint/CustomTagTestWithOption.out
Re: Fix for Javadoc errors in java.base
On 8/13/20 10:13 AM, Sean Mullan wrote: On 8/13/20 11:05 AM, Julia Boes wrote: Hi Vipin, Thanks for providing this fix, I'm happy to sponsor your change. To complete the review, we still need someone to green light the remaining changes below. I'm looping in net-dev and security-dev to have a look. Bug: https://bugs.openjdk.java.net/browse/JDK-8251542 Webrev: http://cr.openjdk.java.net/~jboes/webrevs/8251542/webrev/ Once the review is completed, please provide me with a patch that includes a changeset comment as described here: https://openjdk.java.net/guide/producingChangeset.html If you have any questions, let me know. Cheers, Julia --- old/src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java 2020-07-25 23:46:21.233726447 +0530 +++ new/src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java 2020-07-25 23:46:20.721720857 +0530 @@ -96,8 +96,6 @@ * @param p the prime modulus * @param g the base generator * @param l the private-value length - * - * @exception InvalidKeyException if the key cannot be encoded This should actually remain, but it should be ProviderException which is a RuntimeException. See the other DHPrivateKey ctor as that specifies it correctly. --Sean I note the use of `@exception`, as compared to `@throws`, which is more common. Stats: `@exception` 7322 occurrences `@throws` 21173 occurrences That's probably too many `@exception` to clean up. :-( -- Jon
Re: RFR: 8252999: Cleanup: replace .equals("") with .isEmpty() within all codebase
On Thu, 10 Sep 2020 12:04:48 GMT, Dmitriy Dumanskiy wrote: > I have in mind dozens of improvements all over the code like this one. That sounds scary. Broad updates like these cause unnecessary churn in the codebase, and can make merging and back porting harder. Changes should be discussed ahead of time with the appropriate teams. - PR: https://git.openjdk.java.net/jdk/pull/29
RFR: JDK-8255262: Remove use of legacy custom @spec tag
The change is (just) to remove legacy usages of a JDK-private custom tag. - Commit messages: - JDK-8255262: Remove use of legacy custom @spec tag Changes: https://git.openjdk.java.net/jdk/pull/814/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=814&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8255262 Stats: 209 lines in 69 files changed: 0 ins; 209 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/814.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/814/head:pull/814 PR: https://git.openjdk.java.net/jdk/pull/814
Integrated: JDK-8255262: Remove use of legacy custom @spec tag
On Thu, 22 Oct 2020 17:16:23 GMT, Jonathan Gibbons wrote: > The change is (just) to remove legacy usages of a JDK-private custom tag. This pull request has now been integrated. Changeset: 0aa3c925 Author: Jonathan Gibbons URL: https://git.openjdk.java.net/jdk/commit/0aa3c925 Stats: 209 lines in 69 files changed: 0 ins; 209 del; 0 mod 8255262: Remove use of legacy custom @spec tag Reviewed-by: lancea, mr, iris, alanb, darcy, mchung - PR: https://git.openjdk.java.net/jdk/pull/814
Re: RFR: 8258696: Temporarily revert use of pattern match instanceof until docs-reference is fixed
On Fri, 18 Dec 2020 16:54:59 GMT, Chris Hegarty wrote:
> Temporarily revert use of pattern match instanceof construct until
> docs-reference is fixed, see JDK-8258657.
>
> ...
> Generating REFERENCE_API javadoc for 21 modules
>
> if (delegate instanceof ExecutorService service) {
> ^
> (use --enable-preview to enable pattern matching in instanceof)
> 1 error
> make[3]: ***
> [/Users/chhegar/git/open/build/macosx-x64/support/docs/_javadoc_REFERENCE_API_exec.marker]
> Error 1
> Docs.gmk:472: recipe for target
> '/Users/chhegar/git/open/build/macosx-x64/support/docs/_javadoc_REFERENCE_API_exec.marker'
> failed
> make/Main.gmk:485: recipe for target 'docs-reference-api-javadoc' failed
> make[2]: *** [docs-reference-api-javadoc] Error 2
> make[2]: *** Waiting for unfinished jobs
Marked as reviewed by jjg (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/1843
RFR: JDK-8262430: doclint warnings in java.base module
Please review some simple doc fixes in the `java.base` module. Two were reported by doclint; the spelling error was detected by the IDE. - Commit messages: - JDK-8262430: doclint warnings in java.base module Changes: https://git.openjdk.java.net/jdk/pull/2734/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2734&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8262430 Stats: 3 lines in 2 files changed: 1 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/2734.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2734/head:pull/2734 PR: https://git.openjdk.java.net/jdk/pull/2734
Integrated: JDK-8262430: doclint warnings in java.base module
On Thu, 25 Feb 2021 22:59:23 GMT, Jonathan Gibbons wrote: > Please review some simple doc fixes in the `java.base` module. Two were > reported by doclint; the spelling error was detected by the IDE. This pull request has now been integrated. Changeset: 3088e1e6 Author:Jonathan Gibbons URL: https://git.openjdk.java.net/jdk/commit/3088e1e6 Stats: 3 lines in 2 files changed: 1 ins; 1 del; 1 mod 8262430: doclint warnings in java.base module Reviewed-by: alanb, chegar, dfuchs, lancea - PR: https://git.openjdk.java.net/jdk/pull/2734
RFR: JDK-8262875: doccheck: empty paragraphs, etc in java.base module
Please review some minor doc fixes, for issues found by _doccheck_.There are two kinds of errors that are addressed. 1. Incorrect use of ``. In HTML, `` marks the *beginning* of a paragraph. It is not a terminator, to mark the end of a paragraph, or a separator to mark the boundary between paragraphs. In particular, it should not be used at the end of a description before a javadoc block tag, such as `@param` or before other HTML block tags, like `` or ``. 2. References to the id `package-description`, following the recent standardization of all ids generated by javadoc, - Commit messages: - JDK-8262875: doccheck: empty paragraphs, etc in java.base module Changes: https://git.openjdk.java.net/jdk/pull/2795/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2795&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8262875 Stats: 9 lines in 8 files changed: 0 ins; 1 del; 8 mod Patch: https://git.openjdk.java.net/jdk/pull/2795.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2795/head:pull/2795 PR: https://git.openjdk.java.net/jdk/pull/2795
Integrated: JDK-8262875: doccheck: empty paragraphs, etc in java.base module
On Tue, 2 Mar 2021 19:35:47 GMT, Jonathan Gibbons wrote: > Please review some minor doc fixes, for issues found by _doccheck_.There > are two kinds of errors that are addressed. > > 1. Incorrect use of ``. In HTML, `` marks the *beginning* of a > paragraph. It is not a terminator, to mark the end of a paragraph, or a > separator to mark the boundary between paragraphs. In particular, it should > not be used at the end of a description before a javadoc block tag, such as > `@param` or before other HTML block tags, like `` or ``. > > 2. References to the id `package-description`, following the recent > standardization of all ids generated by javadoc, This pull request has now been integrated. Changeset: 20b9ba53 Author:Jonathan Gibbons URL: https://git.openjdk.java.net/jdk/commit/20b9ba53 Stats: 9 lines in 8 files changed: 0 ins; 1 del; 8 mod 8262875: doccheck: empty paragraphs, etc in java.base module Reviewed-by: alanb, darcy, lancea - PR: https://git.openjdk.java.net/jdk/pull/2795
Re: RFR: JDK-8262992: Improve `@see` output [v2]
On Tue, 9 Mar 2021 16:23:26 GMT, Hannes Wallnöfer wrote:
>> This changes the output for `@see` tags to a `` structure. A different
>> CSS style is used if any of the `@see` tag labels are longer than 30
>> characters or contain a comma.
>>
>> The layout for the default CSS style is similar to the one we had so far
>> with multiple links displayed inline and separated by commas. The CSS style
>> for lists containing longer labels displays the list in block mode, but
>> still separated by commas and without list markers. Note that the commas are
>> generated via CSS in both cases.
>>
>> As expected, there's a lot of test churn with this change. I converted some
>> tests to text blocks that were still using old style string concatenation.
>> In `TestSingletonLists.java` I had to exclude `@see` lists from the
>> singleton check as javadoc generates a "See also" item for constant field
>> values.
>
> Hannes Wallnöfer has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Update `@see` tag in class java.security.cert.PKIXRevocationChecker
Nice! I like the basic change to `TagletWriterImpl`.
Close to being approved, but there are some minor comments inline for
disciussion or to be addressed.
src/java.base/share/classes/java/security/cert/PKIXRevocationChecker.java line
97:
> 95: * @see http://www.ietf.org/rfc/rfc5280.txt";>RFC 5280:
> 96: * Internet X.509 Public Key Infrastructure Certificate and Certificate
> 97: * Revocation List (CRL) Profile
It's not wrong, but the use of `...` is non-standard. But, while we
should split the malformed entry, it's arguably out of scope to tweak the style.
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/TagletWriterImpl.java
line 148:
> 146: // Threshold for length of @see tag label for switching from inline
> to block layout.
> 147: private static final int SEE_TAG_MAX_INLINE_LENGTH = 30;
> 148:
For future consideration, we should look at encoding numbers like this in a
config file.
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlStyle.java
line 361:
> 359: */
> 360: seeListLong,
> 361:
The list is alpha-sorted in each group, suggesting that these new entries
should go before `serializedClassDetails`.
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/stylesheet.css
line 346:
> 344: content: ", ";
> 345: white-space: pre-wrap;
> 346: }
Cool! I didn't know you could do that. Is this widely supported?
test/langtools/jdk/javadoc/doclet/testConstructors/TestConstructors.java line
63:
> 61:
> 62: """,
> 63: """
Nice new rendering ... i.e. the general use of ``
test/langtools/jdk/javadoc/doclet/testLinkOption/pkg/B.java line 64:
> 62: * Literal IPv6 Addresses in URLs
> 63: * @see A nearby file
> 64: */
Wow, I didn't know we had "bad" examples in the test code. If there isn't one
already, can you file an issue for me to updated DocLint with a check for this?
test/langtools/jdk/javadoc/doclet/testSingletonLists/TestSingletonLists.java
line 270:
> 268: if ("see-list".equals(attrs.get("class"))) {
> 269: inSeeList = true;
> 270: }
This is OK for now, because the lists from `@see` tags cannot be nested. But, I
had a similar problem in my work yesterday, and so going forward we might want
a more general solution to track the class of each list on the stack.
test/langtools/jdk/javadoc/doclet/testSingletonLists/TestSingletonLists.java
line 287:
> 285: Map c = counts.pop();
> 286: if (inSeeList) {
> 287: // Ignore "Constant Field Values" @see items for
> final fields created by javadoc
I think the comment is too specific. Won't the problem also be triggered for
classes with a single `@see` and no constant values? It m might also be
triggered on serializable classes, with the link to the `Serialized Form`.
-
PR: https://git.openjdk.java.net/jdk/pull/2894
Re: RFR: JDK-8262992: Improve `@see` output [v2]
On Thu, 11 Mar 2021 15:17:50 GMT, Jonathan Gibbons wrote: >> Hannes Wallnöfer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update `@see` tag in class java.security.cert.PKIXRevocationChecker > > Nice! I like the basic change to `TagletWriterImpl`. > > Close to being approved, but there are some minor comments inline for > disciussion or to be addressed. Reviewed earlier feedback. Waiting for responses... - PR: https://git.openjdk.java.net/jdk/pull/2894
Re: RFR: JDK-8262992: Improve `@see` output [v6]
On Wed, 5 May 2021 15:09:17 GMT, Hannes Wallnöfer wrote: >> This changes the output for `@see` tags to a `` structure. A different >> CSS style is used if any of the `@see` tag labels are longer than 30 >> characters or contain a comma. >> >> The layout for the default CSS style is similar to the one we had so far >> with multiple links displayed inline and separated by commas. The CSS style >> for lists containing longer labels displays the list in block mode, but >> still separated by commas and without list markers. Note that the commas are >> generated via CSS in both cases. >> >> As expected, there's a lot of test churn with this change. I converted some >> tests to text blocks that were still using old style string concatenation. >> In `TestSingletonLists.java` I had to exclude `@see` lists from the >> singleton check as javadoc generates a "See also" item for constant field >> values. > > Hannes Wallnöfer has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains six commits: > > - Merge branch 'master' into JDK-8262992 > - Put enum constants into alphabetical order. > - Adapt new test > - Merge branch 'master' into JDK-8262992 > - Update `@see` tag in class java.security.cert.PKIXRevocationChecker > - JDK-8262992: Improve `@see` output Marked as reviewed by jjg (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2894
Re: RFR: JDK-8275518: accessibility issue in Inet6Address docs
On Tue, 19 Oct 2021 13:50:20 GMT, Ludvig Janiuk wrote: > Single-row table was being used for visual effect, but a description list > seems more appropriate. OK, but ... While the basic translation from a single-row table to a definition list looks good, it's not clear you still need the `style` attribute. Also, explicit use of `` and `` is discouraged for accessibility reasons; if you need any tags to adjust the font here, it's better to use semantic equivalents like `` and `` (emphasis). But even better to reduce unnecessary stylistic changes and rely on the default settings (in this case for ``) in the stylesheet. - Marked as reviewed by jjg (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6010
Re: RFR: JDK-8275518: accessibility issue in Inet6Address docs [v2]
On Thu, 28 Oct 2021 12:11:33 GMT, Ludvig Janiuk wrote: >> Single-row table was being used for visual effect, but a description list >> seems more appropriate. > > Ludvig Janiuk has updated the pull request incrementally with one additional > commit since the last revision: > > Removed html fluff Latest version, with latest modifications, approved. - Marked as reviewed by jjg (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6010
[jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC
Please review this semi-automatic update for the nroff man pages for JDK 18. The changes update the version number, copyright year, and incorporate the changes from the latest upstream files. - Commit messages: - JDK-8273179: Update nroff pages in JDK 18 before RC Changes: https://git.openjdk.java.net/jdk18/pull/5/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18&pr=5&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8273179 Stats: 858 lines in 28 files changed: 448 ins; 146 del; 264 mod Patch: https://git.openjdk.java.net/jdk18/pull/5.diff Fetch: git fetch https://git.openjdk.java.net/jdk18 pull/5/head:pull/5 PR: https://git.openjdk.java.net/jdk18/pull/5
Re: [jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC
On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons wrote: > Please review this semi-automatic update for the nroff man pages for JDK 18. > The changes update the version number, copyright year, and incorporate the > changes from the latest upstream files. Hi David, The copyright year will naturally sort itself out in a few weeks time ;-) When these changes make their way down from 18 to 19, we will probably want to regenerate these files with 19-EA. -- Jon We will also want to regenerate any appropriate files if any more updates to the man pages are made during the ramp down period. - PR: https://git.openjdk.java.net/jdk18/pull/5
[jdk18] Integrated: JDK-8273179: Update nroff pages in JDK 18 before RC
On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons wrote: > Please review this semi-automatic update for the nroff man pages for JDK 18. > The changes update the version number, copyright year, and incorporate the > changes from the latest upstream files. This pull request has now been integrated. Changeset: ed5d53ae Author: Jonathan Gibbons URL: https://git.openjdk.java.net/jdk18/commit/ed5d53ae0eb0b12de11fb3d79ae0371c093ce434 Stats: 858 lines in 28 files changed: 448 ins; 146 del; 264 mod 8273179: Update nroff pages in JDK 18 before RC Reviewed-by: dholmes - PR: https://git.openjdk.java.net/jdk18/pull/5
Re: [jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC
On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons wrote: > Please review this semi-automatic update for the nroff man pages for JDK 18. > The changes update the version number, copyright year, and incorporate the > changes from the latest upstream files. hmmm, I thought we had taken care of that test. I will investigate - PR: https://git.openjdk.java.net/jdk18/pull/5
Re: network tests
Alan, I can imagine two possibilities here: 1) pass a system property to each test that defines a config file in properties format that canbe read by any test that needs it 2) allow a new option to main/applet/shell tests that define a config value that will be passed to the test via a system property or environment variable. Eg @run main/config=XYZ The former requires less change to the test but does require the test to be able to read files. The latter is a bigger change to the spec but doesn't run into any security manager issues. -- Jon On May 24, 2008, at 6:29 AM, Alan Bateman wrote: Joe Darcy wrote: : Could the classic networking tests be refactored a bit to be centralized like the nio tests? Would it be natural for classic networking and nio to get their host information from the same place? There was a time when the networking tests had dependencies on quite a few web servers, proxies, etc. but there was effort to replace these tests so there should only be a few dependencies remaining. I briefly looked at the tests today and I was surprised to only find one test that attempts a lookup of a Sun internal host. The other tests with dependencies weren't moved from closed->open. In any case, it should be straight-forward to centralize the dependencies into one place. : Even if the Sun-internal settings remain baked in, I think an easy way to pass in a limited number of configuration settings is appropriate and shouldn't be too hard to accommodate in the test code. Presumably an interface like "openjtreg - Dmy.config.options=foo ..." wouldn't be too awkward to use. If by "baked in" you mean a default configuration file for when the property or other knob isn't used then it seems reasonable. Are you thinking of passing in the individual parameters as properties or have one property to locate a properties/config file with the settings? -Alan.
hg: jdk7/tl/langtools: 6764226: ListTest fails on javap output with bad characters
Changeset: 5ebe90e0afff Author:jjg Date: 2008-10-27 14:25 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/5ebe90e0afff 6764226: ListTest fails on javap output with bad characters Reviewed-by: darcy ! test/tools/javap/ListTest.java
hg: jdk7/tl/langtools: 6778493: Fix (langtools) ant build to honor fcs MILESTONE setting
Changeset: 6210fb7e7544 Author:jjg Date: 2008-12-01 12:15 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/6210fb7e7544 6778493: Fix (langtools) ant build to honor fcs MILESTONE setting Reviewed-by: ohair Contributed-by: [EMAIL PROTECTED] ! make/Makefile
hg: jdk7/tl/langtools: 6778638: javadoc regression tests require tabs
Changeset: 8db0c5fd6e99 Author:jjg Date: 2008-12-02 14:35 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/8db0c5fd6e99 6778638: javadoc regression tests require tabs Reviewed-by: darcy ! test/com/sun/javadoc/testSourceTab/DoubleTab/C.java ! test/com/sun/javadoc/testSourceTab/SingleTab/C.java ! test/com/sun/javadoc/testSourceTab/TestSourceTab.java
hg: jdk7/tl/langtools: 6512707: "incompatible types" after (unrelated) annotation processing
Changeset: 7a595d92e252 Author:jjg Date: 2009-01-07 14:48 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/7a595d92e252 6512707: "incompatible types" after (unrelated) annotation processing Reviewed-by: darcy Contributed-by: pru...@velocitynet.com.au ! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java + test/tools/javac/processing/6512707/T6512707.java + test/tools/javac/processing/6512707/TestAnnotation.java + test/tools/javac/processing/6512707/TestEnum.java
hg: jdk7/tl/langtools: 6794520: MessageRetriever should be upgraded to use varargs Object...
Changeset: 42f9d392159d Author:jjg Date: 2009-01-15 18:06 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/42f9d392159d 6794520: MessageRetriever should be upgraded to use varargs Object... Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/MessageRetriever.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java
hg: jdk7/tl/langtools: 6794959: add new switch -XDexpectKeys=key, key....
Changeset: d0b33fe8e710 Author:jjg Date: 2009-01-19 19:36 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d0b33fe8e710 6794959: add new switch -XDexpectKeys=key,key Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/util/Log.java + test/tools/javac/T6794959.java
hg: jdk7/tl/langtools: 6794582: javadoc should read files using a FileManager
Changeset: 1bf037016426 Author:jjg Date: 2009-01-20 15:17 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/1bf037016426 6794582: javadoc should read files using a FileManager Reviewed-by: darcy, bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/SourceToHTMLConverter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/DocEnv.java ! src/share/classes/com/sun/tools/javadoc/DocImpl.java ! src/share/classes/com/sun/tools/javadoc/ExecutableMemberDocImpl.java ! src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java ! src/share/classes/com/sun/tools/javadoc/JavadocClassReader.java ! src/share/classes/com/sun/tools/javadoc/JavadocTool.java ! src/share/classes/com/sun/tools/javadoc/PackageDocImpl.java ! src/share/classes/com/sun/tools/javadoc/RootDocImpl.java ! src/share/classes/com/sun/tools/javadoc/SourcePositionImpl.java
hg: jdk7/tl/langtools: 6795903: fix latent build warnings in langtools repository
Changeset: b4b1f7732289 Author:jjg Date: 2009-01-20 18:23 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/b4b1f7732289 6795903: fix latent build warnings in langtools repository Reviewed-by: darcy ! make/build.properties ! src/share/classes/com/sun/tools/apt/comp/AnnotationProcessingError.java ! src/share/classes/com/sun/tools/apt/comp/Apt.java ! src/share/classes/com/sun/tools/apt/comp/UsageMessageNeededException.java ! src/share/classes/com/sun/tools/apt/main/JavaCompiler.java ! src/share/classes/com/sun/tools/apt/mirror/apt/RoundCompleteEventImpl.java ! src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationProxyMaker.java ! src/share/classes/com/sun/tools/apt/mirror/type/TypeVariableImpl.java ! src/share/classes/com/sun/tools/classfile/Annotation.java ! src/share/classes/com/sun/tools/classfile/AttributeException.java ! src/share/classes/com/sun/tools/classfile/Code_attribute.java ! src/share/classes/com/sun/tools/classfile/ConstantPool.java ! src/share/classes/com/sun/tools/classfile/ConstantPoolException.java ! src/share/classes/com/sun/tools/classfile/Descriptor.java ! src/share/classes/com/sun/tools/classfile/DescriptorException.java ! src/share/classes/com/sun/tools/classfile/StackMapTable_attribute.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/SerializedFormBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocletAbortException.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/util/BasicDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javadoc/Comment.java ! src/share/classes/com/sun/tools/javadoc/Messager.java ! src/share/classes/com/sun/tools/javadoc/TypeMaker.java ! src/share/classes/com/sun/tools/javah/Gen.java ! src/share/classes/com/sun/tools/javap/InternalError.java ! src/share/classes/sun/tools/javap/JavapPrinter.java
hg: jdk7/tl/langtools: 6795030: Files in langtools build can be compiled ignoring java.home settings
Changeset: d486ac6389d7 Author:jjg Date: 2009-01-21 08:21 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d486ac6389d7 6795030: Files in langtools build can be compiled ignoring java.home settings Reviewed-by: mcimadamore ! make/build.xml
hg: jdk7/tl/langtools: 6796965: dev-time wrapper script for javac broken
Changeset: e6dafbf35355 Author:jjg Date: 2009-01-22 15:45 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e6dafbf35355 6796965: dev-time wrapper script for javac broken Reviewed-by: ksrini ! make/build.xml
hg: jdk7/tl/langtools: 6795365: NetBeans projects in langtools repository are not NB6.5-friendly
Changeset: e3930187199c Author:jjg Date: 2009-01-23 11:23 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e3930187199c 6795365: NetBeans projects in langtools repository are not NB6.5-friendly Reviewed-by: mcimadamore ! make/README ! make/build.xml ! make/netbeans/README - make/netbeans/apt/README - make/netbeans/apt/build.xml - make/netbeans/apt/nbproject/project.xml - make/netbeans/common/shared.xml - make/netbeans/common/standard-context-menu-items-no-javadoc.ent - make/netbeans/common/standard-context-menu-items.ent - make/netbeans/common/standard-ide-actions-no-javadoc.ent - make/netbeans/common/standard-ide-actions.ent - make/netbeans/compiler/README - make/netbeans/compiler/build.xml - make/netbeans/compiler/nbproject/project.xml - make/netbeans/doclets/README - make/netbeans/doclets/build.xml - make/netbeans/doclets/nbproject/project.xml - make/netbeans/javadoc/README - make/netbeans/javadoc/build.xml - make/netbeans/javadoc/nbproject/project.xml - make/netbeans/javah/README - make/netbeans/javah/build.xml - make/netbeans/javah/nbproject/project.xml - make/netbeans/javap/README - make/netbeans/javap/build.xml - make/netbeans/javap/nbproject/project.xml + make/netbeans/langtools/build.xml + make/netbeans/langtools/nbproject/project.xml + make/netbeans/langtools/nbproject/standard-context-menu-items.ent + make/netbeans/langtools/nbproject/standard-ide-actions.ent + make/tools/SelectTool/SelectToolTask.java
hg: jdk7/tl/langtools: 6176978: current Javadoc's invocation and extension (Doclet) mechanisms are problematic
Changeset: 9199b9092f73 Author:jjg Date: 2009-01-27 18:38 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/9199b9092f73 6176978: current Javadoc's invocation and extension (Doclet) mechanisms are problematic Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/DocletInvoker.java + test/tools/javadoc/6176978/T6176978.java + test/tools/javadoc/6176978/X.java
hg: jdk7/tl/langtools: 6595666: fix -Werror
Changeset: 9d541fd2916b Author:jjg Date: 2009-02-06 10:23 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/9d541fd2916b 6595666: fix -Werror Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/main/RecognizedOptions.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/resources/javac.properties ! test/tools/javac/6304921/T6304921.out ! test/tools/javac/6758789/T6758789b.out ! test/tools/javac/T6241723.out + test/tools/javac/T6595666.java ! test/tools/javac/depDocComment/DeprecatedDocComment.out
hg: jdk7/tl/corba: 6809563: corba build in JDK uses invalid bootclasspath for javah
Changeset: 9e6c48c2582d Author:jjg Date: 2009-02-26 18:28 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/9e6c48c2582d 6809563: corba build in JDK uses invalid bootclasspath for javah Reviewed-by: ohair ! make/common/shared/Defs-java.gmk
hg: jdk7/tl/corba: 6810915: Sun proprietary warnings in JDK build
Changeset: db35452e8965 Author:jjg Date: 2009-02-26 18:32 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/db35452e8965 6810915: Sun proprietary warnings in JDK build Reviewed-by: ohair ! make/Makefile ! make/common/shared/Defs-java.gmk
hg: jdk7/tl/jdk: 6810915: Sun proprietary warnings in JDK build
Changeset: 4f0b6455a977 Author:jjg Date: 2009-02-26 18:51 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4f0b6455a977 6810915: Sun proprietary warnings in JDK build Reviewed-by: ohair ! make/common/shared/Defs-java.gmk ! make/docs/Makefile ! make/javax/swing/beaninfo/SwingBeans.gmk
hg: jdk7/tl/langtools: 6819246: improve support for decoding instructions in classfile library
Changeset: 07da2ffbb76b Author:jjg Date: 2009-03-30 15:08 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/07da2ffbb76b 6819246: improve support for decoding instructions in classfile library Reviewed-by: ksrini ! src/share/classes/com/sun/tools/classfile/Code_attribute.java + src/share/classes/com/sun/tools/classfile/Instruction.java - src/share/classes/com/sun/tools/classfile/OpCodes.java + src/share/classes/com/sun/tools/classfile/Opcode.java ! src/share/classes/com/sun/tools/javap/CodeWriter.java
hg: jdk7/tl/langtools: 6817950: refactor ClassReader to improve attribute handling
Changeset: 89f67512b635 Author:jjg Date: 2009-03-31 11:07 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/89f67512b635 6817950: refactor ClassReader to improve attribute handling Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/jvm/ClassFile.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java
hg: jdk7/tl/langtools: 6813059: replace use of JavaCompiler.errorCount with shouldContinue
Changeset: af10262bd031 Author:jjg Date: 2009-03-31 11:16 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/af10262bd031 6813059: replace use of JavaCompiler.errorCount with shouldContinue Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java + test/tools/javac/policy/test3/A.java + test/tools/javac/policy/test3/Test.java
hg: jdk7/tl/langtools: 6841422: classfile: add Type visitor
Changeset: b5872f0790e7 Author:jjg Date: 2009-05-19 11:27 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/b5872f0790e7 6841422: classfile: add Type visitor Reviewed-by: mcimadamore Contributed-by: kevin.t.loo...@sun.com ! src/share/classes/com/sun/tools/classfile/Type.java
hg: jdk7/tl/langtools: 6841420: classfile: add new methods to ConstantClassInfo
Changeset: f838537fb1ac Author:jjg Date: 2009-05-19 11:33 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/f838537fb1ac 6841420: classfile: add new methods to ConstantClassInfo Reviewed-by: mcimadamore Contributed-by: kevin.t.loo...@sun.com ! src/share/classes/com/sun/tools/classfile/ConstantPool.java
hg: jdk7/tl/langtools: 6841419: classfile: add constant pool iterator
Changeset: fc634a593812 Author:jjg Date: 2009-05-19 11:43 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/fc634a593812 6841419: classfile: add constant pool iterator Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/classfile/ClassTranslator.java ! src/share/classes/com/sun/tools/classfile/ClassWriter.java ! src/share/classes/com/sun/tools/classfile/ConstantPool.java
hg: jdk7/tl/langtools: 6824493: experimental support for additional info for instructions
Changeset: cd0630109de5 Author:jjg Date: 2009-05-19 11:50 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/cd0630109de5 6824493: experimental support for additional info for instructions Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/classfile/StackMapTable_attribute.java ! src/share/classes/com/sun/tools/javap/BasicWriter.java ! src/share/classes/com/sun/tools/javap/ClassWriter.java ! src/share/classes/com/sun/tools/javap/CodeWriter.java + src/share/classes/com/sun/tools/javap/InstructionDetailWriter.java ! src/share/classes/com/sun/tools/javap/JavapTask.java + src/share/classes/com/sun/tools/javap/Messages.java ! src/share/classes/com/sun/tools/javap/Options.java + src/share/classes/com/sun/tools/javap/SourceWriter.java + src/share/classes/com/sun/tools/javap/StackMapWriter.java + src/share/classes/com/sun/tools/javap/TryBlockWriter.java ! src/share/classes/com/sun/tools/javap/resources/javap.properties + test/tools/javap/T6824493.java
hg: jdk7/tl/langtools: 6843013: missing files in fix for 6824493
Changeset: 0c6cd88f72b9 Author:jjg Date: 2009-05-19 13:53 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/0c6cd88f72b9 6843013: missing files in fix for 6824493 Reviewed-by: darcy + src/share/classes/com/sun/tools/javap/LocalVariableTableWriter.java + src/share/classes/com/sun/tools/javap/LocalVariableTypeTableWriter.java
hg: jdk7/tl/langtools: 6832154: refactor Paths to be just a utility class for JavacFileManager
Changeset: 4ce1c1400334 Author:jjg Date: 2009-05-19 15:07 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4ce1c1400334 6832154: refactor Paths to be just a utility class for JavacFileManager Reviewed-by: darcy ! src/share/classes/com/sun/tools/apt/main/Main.java ! src/share/classes/com/sun/tools/javac/file/Paths.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java
hg: jdk7/tl/langtools: 6827026: Change javac source and target default to 7
Changeset: 79eb8795a1de Author:jjg Date: 2009-05-20 13:36 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/79eb8795a1de 6827026: Change javac source and target default to 7 Reviewed-by: darcy, ohair ! make/Makefile ! make/build.properties ! make/build.xml ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/jvm/Target.java
hg: jdk7/tl/corba: 6827026: Change javac source and target default to 7
Changeset: 2752d8bd4142 Author:jjg Date: 2009-05-20 13:41 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/2752d8bd4142 6827026: Change javac source and target default to 7 Reviewed-by: darcy, ohair ! make/Makefile
hg: jdk7/tl/jaxp: 6827026: Change javac source and target default to 7
Changeset: bdaf6acaf6e3 Author:jjg Date: 2009-05-20 13:45 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/bdaf6acaf6e3 6827026: Change javac source and target default to 7 Reviewed-by: darcy, ohair ! make/Makefile ! make/build.properties ! make/build.xml
hg: jdk7/tl/jaxws: 6827026: Change javac source and target default to 7
Changeset: 605e1cdeba48 Author:jjg Date: 2009-05-20 13:50 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/605e1cdeba48 6827026: Change javac source and target default to 7 Reviewed-by: darcy, ohair ! make/Makefile ! make/build.properties ! make/build.xml
hg: jdk7/tl/jdk: 6827026: Change javac source and target default to 7
Changeset: 1bc5be8665cc Author:jjg Date: 2009-05-20 13:55 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1bc5be8665cc 6827026: Change javac source and target default to 7 Reviewed-by: darcy, ohair ! make/common/shared/Defs-control.gmk ! make/common/shared/Defs-java.gmk ! make/javax/swing/beaninfo/SwingBeans.gmk
hg: jdk7/tl: 6827026: Change javac source and target default to 7
Changeset: 54d14906940b Author:jjg Date: 2009-05-20 14:02 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/54d14906940b 6827026: Change javac source and target default to 7 Reviewed-by: darcy, ohair ! make/Defs-internal.gmk
hg: jdk7/tl/langtools: 6843648: tools/javac/versions/check.sh is broken
Changeset: 44eaac2b4501 Author:jjg Date: 2009-05-20 19:10 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/44eaac2b4501 6843648: tools/javac/versions/check.sh is broken Reviewed-by: darcy ! test/tools/javac/6341866/Anno.java ! test/tools/javac/6464451/BigFinally.java ! test/tools/javac/6464451/DeepNestedFinally.java ! test/tools/javac/6464451/ManyExitsInTry.java ! test/tools/javac/ClassLit.java ! test/tools/javac/T6557865.java ! test/tools/javac/foreach/T6682380.java ! test/tools/javac/processing/6348499/A.java ! test/tools/javac/processing/6414633/A.java ! test/tools/javac/processing/6430209/b6341534.java ! test/tools/javac/processing/T6439826.java ! test/tools/javac/stackmap/T4955930.sh ! test/tools/javac/versions/check.sh
hg: jdk7/tl/langtools: 6802102: unignore @ignored tests where possible
Changeset: d4828eba4939 Author:jjg Date: 2009-05-28 09:49 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d4828eba4939 6802102: unignore @ignored tests where possible Reviewed-by: mcimadamore ! test/tools/javac/T6405099.java ! test/tools/javac/api/6431257/T6431257.java ! test/tools/javac/api/TestJavacTaskScanner.java ! test/tools/javac/code/ArrayClone.java - test/tools/javac/code/ArrayClone.sh ! test/tools/javac/generics/inference/6365166/NewTest.java
hg: jdk7/tl/jdk: 6838199: remove support for old javap
Changeset: aece9096d5cd Author:jjg Date: 2009-05-29 16:27 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/aece9096d5cd 6838199: remove support for old javap Reviewed-by: ohair, mcimadamore ! make/common/Release.gmk ! make/common/internal/Defs-langtools.gmk ! make/launchers/Makefile
hg: jdk7/tl/langtools: 6838199: remove support for old javap
Changeset: 47cf04bb80c9 Author:jjg Date: 2009-05-29 16:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/47cf04bb80c9 6838199: remove support for old javap Reviewed-by: ohair, mcimadamore ! make/build.xml ! src/share/classes/com/sun/tools/javap/JavapTask.java ! src/share/classes/com/sun/tools/javap/Main.java ! src/share/classes/com/sun/tools/javap/resources/javap.properties - src/share/classes/sun/tools/javap/AttrData.java - src/share/classes/sun/tools/javap/CPX.java - src/share/classes/sun/tools/javap/CPX2.java - src/share/classes/sun/tools/javap/ClassData.java - src/share/classes/sun/tools/javap/Constants.java - src/share/classes/sun/tools/javap/FieldData.java - src/share/classes/sun/tools/javap/InnerClassData.java - src/share/classes/sun/tools/javap/JavapEnvironment.java - src/share/classes/sun/tools/javap/JavapPrinter.java - src/share/classes/sun/tools/javap/LineNumData.java - src/share/classes/sun/tools/javap/LocVarData.java - src/share/classes/sun/tools/javap/Main.java - src/share/classes/sun/tools/javap/MethodData.java - src/share/classes/sun/tools/javap/RuntimeConstants.java - src/share/classes/sun/tools/javap/StackMapData.java - src/share/classes/sun/tools/javap/StackMapTableData.java - src/share/classes/sun/tools/javap/Tables.java - src/share/classes/sun/tools/javap/TrapData.java - src/share/classes/sun/tools/javap/TypeSignature.java ! test/tools/javap/ExtPath.java - test/tools/javap/ListTest.java - test/tools/javap/OptionTest.java
hg: jdk7/tl/langtools: 6852856: javap changes to facilitate subclassing javap for variants
Changeset: ed989c347b3c Author:jjg Date: 2009-06-19 11:40 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ed989c347b3c 6852856: javap changes to facilitate subclassing javap for variants Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/classfile/AccessFlags.java ! src/share/classes/com/sun/tools/classfile/ConstantPool.java ! src/share/classes/com/sun/tools/javap/AttributeWriter.java ! src/share/classes/com/sun/tools/javap/ClassWriter.java ! src/share/classes/com/sun/tools/javap/ConstantWriter.java ! src/share/classes/com/sun/tools/javap/JavapTask.java ! src/share/classes/com/sun/tools/javap/SourceWriter.java
hg: jdk7/tl/jdk: 6843077: JSR 308: Annotations on types
Changeset: a5f7d97c3f82 Author:jjg Date: 2009-06-26 18:39 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a5f7d97c3f82 6843077: JSR 308: Annotations on types Reviewed-by: jjg, mcimadamore, darcy Contributed-by: mer...@cs.washington.edu, m...@csail.mit.edu, mp...@csail.mit.edu ! src/share/classes/java/lang/annotation/ElementType.java
hg: jdk7/tl/langtools: 6843077: JSR 308: Annotations on types
Changeset: 03944ee4fac4 Author:jjg Date: 2009-06-26 18:51 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/03944ee4fac4 6843077: JSR 308: Annotations on types Reviewed-by: jjg, mcimadamore, darcy Contributed-by: mer...@cs.washington.edu, m...@csail.mit.edu, mp...@csail.mit.edu ! src/share/bin/launcher.sh-template ! src/share/classes/com/sun/source/tree/MethodTree.java ! src/share/classes/com/sun/source/tree/Tree.java ! src/share/classes/com/sun/source/tree/TreeVisitor.java ! src/share/classes/com/sun/source/tree/TypeParameterTree.java ! src/share/classes/com/sun/source/util/SimpleTreeVisitor.java ! src/share/classes/com/sun/source/util/TreePath.java ! src/share/classes/com/sun/source/util/TreeScanner.java ! src/share/classes/com/sun/source/util/Trees.java ! src/share/classes/com/sun/tools/classfile/Attribute.java ! src/share/classes/com/sun/tools/classfile/ClassWriter.java ! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/processing/JavacRoundEnvironment.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java ! src/share/classes/com/sun/tools/javac/tree/TreeTranslator.java ! src/share/classes/com/sun/tools/javac/util/Names.java ! src/share/classes/com/sun/tools/javap/AnnotationWriter.java ! src/share/classes/com/sun/tools/javap/AttributeWriter.java ! test/tools/javac/6341866/T6341866.java ! test/tools/javac/processing/6348499/T6348499.java ! test/tools/javac/processing/6414633/T6414633.java ! test/tools/javac/processing/6430209/T6430209.java ! test/tools/javac/processing/T6439826.java
hg: jdk7/tl/langtools: 6855544: add missing files
Changeset: 664edca41e34 Author:jjg Date: 2009-06-26 19:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/664edca41e34 6855544: add missing files Reviewed-by: jjg, mcimadamore, darcy Contributed-by: mer...@cs.washington.edu, m...@csail.mit.edu, mp...@csail.mit.edu + src/share/classes/com/sun/source/tree/AnnotatedTypeTree.java + src/share/classes/com/sun/source/util/AbstractTypeProcessor.java + src/share/classes/com/sun/tools/classfile/ExtendedAnnotation.java + src/share/classes/com/sun/tools/classfile/RuntimeInvisibleTypeAnnotations_attribute.java + src/share/classes/com/sun/tools/classfile/RuntimeTypeAnnotations_attribute.java + src/share/classes/com/sun/tools/classfile/RuntimeVisibleTypeAnnotations_attribute.java + src/share/classes/com/sun/tools/javac/code/TargetType.java + src/share/classes/com/sun/tools/javac/code/TypeAnnotationPosition.java + test/tools/javac/api/TestTreePath.java + test/tools/javac/meth/InvokeMH_BAD68.java + test/tools/javac/meth/InvokeMH_BAD72.java + test/tools/javac/quid/QuotedIdent_BAD61.java + test/tools/javac/quid/QuotedIdent_BAD62.java + test/tools/javac/quid/QuotedIdent_BAD63.java + test/tools/javac/typeAnnotations/InnerClass.java + test/tools/javac/typeAnnotations/MultipleTargets.java + test/tools/javac/typeAnnotations/TypeParameterTarget.java + test/tools/javac/typeAnnotations/TypeUseTarget.java + test/tools/javac/typeAnnotations/attribution/Scopes.java + test/tools/javac/typeAnnotations/failures/AnnotationVersion.java + test/tools/javac/typeAnnotations/failures/AnnotationVersion.out + test/tools/javac/typeAnnotations/failures/IncompleteArray.java + test/tools/javac/typeAnnotations/failures/IncompleteArray.out + test/tools/javac/typeAnnotations/failures/IncompleteVararg.java + test/tools/javac/typeAnnotations/failures/IncompleteVararg.out + test/tools/javac/typeAnnotations/failures/IndexArray.java + test/tools/javac/typeAnnotations/failures/IndexArray.out + test/tools/javac/typeAnnotations/failures/LintCast.java + test/tools/javac/typeAnnotations/failures/LintCast.out + test/tools/javac/typeAnnotations/failures/OldArray.java + test/tools/javac/typeAnnotations/failures/OldArray.out + test/tools/javac/typeAnnotations/failures/Scopes.java + test/tools/javac/typeAnnotations/failures/Scopes.out + test/tools/javac/typeAnnotations/failures/StaticFields.java + test/tools/javac/typeAnnotations/failures/StaticFields.out + test/tools/javac/typeAnnotations/failures/StaticMethods.java + test/tools/javac/typeAnnotations/failures/StaticMethods.out + test/tools/javac/typeAnnotations/failures/VoidGenericMethod.java + test/tools/javac/typeAnnotations/failures/common/arrayclass/DuplicateAnnotationValue.java + test/tools/javac/typeAnnotations/failures/common/arrayclass/DuplicateAnnotationValue.out + test/tools/javac/typeAnnotations/failures/common/arrayclass/DuplicateTypeAnnotation.java + test/tools/javac/typeAnnotations/failures/common/arrayclass/DuplicateTypeAnnotation.out + test/tools/javac/typeAnnotations/failures/common/arrayclass/InvalidLocation.java + test/tools/javac/typeAnnotations/failures/common/arrayclass/InvalidLocation.out + test/tools/javac/typeAnnotations/failures/common/arrayclass/MissingAnnotationValue.java + test/tools/javac/typeAnnotations/failures/common/arrayclass/MissingAnnotationValue.out + test/tools/javac/typeAnnotations/failures/common/arrays/DuplicateAnnotationValue.java + test/tools/javac/typeAnnotations/failures/common/arrays/DuplicateAnnotationValue.out + test/tools/javac/typeAnnotations/failures/common/arrays/DuplicateTypeAnnotation.java + test/tools/javac/typeAnnotations/failures/common/arrays/DuplicateTypeAnnotation.out + test/tools/javac/typeAnnotations/failures/common/arrays/InvalidLocation.java + test/tools/javac/typeAnnotations/failures/common/arrays/InvalidLocation.out + test/tools/javac/typeAnnotations/failures/common/arrays/MissingAnnotationValue.java + test/tools/javac/typeAnnotations/failures/common/arrays/MissingAnnotationValue.out + test/tools/javac/typeAnnotations/failures/common/innertypeparams/DuplicateAnnotationValue.java + test/tools/javac/typeAnnotations/failures/common/innertypeparams/DuplicateAnnotationValue.out + test/tools/javac/typeAnnotations/failures/common/innertypeparams/DuplicateTypeAnnotation.java + test/tools/javac/typeAnnotations/failures/common/innertypeparams/DuplicateTypeAnnotation.out + test/tools/javac/typeAnnotations/failures/common/innertypeparams/InvalidLocation.java + test/tools/javac/typeAnnotations/failures/common/innertypeparams/InvalidLocation.out + test/tools/javac/typeAnnotations/failures/common/innertypeparams/MissingAnnotationValue.java + test/tools/javac/typeAnnotations/failures/common/innertypeparams/MissingAnnotationValue.out + test/tools/javac/typeAnnotations/failures/common/newarray/DuplicateAnnotationValue.java + test/tools/javac/typeAnnotations/failures/common/newarray/DuplicateAnnotationValue.out + test/tools/javac/typeAnnotations/failures/common/ne
hg: jdk7/tl/langtools: 6854796: update JSR308 impl with latest code from type-annotations repo
Changeset: 7c154fdc3547 Author:jjg Date: 2009-06-26 19:47 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/7c154fdc3547 6854796: update JSR308 impl with latest code from type-annotations repo Reviewed-by: jjg, mcimadamore, darcy Contributed-by: mer...@cs.washington.edu, m...@csail.mit.edu, mp...@csail.mit.edu ! src/share/classes/com/sun/tools/javac/code/TargetType.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotationPosition.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/processing/JavacRoundEnvironment.java
hg: jdk7/tl/langtools: 6855563: test broken after merge with latest parser
Changeset: 464d58654324 Author:jjg Date: 2009-06-27 12:04 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/464d58654324 6855563: test broken after merge with latest parser Reviewed-by: jjg Contributed-by: m...@csail.mit.edu ! test/tools/javac/typeAnnotations/failures/OldArray.java - test/tools/javac/typeAnnotations/failures/OldArray.out
hg: jdk7/tl/jdk: 6855069: rmic should support v51 class files.
Changeset: d926534a1c17 Author:jjg Date: 2009-06-29 16:28 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d926534a1c17 6855069: rmic should support v51 class files. Reviewed-by: jrose ! src/share/classes/sun/tools/java/RuntimeConstants.java
hg: jdk7/tl/langtools: 6855993: fix comments in langtools launcher script
Changeset: 7913e72a24b0 Author:jjg Date: 2009-06-29 17:45 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/7913e72a24b0 6855993: fix comments in langtools launcher script Reviewed-by: ohair ! src/share/bin/launcher.sh-template
hg: jdk7/tl/langtools: 6863814: javap crashes when facing array class literals
Changeset: 99b7a25185aa Author:jjg Date: 2009-07-23 11:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/99b7a25185aa 6863814: javap crashes when facing array class literals Reviewed-by: jjg Contributed-by: m...@csail.mit.edu ! src/share/classes/com/sun/tools/classfile/ExtendedAnnotation.java + test/tools/javap/typeAnnotations/ArrayClassLiterals.java
hg: jdk7/tl/langtools: 6863914: bug number missing from test
Changeset: 49387c1440d0 Author:jjg Date: 2009-07-23 14:15 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/49387c1440d0 6863914: bug number missing from test Reviewed-by: tbell ! test/tools/javap/typeAnnotations/ArrayClassLiterals.java
hg: jdk7/tl/langtools: 6863746: javap should not scan ct.sym by default
Changeset: 631425840408 Author:jjg Date: 2009-07-24 14:47 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/631425840408 6863746: javap should not scan ct.sym by default Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javap/JavapFileManager.java ! src/share/classes/com/sun/tools/javap/JavapTask.java ! src/share/classes/com/sun/tools/javap/Options.java + test/tools/javap/T6863746.java
hg: jdk7/tl: 6854244: change source/target used to compile JDK to 7
Changeset: 59c202ab8a94 Author:jjg Date: 2009-07-27 15:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/59c202ab8a94 6854244: change source/target used to compile JDK to 7 Reviewed-by: ohair ! make/README.pre-components
hg: jdk7/tl/langtools: 6854244: change source/target used to compile JDK to 7
Changeset: cf08b64e87da Author:jjg Date: 2009-07-27 15:20 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/cf08b64e87da 6854244: change source/target used to compile JDK to 7 Reviewed-by: ohair ! make/build.properties
hg: jdk7/tl/corba: 6854244: change source/target used to compile JDK to 7
Changeset: 2a160e4e0d06 Author:jjg Date: 2009-07-27 15:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/2a160e4e0d06 6854244: change source/target used to compile JDK to 7 Reviewed-by: ohair ! make/Makefile ! make/common/shared/Defs-java.gmk
hg: jdk7/tl/jdk: 6854244: change source/target used to compile JDK to 7
Changeset: 15878be84b9d Author:jjg Date: 2009-07-27 15:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/15878be84b9d 6854244: change source/target used to compile JDK to 7 Reviewed-by: ohair ! make/common/shared/Defs-control.gmk ! make/common/shared/Defs-java.gmk ! make/java/dyn/Makefile
hg: jdk7/tl/jaxws: 6854244: change source/target used to compile JDK to 7
Changeset: c5dfd37d18a0 Author:jjg Date: 2009-07-27 15:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/c5dfd37d18a0 6854244: change source/target used to compile JDK to 7 Reviewed-by: ohair ! make/build.properties
hg: jdk7/tl/jaxp: 6854244: change source/target used to compile JDK to 7
Changeset: 59cdcbf2c10d Author:jjg Date: 2009-07-27 15:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/59cdcbf2c10d 6854244: change source/target used to compile JDK to 7 Reviewed-by: ohair ! make/build.properties
hg: jdk7/tl/langtools: 6865399: some javac files are missing Sun internal API comment
Changeset: 7c2d6da61646 Author:jjg Date: 2009-07-27 19:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/7c2d6da61646 6865399: some javac files are missing Sun internal API comment Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/api/DiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/api/Formattable.java ! src/share/classes/com/sun/tools/javac/api/Messages.java ! src/share/classes/com/sun/tools/javac/code/BoundKind.java ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/file/BaseFileObject.java ! src/share/classes/com/sun/tools/javac/file/CacheFSInfo.java ! src/share/classes/com/sun/tools/javac/file/FSInfo.java ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/share/classes/com/sun/tools/javac/file/RegularFileObject.java ! src/share/classes/com/sun/tools/javac/file/RelativePath.java ! src/share/classes/com/sun/tools/javac/file/SymbolArchive.java ! src/share/classes/com/sun/tools/javac/file/ZipArchive.java ! src/share/classes/com/sun/tools/javac/file/ZipFileIndex.java ! src/share/classes/com/sun/tools/javac/file/ZipFileIndexArchive.java ! src/share/classes/com/sun/tools/javac/parser/ParserFactory.java ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/BasicDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/ForwardingDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/RawDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/Warner.java
hg: jdk7/tl/langtools: 6855990: javap InstructionDetailWriter should support new 308 annotations attribute
Changeset: 777a3efad0d5 Author:jjg Date: 2009-07-28 10:36 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/777a3efad0d5 6855990: javap InstructionDetailWriter should support new 308 annotations attribute Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/classfile/ExtendedAnnotation.java ! src/share/classes/com/sun/tools/javap/AnnotationWriter.java ! src/share/classes/com/sun/tools/javap/CodeWriter.java ! src/share/classes/com/sun/tools/javap/InstructionDetailWriter.java + src/share/classes/com/sun/tools/javap/TypeAnnotationWriter.java + test/tools/javap/typeAnnotations/T6855990.java
hg: jdk7/tl/langtools: 6734068: Some variable length attributes set their size incorrectly.
Changeset: 85b317ac8a0c Author:jjg Date: 2009-07-28 11:00 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/85b317ac8a0c 6734068: Some variable length attributes set their size incorrectly. Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/classfile/CharacterRangeTable_attribute.java ! src/share/classes/com/sun/tools/classfile/LineNumberTable_attribute.java ! src/share/classes/com/sun/tools/classfile/LocalVariableTable_attribute.java ! src/share/classes/com/sun/tools/classfile/LocalVariableTypeTable_attribute.java ! src/share/classes/com/sun/tools/classfile/ModuleExportTable_attribute.java ! src/share/classes/com/sun/tools/classfile/ModuleMemberTable_attribute.java
hg: jdk7/tl/langtools: 4777949: Javap Rewrite : Warn javap usage on package classes with simple name.
Changeset: c2dfab9e2f39 Author:jjg Date: 2009-07-29 13:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/c2dfab9e2f39 4777949: Javap Rewrite : Warn javap usage on package classes with simple name. Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javap/JavapFileManager.java ! src/share/classes/com/sun/tools/javap/JavapTask.java ! src/share/classes/com/sun/tools/javap/resources/javap.properties + test/tools/javap/T4777949.java
hg: jdk7/tl/langtools: 6866657: add byteLength method to primary classfile types
Changeset: 23505e6ea22d Author:jjg Date: 2009-07-30 07:48 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/23505e6ea22d 6866657: add byteLength method to primary classfile types Reviewed-by: mchung ! src/share/classes/com/sun/tools/classfile/AccessFlags.java ! src/share/classes/com/sun/tools/classfile/Attribute.java ! src/share/classes/com/sun/tools/classfile/Attributes.java ! src/share/classes/com/sun/tools/classfile/ClassFile.java ! src/share/classes/com/sun/tools/classfile/ConstantPool.java ! src/share/classes/com/sun/tools/classfile/Field.java ! src/share/classes/com/sun/tools/classfile/Method.java + test/tools/javap/T6866657.java
hg: jdk7/tl/langtools: 4880672: javap does not output inner interfaces of an interface
Changeset: e33efb09ed75 Author:jjg Date: 2009-07-30 09:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e33efb09ed75 4880672: javap does not output inner interfaces of an interface Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javap/JavapTask.java ! src/share/classes/com/sun/tools/javap/Options.java ! src/share/classes/com/sun/tools/javap/resources/javap.properties + test/tools/javap/T4880672.java
hg: jdk7/tl/langtools: 6867671: javap whitespace formatting issues
Changeset: 743f17b55b44 Author:jjg Date: 2009-08-04 17:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/743f17b55b44 6867671: javap whitespace formatting issues Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javap/AttributeWriter.java ! src/share/classes/com/sun/tools/javap/BasicWriter.java ! src/share/classes/com/sun/tools/javap/ClassWriter.java ! src/share/classes/com/sun/tools/javap/CodeWriter.java ! src/share/classes/com/sun/tools/javap/ConstantWriter.java ! src/share/classes/com/sun/tools/javap/JavapTask.java ! src/share/classes/com/sun/tools/javap/Options.java
hg: jdk7/tl/langtools: 6868553: 6867671 breaks some tests
Changeset: bc0b1f404c40 Author:jjg Date: 2009-08-05 07:43 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/bc0b1f404c40 6868553: 6867671 breaks some tests Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javap/AttributeWriter.java ! test/tools/javac/code/ArrayClone.java ! test/tools/javap/4111861/T4111861.java ! test/tools/javap/T4884240.java ! test/tools/javap/T4975569.java ! test/tools/javap/stackmap/T6271292.sh
