Re: Verify AES support when Blumenthal draft is enabled

2018-04-28 Thread Keith Mendoza


On Fri, Apr 27, 2018, at 11:00 PM, Keith Mendoza wrote:
> > 
> > Regardless, configure should be doing the right thing based on what
> > is currently installed.
> > 
> > BVA> Regarding your pull request:
> > BVA> I'd like to avoid adding AC_CHECK_HEADERS() calls in
> > BVA> config_project_with_enable because whether or not these
> > BVA> succeed depend on the compiler flags (-I) and some compiler
> > BVA> flags are only set at a later phase.
> > 
> > I agree that header checks inside a feature check is undesirable.
> > Keith, do you think you could come up with a patch that re-arranges
> > configure checks that that the desired effect is achieved?
> 
> Let me give this another go. I think the best solution is when --with-
> openssl is processed that a variable like "blumenthalcapable" be set 
> based on whether the AES-related functions and headers are available. 
> This will also open it up to other configuration checks that may need 
> the same things.

https://sourceforge.net/p/net-snmp/code/merge-requests/14/ has my proposed 
changes.

> 
> > 
> > Robert
> 
> 
> -- 
> Thanks,
> Keith (pantherse)


-- 
Thanks,
Keith (pantherse)

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders


Re: Verify AES support when Blumenthal draft is enabled

2018-04-28 Thread Keith Mendoza


On Fri, Apr 27, 2018, at 2:40 PM, Robert Story wrote:
> On Wed, 25 Apr 2018 10:28:59 -0600 Bart wrote:
> BVA> On 04/25/18 10:04, Keith Mendoza wrote:
> BVA> > I have submitted a merge request to verify that when the
> BVA> > --enable-blumenthal-aes is used in configure that it checks
> BVA> > that OpenSSL's aes.h and evp.h are available. Merge request
> BVA> > is at
> BVA> > https://sourceforge.net/p/net-snmp/code/merge-requests/14/.
> BVA> > [...]
> BVA> 
> BVA> Hello Keith,
> BVA> 
> BVA> Are you aware that running something like "brew upgrade
> BVA> openssl" brings in a version of openssl on OS/X that is recent
> BVA> enough for all Net-SNMP features?
> 
> Regardless, configure should be doing the right thing based on what
> is currently installed.
> 
> BVA> Regarding your pull request:
> BVA> I'd like to avoid adding AC_CHECK_HEADERS() calls in
> BVA> config_project_with_enable because whether or not these
> BVA> succeed depend on the compiler flags (-I) and some compiler
> BVA> flags are only set at a later phase.
> 
> I agree that header checks inside a feature check is undesirable.
> Keith, do you think you could come up with a patch that re-arranges
> configure checks that that the desired effect is achieved?

Let me give this another go. I think the best solution is when --with-openssl 
is processed that a variable like "blumenthalcapable" be set based on whether 
the AES-related functions and headers are available. This will also open it up 
to other configuration checks that may need the same things.

> 
> Robert


-- 
Thanks,
Keith (pantherse)

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders