Re: [PATCH 00/15] Clean up Net-SNMP public header files

[Wes Hardaker via Net-snmp-coders]

Robert Story  writes:

> Unfortunately I don't really see any backwards compatibility fixes
> here. It all looks like cleanup, which doesn't meet the criteria
> for patches at this point in the release process. The Cygwin build
> fix is a possible exception, so I'll +1 that one. One more vote
> from the core team and it will go in.

I agree with Robert on this account.  Lots of good potential fixes, but
they should go into future 5.9 at this point not the immediate 5.8.  I'd
+1 the cgywin build fix too.
-- 
Wes Hardaker
Please mail all replies to net-snmp-coders@lists.sourceforge.net

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders

Re: [PATCH 00/15] Clean up Net-SNMP public header files

[Robert Story]

On Sun, 13 May 2018 14:31:38 -0700 Bart wrote:
BVA> Since Net-SNMP version 5.8 will be released soon and since no
BVA> prior version has been released from the v5.8 (master) branch
BVA> yet this is a good time to review the public header files and
BVA> verify whether any potentially backwards incompatible changes
BVA> should be made.

Unfortunately I don't really see any backwards compatibility fixes
here. It all looks like cleanup, which doesn't meet the criteria
for patches at this point in the release process. The Cygwin build
fix is a possible exception, so I'll +1 that one. One more vote
from the core team and it will go in.

Robert

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders

[PATCH 00/15] Clean up Net-SNMP public header files

[Bart Van Assche]

Hello,

Since Net-SNMP version 5.8 will be released soon and since no prior version
has been released from the v5.8 (master) branch yet this is a good time to
review the public header files and verify whether any potentially backwards
incompatible changes should be made. The patches in this series are what I
came up with myself. As usual, feedback is welcome.

Bart.

Bart Van Assche (15):
  Cygwin64: Fix winExtDLL build
  : Add a missing #include directive
  : Add missing #include directives
  : Add a missing forward declaration
  : Add a missing #include directive
  win32/config.h.borland: Remove this header file
  include/net-snmp/system/*: Remove unused preprocessor symbols
  Darwin: Move SNMP_CFRelease() definition
  libsnmp: Fix the recursive dependency between  and

  libsnmp: Remove ONE_SEC definition
  libsnmp: Define MAX_OID_LEN once instead of three times
  : Remove this header file
  : Remove this header file
  : Stop including from 
  : Reduce the number of #include directives further

 agent/Makefile.depend   |  84 ---
 agent/helpers/Makefile.depend   |  54 --
 agent/mibgroup/Makefile.depend  | 334 --
 agent/mibgroup/agentx/agentx_config.c   |   2 +-
 agent/mibgroup/agentx/client.c  |   6 +-
 agent/mibgroup/host/data_access/swinst_darwin.c |   3 +
 apps/Makefile.depend|  62 --
 apps/snmpnetstat/Makefile.depend|  16 -
 include/net-snmp/agent/snmp_agent.h |   1 +
 include/net-snmp/definitions.h  |  32 -
 include/net-snmp/library/asn1.h |   2 -
 include/net-snmp/library/libsnmp.h  | 174 --
 include/net-snmp/library/oid.h  |  11 +
 include/net-snmp/library/snmp_api.h |  18 +-
 include/net-snmp/library/snmp_transport.h   |   2 +
 include/net-snmp/library/tools.h|   5 +-
 include/net-snmp/library/types.h|  70 ---
 include/net-snmp/net-snmp-includes.h|   7 +-
 include/net-snmp/session_api.h  |   1 +
 include/net-snmp/system/aix.h   |   2 +-
 include/net-snmp/system/cygwin.h|   4 -
 include/net-snmp/system/darwin10.h  |   7 -
 include/net-snmp/system/darwin11.h  |   7 -
 include/net-snmp/system/darwin12.h  |   7 -
 include/net-snmp/system/darwin13.h  |   7 -
 include/net-snmp/system/darwin14.h  |   7 -
 include/net-snmp/system/darwin7.h   |   3 -
 include/net-snmp/system/darwin9.h   |   7 -
 include/net-snmp/system/dragonfly.h |   4 -
 include/net-snmp/system/dynix.h |   3 -
 include/net-snmp/system/freebsd.h   |   3 -
 include/net-snmp/system/freebsd2.h  |   1 -
 include/net-snmp/system/freebsd3.h  |   2 -
 include/net-snmp/system/freebsd4.h  |   4 -
 include/net-snmp/system/generic.h   |  14 -
 include/net-snmp/system/hpux.h  |  10 -
 include/net-snmp/system/linux.h |   2 -
 include/net-snmp/system/mingw32.h   |   3 -
 include/net-snmp/system/mips.h  |   2 -
 include/net-snmp/system/netbsd.h|   5 -
 include/net-snmp/system/nto-qnx6.h  |   3 -
 include/net-snmp/system/openbsd.h   |   1 -
 include/net-snmp/system/openbsd5.h  |   2 -
 include/net-snmp/system/solaris.h   |   3 -
 include/net-snmp/types.h|  76 ++-
 include/net-snmp/varbind_api.h  |   1 +
 snmplib/Makefile.depend | 150 -
 snmplib/Makefile.in |   1 -
 snmplib/cert_util.c |   1 +
 snmplib/snmp-tc.c   |   1 +
 snmplib/snmp.c  |   1 +
 snmplib/snmp_api.c  |   4 +-
 snmplib/snmp_client.c   |   3 +
 snmplib/transports/snmpAAL5PVCDomain.c  |   1 +
 snmplib/transports/snmpDTLSUDPDomain.c  |   1 +
 snmplib/transports/snmpIPv4BaseDomain.c |   1 +
 snmplib/transports/snmpIPv6BaseDomain.c |   1 +
 snmplib/transports/snmpSSHDomain.c  |   1 +
 snmplib/transports/snmpSTDDomain.c  |   2 +-
 snmplib/transports/snmpTCPDomain.c  |   1 +
 snmplib/transports/snmpTCPIPv6Domain.c  |   1 +
 snmplib/transports/snmpTLSBaseDomain.c  |   2 +
 snmplib/transports/snmpTLSTCPDomain.c   |   1 +
 snmplib/transports/snmpUDPDomain.c  |   1 +
 snmplib/transports/snmpUDPIPv6Domain.c  |   1 +
 snmplib/transports/snmpUnixDomain.c |   2 +
 snmplib/vacm.c  |   2 +
 win32/config.h.borland  | 772 
 win32/dist/installer/net-snmp.nsi