CFV: SA_REPEAT timers broken in 5.6.rc1 (Patch 3058451)
Patch 3058451
(https://sourceforge.net/tracker/?func=detailatid=312694aid=3058451group_id=12694)
says:
Revision 19323 broke SA_REPEAT timers by incorrectly removing all flags instead
of just SA_FIRED.
http://net-snmp.svn.sourceforge.net/viewvc/net-snmp/trunk/net-snmp/snmplib/snmp_alarm.c?r1=18212r2=19323
Line 254 is a-flags = !SA_FIRED;
Patch is attached.
Apply to trunk?
+Thomas
diff -ur net-snmp-5.6.rc1/snmplib/snmp_alarm.c net-snmp-5.6.rc1-patched/snmplib/snmp_alarm.c
--- net-snmp-5.6.rc1/snmplib/snmp_alarm.c 2010-09-02 15:28:17.0 -0700
+++ net-snmp-5.6.rc1-patched/snmplib/snmp_alarm.c 2010-09-02 15:28:40.0 -0700
@@ -251,7 +251,7 @@
a-t_last.tv_usec = t_now.tv_usec;
a-t_next.tv_sec = 0;
a-t_next.tv_usec = 0;
-a-flags = !SA_FIRED;
+a-flags = ~SA_FIRED;
sa_update_entry(a);
} else {
DEBUGMSGTL((snmp_alarm, alarm %d deleted itself\n,
--
This SF.net Dev2Dev email is sponsored by:
Show off your parallel programming skills.
Enter the Intel(R) Threading Challenge 2010.
http://p.sf.net/sfu/intel-thread-sfd___
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Re: CFV: SA_REPEAT timers broken in 5.6.rc1 (Patch 3058451)
On Fri, Sep 3, 2010 at 10:13 AM, Thomas Anders thomas.and...@blue-cable.dewrote: Patch 3058451 ( https://sourceforge.net/tracker/?func=detailatid=312694aid=3058451group_id=12694) says: Revision 19323 broke SA_REPEAT timers by incorrectly removing all flags instead of just SA_FIRED. http://net-snmp.svn.sourceforge.net/viewvc/net-snmp/trunk/net-snmp/snmplib/snmp_alarm.c?r1=18212r2=19323 Line 254 is a-flags = !SA_FIRED; Patch is attached. Apply to trunk? +1 -- This SF.net Dev2Dev email is sponsored by: Show off your parallel programming skills. Enter the Intel(R) Threading Challenge 2010. http://p.sf.net/sfu/intel-thread-sfd___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Re: CFV: SA_REPEAT timers broken in 5.6.rc1 (Patch 3058451)
On Fri, 03 Sep 2010 10:13:06 +0200, Thomas Anders thomas.and...@blue-cable.de said: TA Patch is attached. +1 -- Wes Hardaker Please mail all replies to net-snmp-coders@lists.sourceforge.net -- This SF.net Dev2Dev email is sponsored by: Show off your parallel programming skills. Enter the Intel(R) Threading Challenge 2010. http://p.sf.net/sfu/intel-thread-sfd ___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Re: CFV: SA_REPEAT timers broken in 5.6.rc1 (Patch 3058451)
On Fri, 03 Sep 2010 10:13:06 +0200 Thomas wrote: TA Patch 3058451 (https://sourceforge.net/tracker/?func=detailatid=312694aid=3058451group_id=12694) says: TA TA Revision 19323 broke SA_REPEAT timers by incorrectly removing all flags instead of just SA_FIRED. TA TA http://net-snmp.svn.sourceforge.net/viewvc/net-snmp/trunk/net-snmp/snmplib/snmp_alarm.c?r1=18212r2=19323 TA Line 254 is a-flags = !SA_FIRED; TA TA Patch is attached. TA TA Apply to trunk? +1 -- This SF.net Dev2Dev email is sponsored by: Show off your parallel programming skills. Enter the Intel(R) Threading Challenge 2010. http://p.sf.net/sfu/intel-thread-sfd ___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Re: CFV: SA_REPEAT timers broken in 5.6.rc1 (Patch 3058451)
On Fri, 03 Sep 2010 10:13:06 +0200, Thomas Anders thomas.and...@blue-cable.de said: TA Revision 19323 broke SA_REPEAT timers by incorrectly removing all TA flags instead of just SA_FIRED. Thanks Thomas. Applied! (err... ing. It'll be ed in a second) -- Wes Hardaker Please mail all replies to net-snmp-coders@lists.sourceforge.net -- This SF.net Dev2Dev email is sponsored by: Show off your parallel programming skills. Enter the Intel(R) Threading Challenge 2010. http://p.sf.net/sfu/intel-thread-sfd ___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
