Re: Fwd: SF.net SVN: net-snmp:[19116]
On Wed, Jun 30, 2010 at 12:30 AM, Thomas Anders thomas.and...@blue-cable.de wrote: Bart Van Assche wrote: On Tue, Jun 29, 2010 at 6:28 PM, Thomas Anders thomas.and...@blue-cable.de mailto:thomas.and...@blue-cable.de wrote: Where exactly do you propose to add #include net-snmp/agent/agent_module_config.h? The safest place to add that include statement IMHO is inside the source files apps/snmptrapd.c and apps/snmptrapd_auth.c. See r19134 for my proposed fix. Please note that apps/snmptrapd.c already includes net-snmp/agent/net-snmp-agent-includes.h which includes net-snmp/agent/agent_module_config.h, so we're safe there. Thanks ! That fixed it at least on the trunk (haven't retested the branches yet). Bart. -- This SF.net email is sponsored by Sprint What will you do first with EVO, the first 4G phone? Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Re: Fwd: SF.net SVN: net-snmp:[19116]
Bart, This patch causes fourteen additional tests to fail on Cygwin. Sorry for that. trunk or branch? Where exactly do you propose to add #include net-snmp/agent/agent_module_config.h? +Thomas -- This SF.net email is sponsored by Sprint What will you do first with EVO, the first 4G phone? Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first ___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Re: Fwd: SF.net SVN: net-snmp:[19116]
On Tue, Jun 29, 2010 at 6:28 PM, Thomas Anders thomas.and...@blue-cable.dewrote: Bart, This patch causes fourteen additional tests to fail on Cygwin. Sorry for that. trunk or branch? Where exactly do you propose to add #include net-snmp/agent/agent_module_config.h? I observed this on the trunk, but the branches are probably also affected. The safest place to add that include statement IMHO is inside the source files apps/snmptrapd.c and apps/snmptrapd_auth.c. Bart. -- This SF.net email is sponsored by Sprint What will you do first with EVO, the first 4G phone? Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Re: Fwd: SF.net SVN: net-snmp:[19116]
On Tue, 2010-06-29 at 20:18 +0200, Bart Van Assche wrote: On Tue, Jun 29, 2010 at 6:28 PM, Thomas Anders thomas.and...@blue-cable.de wrote: Bart, This patch causes fourteen additional tests to fail on Cygwin. Sorry for that. trunk or branch? Where exactly do you propose to add #include net-snmp/agent/agent_module_config.h? I observed this on the trunk, but the branches are probably also affected. The safest place to add that include statement IMHO is inside the source files apps/snmptrapd.c and apps/snmptrapd_auth.c. +1 /MF -- This SF.net email is sponsored by Sprint What will you do first with EVO, the first 4G phone? Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first ___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Re: Fwd: SF.net SVN: net-snmp:[19116]
Bart Van Assche wrote: On Tue, Jun 29, 2010 at 6:28 PM, Thomas Anders thomas.and...@blue-cable.de mailto:thomas.and...@blue-cable.de wrote: Where exactly do you propose to add #include net-snmp/agent/agent_module_config.h? The safest place to add that include statement IMHO is inside the source files apps/snmptrapd.c and apps/snmptrapd_auth.c. See r19134 for my proposed fix. Please note that apps/snmptrapd.c already includes net-snmp/agent/net-snmp-agent-includes.h which includes net-snmp/agent/agent_module_config.h, so we're safe there. +Thomas -- This SF.net email is sponsored by Sprint What will you do first with EVO, the first 4G phone? Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first ___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
