Re: [PATCH] bcm43xx: Fix code for spec changes of 2/7/2007
On Fri, 2007-02-09 at 21:32 +, Matthew Garrett wrote: On Fri, Feb 09, 2007 at 01:26:25PM -0600, Larry Finger wrote: My plan is to continue to maintain bcm43xx-SoftMAC for at least the BPHY and 4306 revisions even after d80211 becomes the in-kernel driver. Of course, I hope that we will have found the killer bugs by that time, and that maintenance will only require following kernel API changes. Just to make sure I'm understanding this correctly - does the v4 firmware drop compatibility for older cards, or is it just that Broadcom dropped support in the driver at the same time as the firmware changed, and the new firmware will still also drive the old cards? No, the older cards have a completely different MAC processor and Broadcom hasn't bothered to create v4 firmware for it since they dropped support for it along with creating new drivers (probably one decision influenced the other, creating a v2 firmware is likely more work than a v3+) johannes signature.asc Description: This is a digitally signed message part
Re: [ANNOUNCE] d80211 based driver for Intel PRO/Wireless 3945ABG
On Sat, 2007-02-10 at 14:23 +0100, Hesse, Christian wrote: The driver generates two network devices. The second one is for promicious mode? Is there any chance to disable the interface? The second one is the so-called master interface which is used for QoS stuff. We're working on hiding it until a better solution for QoS evolves (which has been a plan for a while.) johannes signature.asc Description: This is a digitally signed message part
skge dysfunction on Amd X2 machine with 4GB memory
With the skge driver there seems to be some sort of problem to work in a system with memory above the 4 GB of PCI address space. System doesn't crash (not outright anyway) with skge, but that network interface just doesn't function. My box has also forcedeth network interface, which works just fine. Running kernel is: 2.6.20-1.2922.fc7 This system board had previously buggy bios that prevented the functioning with more than around 3GB memory at all. Now things do work, and Rev.E memory hoist kicks 1280 MB of memory above the 4 GB mark. Without the previously dysfunctioning 4GB memory or more the same kernel and drivers worked just fine. Indeed the skge was my eth0. Any ideas ? /Matti Aarnio - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[patch] bugfixes and new hardware support for arcnet driver
The modifications and bug fixes noted below were done by Realtime
Control Works and Contemporary Control Systems, Inc, Jan 2005. They
were incorporated into the 2.6 kernel by Jeff Morrow of Sierra
Analytics, Feb 2007. [EMAIL PROTECTED]
The changes have been tested on a Contemporary Controls PCI20U-4000.
Summary of changes:
Arc-rawmode.c:
rx():
- Fixed error in received packet lengths; 256 byte packets were
being received as 257 bytes packets.
prepare_tx():
- Fixed error in transmit length calcs; 257 byte packets were being
transmitted as 260 byte packets.
com20020.c:
com20020_check():
- We now load the SETUP2 register if the 'clockm' parameter is
non-zero, instead of checking for ARC_CAN_10MBIT. The user is
now responsible for whether or not SETUP2 is loaded. If the
clock multiplier is non-zero, this means that the user wants a
baud rate greater than 2.5Mbps. This is not possible unless the
SETUP2 register is present (COM20020D, or COM20022). So, we're
relying on the user to be smart about what kind of chip he's
dealing with...
com20020-pci.c
- Added several entries to com20020pci_id_table[].
Signed-off-by: Jeff Morrow [EMAIL PROTECTED]
---
diff -uprN -X linux-2.6.20/Documentation/dontdiff
linux-2.6.20/drivers/net/arcnet/arcnet.c
linux-2.6.20.changed/drivers/net/arcnet/arcnet.c
--- linux-2.6.20/drivers/net/arcnet/arcnet.c2007-02-04 10:44:54.0
-0800
+++ linux-2.6.20.changed/drivers/net/arcnet/arcnet.c2007-02-11
10:26:47.0 -0800
@@ -41,7 +41,7 @@
* [EMAIL PROTECTED]
*/
-#define VERSION arcnet: v3.93 BETA 2000/04/29 - by Avery Pennarun et al.\n
+#define VERSION arcnet: v3.94 BETA 2007/02/08 - by Avery Pennarun et al.\n
#include linux/module.h
#include linux/types.h
diff -uprN -X linux-2.6.20/Documentation/dontdiff
linux-2.6.20/drivers/net/arcnet/arc-rawmode.c
linux-2.6.20.changed/drivers/net/arcnet/arc-rawmode.c
--- linux-2.6.20/drivers/net/arcnet/arc-rawmode.c 2007-02-04
10:44:54.0 -0800
+++ linux-2.6.20.changed/drivers/net/arcnet/arc-rawmode.c 2007-02-11
10:24:38.0 -0800
@@ -94,7 +94,7 @@ static void rx(struct net_device *dev, i
BUGMSG(D_DURING, it's a raw packet (length=%d)\n, length);
- if (length = MinTU)
+ if (length MTU)
ofs = 512 - length;
else
ofs = 256 - length;
@@ -183,7 +183,7 @@ static int prepare_tx(struct net_device
length, XMTU);
length = XMTU;
}
- if (length MinTU) {
+ if (length = MinTU) {
hard-offset[0] = 0;
hard-offset[1] = ofs = 512 - length;
} else if (length MTU) {
diff -uprN -X linux-2.6.20/Documentation/dontdiff
linux-2.6.20/drivers/net/arcnet/com20020.c
linux-2.6.20.changed/drivers/net/arcnet/com20020.c
--- linux-2.6.20/drivers/net/arcnet/com20020.c 2007-02-04 10:44:54.0
-0800
+++ linux-2.6.20.changed/drivers/net/arcnet/com20020.c 2007-02-11
10:29:59.0 -0800
@@ -104,7 +104,7 @@ int com20020_check(struct net_device *de
SET_SUBADR(SUB_SETUP1);
outb(lp-setup, _XREG);
- if (lp-card_flags ARC_CAN_10MBIT)
+ if (lp-clockm != 0)
{
SET_SUBADR(SUB_SETUP2);
outb(lp-setup2, _XREG);
diff -uprN -X linux-2.6.20/Documentation/dontdiff
linux-2.6.20/drivers/net/arcnet/com20020-pci.c
linux-2.6.20.changed/drivers/net/arcnet/com20020-pci.c
--- linux-2.6.20/drivers/net/arcnet/com20020-pci.c 2007-02-04
10:44:54.0 -0800
+++ linux-2.6.20.changed/drivers/net/arcnet/com20020-pci.c 2007-02-11
10:33:11.0 -0800
@@ -155,6 +155,7 @@ static struct pci_device_id com20020pci_
{ 0x1571, 0xa00b, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ARC_IS_5MBIT },
{ 0x1571, 0xa00c, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ARC_IS_5MBIT },
{ 0x1571, 0xa00d, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ARC_IS_5MBIT },
+ { 0x1571, 0xa00e, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ARC_IS_5MBIT },
{ 0x1571, 0xa201, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ARC_CAN_10MBIT },
{ 0x1571, 0xa202, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ARC_CAN_10MBIT },
{ 0x1571, 0xa203, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ARC_CAN_10MBIT },
@@ -163,6 +164,8 @@ static struct pci_device_id com20020pci_
{ 0x1571, 0xa206, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ARC_CAN_10MBIT },
{ 0x10B5, 0x9030, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ARC_CAN_10MBIT },
{ 0x10B5, 0x9050, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ARC_CAN_10MBIT },
+ { 0x14BA, 0x6000, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ARC_CAN_10MBIT },
+ { 0x10B5, 0x2200, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ARC_CAN_10MBIT },
{0,}
};
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [NETDEV] [004] dmfe : Add suspend/resume support
On Friday 09 February 2007 22:54:52 Pavel Machek wrote:
Hi!
From: Maxim Levitsky [EMAIL PROTECTED]
Subject: [PATCH] [NETDEV] [004] dmfe : Add suspend/resume support
Adds support for suspend/resume
Patch looks ok, but your mailer damaged it heavily.
--- linux-2.6.20-mod/drivers/net/tulip/dmfe.c 2007-02-07
18:46:13.0 +0200 +++
linux-2.6.20-test/drivers/net/tulip/dmfe.c 2007-02-07 18:50:52.0
+0200 @@ -55,9 +55,6 @@
TODO
- Implement pci_driver::suspend() and pci_driver::resume()
- power management methods.
-
Check on 64 bit boxes.
Check and fix on big endian boxes.
@@ -2027,11 +2024,59 @@ static struct pci_device_id dmfe_pci_tbl
MODULE_DEVICE_TABLE(pci, dmfe_pci_tbl);
+
+static int dmfe_suspend(struct pci_dev *pci_dev, pm_message_t state)
+{
Pavel
Hi , thanks for reply , I will send them again, and this time I will check
that mailer doesn't mess with patches.
I fixed word wrap problem.
I also want to note that my address is now [EMAIL PROTECTED] , the
address I took recently because yahoo is only aviable via webmail
and it is not good for patches.
Thanks for reply,
regards , Maxim Levitsky
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [NETDEV] [000] dmfe : fix bugs and add features
On Friday 09 February 2007 23:15:26 Jeff Garzik wrote: Levitsky Maxim wrote: Hello, Before some time I decided to fix suspend/resume on my Davicom network card. During development I also fixed couple of bugs and added support for link detection and WOL Note : 2.6.20 already has support for link detection , but it is broken when card has external PHY , like mine. So here it goes: [PATCH] [NET] [001] dmfe : trivial/spelling fixes [PATCH] [NET] [002] dmfe : Fix possible oops [PATCH] [NET] [003] dmfe : fix link detection [PATCH] [NET] [004] dmfe : Add suspend/resume support [PATCH] [NET] [005] dmfe : Add support for wake-on-lan Maxim Levitsky _ ___ Finding fabulous fares is fun. Let Yahoo! FareChase search your favorite travel sites to find flight and hotel bargains. http://farechase.yahoo.com/promo-generic-14795097 - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html What about the above report? I would rather fix this first, before applying more patches on top of a problematic patch... Commit 7628b0a8c01a02966d2228bdf741ddedb128e8f8 (drivers/net/tulip/dmfe: support basic carrier detection) breaks networking on my Davicom DM9009. ethtool always reports there is no link. tcpdump shows incoming packets, but TX is disabled. Reverting the above patch fixes the problem. Regards, Jeff - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Hello, I agree , I will redo all patches with above commit reverted Regards , Maxim Levitsky PS: my mailbox is now [EMAIL PROTECTED] , I took it to use SMTP , because it less likely to corrupt patches - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] MAINTAINERS: no DMFE maintainer
On Saturday 10 February 2007 00:54:04 Randy Dunlap wrote: On Fri, 09 Feb 2007 17:45:12 -0500 Jeff Garzik wrote: Randy Dunlap wrote: From: Randy Dunlap [EMAIL PROTECTED] Tobias wrote that he no longer maintains this driver and requested to be removed from MAINTAINERS. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- MAINTAINERS |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) Levitsky Maxim [EMAIL PROTECTED] just posted a bunch of patches to the dmfe driver, maybe you could ping him? Hi Maxim, What do you think about this patch to the MAINTAINERS file based on your recent DMFE patch history? --- From: Randy Dunlap [EMAIL PROTECTED] Tobias wrote that he no longer maintains this driver and requested to be removed from MAINTAINERS. However, Levitsky Maxim has been active on DMFE recently. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- MAINTAINERS |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-2.6.20-git5.orig/MAINTAINERS +++ linux-2.6.20-git5/MAINTAINERS @@ -1112,8 +1112,8 @@ T: git kernel.org:/pub/scm/linux/kernel/ S: Supported DAVICOM FAST ETHERNET (DMFE) NETWORK DRIVER -P: Tobias Ringstrom -M: [EMAIL PROTECTED] +P: Levitsky Maxim +M: [EMAIL PROTECTED] L: netdev@vger.kernel.org S: Maintained - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Hello , I agree with it. Recently I have studied this driver to fix suspend/resume ( it always woke my system from stand-by , so I had to unload it to make standby work) I have read whole documentation of this chip and I found that WOL and link detection is missing so I added them too. So I feel ok to be maintainer of this driver Regards, Maxim Levitsky - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] MAINTAINERS: no DMFE maintainer
On Saturday 10 February 2007 00:54:04 Randy Dunlap wrote: On Fri, 09 Feb 2007 17:45:12 -0500 Jeff Garzik wrote: Randy Dunlap wrote: From: Randy Dunlap [EMAIL PROTECTED] Tobias wrote that he no longer maintains this driver and requested to be removed from MAINTAINERS. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- MAINTAINERS |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) Levitsky Maxim [EMAIL PROTECTED] just posted a bunch of patches to the dmfe driver, maybe you could ping him? Hi Maxim, What do you think about this patch to the MAINTAINERS file based on your recent DMFE patch history? --- From: Randy Dunlap [EMAIL PROTECTED] Tobias wrote that he no longer maintains this driver and requested to be removed from MAINTAINERS. However, Levitsky Maxim has been active on DMFE recently. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- MAINTAINERS |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-2.6.20-git5.orig/MAINTAINERS +++ linux-2.6.20-git5/MAINTAINERS @@ -1112,8 +1112,8 @@ T: git kernel.org:/pub/scm/linux/kernel/ S: Supported DAVICOM FAST ETHERNET (DMFE) NETWORK DRIVER -P: Tobias Ringstrom -M: [EMAIL PROTECTED] +P: Levitsky Maxim +M: [EMAIL PROTECTED] L: netdev@vger.kernel.org S: Maintained - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Hello, I forgot to tell that I will not use [EMAIL PROTECTED] as my mailbox any more: --- From: Randy Dunlap [EMAIL PROTECTED] Tobias wrote that he no longer maintains this driver and requested to be removed from MAINTAINERS. However, Levitsky Maxim has been active on DMFE recently. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-2.6.20-git5.orig/MAINTAINERS +++ linux-2.6.20-git5/MAINTAINERS @@ -1112,8 +1112,8 @@ T:git kernel.org:/pub/scm/linux/kernel/ S: Supported DAVICOM FAST ETHERNET (DMFE) NETWORK DRIVER -P: Tobias Ringstrom -M:[EMAIL PROTECTED] +P: Levitsky Maxim +M:[EMAIL PROTECTED] L:[EMAIL PROTECTED] S: Maintained - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Bugme-new] [Bug 7974] New: BUG: scheduling while atomic: swapper/0x10000100/0
Francois Romieu [EMAIL PROTECTED] wrote:
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index e76539a..a4bcfe2 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -673,7 +673,7 @@ void rtmsg_ifinfo(int type, struct net_device *dev,
unsigned change)
struct sk_buff *skb;
int err = -ENOBUFS;
- skb = nlmsg_new(if_nlmsg_size(0), GFP_KERNEL);
+ skb = nlmsg_new(if_nlmsg_size(0), GFP_ATOMIC);
if (skb == NULL)
goto errout;
This should only be called under RTNL so it should never be atomic.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Bugme-new] [Bug 7962] New: oops in port_carrier_check
On Fri, Feb 09, 2007 at 09:52:04AM -0800, Stephen Hemminger wrote:
On Fri, 9 Feb 2007 08:42:11 +0100
Jarek Poplawski [EMAIL PROTECTED] wrote:
On 07-02-2007 23:09, Stephen Hemminger wrote:
On Wed, 7 Feb 2007 12:52:16 -0800
Andrew Morton [EMAIL PROTECTED] wrote:
...
Feb 7 21:20:18 plop kernel: BUG: unable to handle kernel paging request
at
virtual address 6b6b6b6b
Feb 7 21:20:18 plop kernel: printing eip:
Feb 7 21:20:18 plop kernel: *pde =
Feb 7 21:20:18 plop kernel: Oops: [#1]
Feb 7 21:20:18 plop kernel: CPU:0
Feb 7 21:20:19 plop kernel: EIP:0060:[pg0+814360305/1067136000]
Not
tainted VLI
Feb 7 21:20:19 plop kernel: EIP:0060:[f0eed6f1]Not tainted VLI
Feb 7 21:20:19 plop kernel: EFLAGS: 00010202 (2.6.20.0.rc7-1mdv #1)
Feb 7 21:20:19 plop kernel: EIP is at port_carrier_check+0x22/0x75
[bridge]
Feb 7 21:20:19 plop kernel: eax: 6b6b6b6b ebx: 6b6b6b6b ecx:
I think it's caused by pending delayed workqueue
trying to use dev after kfree (POISON_FREE in eax, ebx).
static void port_carrier_check(struct work_struct *work)
{
struct net_bridge_port *p;
struct net_device *dev;
struct net_bridge *br;
dev = container_of(work, struct net_bridge_port,
carrier_check.work)-dev;
work_release(work);
rtnl_lock();
p = dev-br_port;
if (!p)
goto done;
br = p-br;
if (netif_carrier_ok(dev))
p-path_cost = port_cost(dev);
if (br-dev-flags IFF_UP) {
My investigation seems to point at this line (p == ebx
but not NULL because of mem debugging on, probably).
Sorry, I overpasted. This is the line:
--br = p-br;
The carrier_check is canceled by removal of port from bridge.
Perhaps there is something broken in rcu assumptions under Qemu
If you mean this:
static void del_nbp(struct net_bridge_port *p)
{
...
cancel_delayed_work(p-carrier_check);
it's not sufficient. According to workqueue.h:
/*
* Kill off a pending schedule_delayed_work(). Note that the work callback
* function may still be running on return from cancel_delayed_work(). Run
* flush_scheduled_work() to wait on it.
*/
static inline int cancel_delayed_work(struct delayed_work *work)
I can't see how rcu could help here with this pointer
to dev passed on to delayed_work (out of any rcu block).
IMHO dev_hold/dev_put (or something alike) is needed here.
Regards,
Jarek P.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: forcedeth problems on 2.6.20-rc6-mm3
Jeff Garzik wrote: Tobias Diedrich wrote: Tobias Diedrich wrote: Ayaz Abdulla wrote: For all those who are having issues, please try out the attached patch. Will try. Does not apply cleanly against 2.6.20, is this one fixed up right? It probably needs to be top of 2.6.20-git-latest or 2.6.20-rc6-mm3. IOW, the forcedeth changes in question are not in 2.6.20, and you need to apply the patch on top of the latest batch of forcedeth changes. Well, it hasn't blown up on me despite being applied to 2.6.20... The problem I was seeing might even be fixed in 2.6.20 vanilla, since the last version I saw it in was 2.6.20-rc6 and then I reverted to 2.6.19 to make sure that one is ok (see [EMAIL PROTECTED]). -- Tobias PGP: http://9ac7e0bc.uguu.de このメールは十割再利用されたビットで作られています。 - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
