Re: [PATCH][RFC] network splice receive v3
On Wed, Jul 11, 2007 at 11:19:27AM +0200, Jens Axboe wrote: Subject: [PATCH] splice: don't assume regular pages in splice_to_pipe() Allow caller to pass in a release function, there might be other resources that need releasing as well. Needed for network receive. diff --git a/fs/splice.c b/fs/splice.c index 3160951..4b4b501 100644 --- a/fs/splice.c +++ b/fs/splice.c @@ -254,11 +254,16 @@ ssize_t splice_to_pipe(struct pipe_inode_info *pipe, } while (page_nr spd_pages) - page_cache_release(spd-pages[page_nr++]); + spd-spd_release(spd, page_nr++); Rather than requiring the caller set this, shouldn't we just allow it? Especially given there is only one non-page user? while (page_nr spd_pages) - page_cache_release(spd-pages[page_nr++]); + if (spd-spd_release) + spd-spd_release(spd, page_nr++); + else + page_cache_release(spd-pages[page_nr++]); Joel -- Any man who is under 30, and is not a liberal, has not heart; and any man who is over 30, and is not a conservative, has no brains. - Sir Winston Churchill Joel Becker Principal Software Developer Oracle E-mail: [EMAIL PROTECTED] Phone: (650) 506-8127 - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 -mm 4/9] netconsole: Add some useful tips to documentation
On Wed, Jul 11, 2007 at 03:40:22AM +0530, Satyam Sharma wrote: IMHO something that mentions /proc/sys/kernel/printk would be better. You don't need to have built with SysRq support for that, it's clearly more flexible than the ignore_loglevel option and wouldn't require a reboot either. I'll send out an updated patch shortly. Why not dmesg -n? We've been using that for years. Or is there some extra change in /proc/sys/kernel/printk? Joel -- Against stupidity the Gods themselves contend in vain. - Friedrich von Schiller Joel Becker Principal Software Developer Oracle E-mail: [EMAIL PROTECTED] Phone: (650) 506-8127 - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 -mm 8/9] netconsole: Support multiple logging targets
On Wed, Jul 11, 2007 at 03:47:09AM +0530, Satyam Sharma wrote: Hmm, I put it in there because I expected that the user must have had at least one target configured (added to target_list) if he's got the module loaded/built-in (and netconsole registered), which is when this function would be triggered anyway. Loading the module won't happen without a config, but there's no requirement that a built-in netconsole has a kernel command-line argument. I always build netconsole for my kernels. Sure, I usually do it as a module, but if I build a monolithic kernel I compile it in. That doesn't mean I always have a server, let alone a netconsole= option :-) Joel -- When choosing between two evils, I always like to try the one I've never tried before. - Mae West Joel Becker Principal Software Developer Oracle E-mail: [EMAIL PROTECTED] Phone: (650) 506-8127 - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH -mm 9/9] netconsole: Support dynamic reconfiguration using configfs
static int __init dynamic_netconsole_init(void)
{
config_group_init(netconsole_subsys.su_group);
mutex_init(netconsole_subsys.su_mtx);
return configfs_register_subsystem(netconsole_subsys);
}
#else
static int __init dynamic_netconsole_init(void)
{
return 0;
}
#endif
Joel
--
Life's Little Instruction Book #3
Watch a sunrise at least once a year.
Joel Becker
Principal Software Developer
Oracle
E-mail: [EMAIL PROTECTED]
Phone: (650) 506-8127
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH -mm 9/9] netconsole: Support dynamic reconfiguration using configfs
On Sat, Jul 07, 2007 at 01:18:45PM +0530, Satyam Sharma wrote: However, for items that are statically initialized (often the group-cg_item members of subsystems or default groups) we often simply set ci_namebuf and then call config_item_init() -- say via config_group_init(), like I've done with the netconsole subsystem in this patch -- but config_item_init() does not set ci_name for such items to ci_namebuf. This means the ci_name member of _initialized_ config_items with their names in ci_namebuf is left un-initialized (NULL, actually, because the subsys / default group would likely be static). Configfs notices subsystems and default groups and handles this. See configfs_register_subsystem() and create_default_group() in fs/configfs/dir.c Right. We shouldn't special case (at least not without adding a comment why that would be right) and we never know what might happen to the code at some later day. So let's keep the get() / put() pair. If you're keeping them, don't do the empty_item, check the name. Otherwise, the changes you describe sound good. Joel -- I have never let my schooling interfere with my education. - Mark Twain Joel Becker Principal Software Developer Oracle E-mail: [EMAIL PROTECTED] Phone: (650) 506-8127 - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH -mm 5/9] netconsole: Introduce dev_status member
On Wed, Jul 04, 2007 at 04:38:04PM +0530, Satyam Sharma wrote:
- if (!(event == NETDEV_CHANGEADDR || event == NETDEV_CHANGENAME))
- goto done;
+ if (!(event == NETDEV_UP || event == NETDEV_DOWN ||
+ event == NETDEV_CHANGEADDR || event == NETDEV_CHANGENAME))
+ goto done;
if (nt-np.dev == dev) {
switch (event) {
It's a small nit, but isn't the large if() just the degenerate
default case of the switch()? Why have it at all?
Joel
--
Life's Little Instruction Book #396
Never give anyone a fruitcake.
Joel Becker
Principal Software Developer
Oracle
E-mail: [EMAIL PROTECTED]
Phone: (650) 506-8127
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH -mm 8/9] netconsole: Update documentation for dynamic reconfigurability
On Wed, Jul 04, 2007 at 04:38:19PM +0530, Satyam Sharma wrote: +Some examples follow (configfs is mounted at the /config mountpoint, say). configfs is generally expected to be mounted at /sys/kernel/config, and it even creates that mountpoint for itself. The documentation should probably be consistent with that. Joel -- Also, all of life's big problems include the words 'indictment' or 'inoperable.' Everything else is small stuff. - Alton Brown Joel Becker Principal Software Developer Oracle E-mail: [EMAIL PROTECTED] Phone: (650) 506-8127 - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC][PATCH -mm 0/9] netconsole: Multiple targets and dynamic reconfigurability
On Wed, Jul 04, 2007 at 05:55:15PM +0530, Satyam Sharma wrote: On Wed, 4 Jul 2007, Keiichi KII wrote: By the way, how can I add Signed-off-by:'s to your patches? Should I add it to each patch and submit them to this list again? Anybody could give me an advice? I think you could just individually reply to all the mails and replace the Cc: in front of your name + email ID with Signed-off-by: -- after reviewing testing this, of course! If the chain is not going through Keiichi, he should be responding with Acked-by:, not Signed-off-by:. Then Satyam submits the patches upstream with the Acked-by: line and his own Signed-off-by: Joel -- Anything that is too stupid to be spoken is sung. - Voltaire Joel Becker Principal Software Developer Oracle E-mail: [EMAIL PROTECTED] Phone: (650) 506-8127 - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)
On Mon, Mar 05, 2007 at 04:46:09PM +0100, Tomasz Torcz wrote: On Mon, Mar 05, 2007 at 01:13:26AM -0600, Matt Mackall wrote: That's not the point. The point is that Debian/unstable as of _this morning_ doesn't work. For reference, I'm running both the latest releases of both hal (0.5.8.1-6.1) and network-manager (0.6.4-6). And there are people telling me I need a copy of HAL out of git that hasn't even been released for Debian to package. Debian isn't the problem here. hal 0.5.9-rc1 (released, not from git) should work. It will be problably released soon and picked by sane distributions. Debian is very irritating corner case. As of right now, Fedora Core 6 has hal-0.5.8.1-6.fc6. This is also too old. Please, stop claiming that Debian unstable is some corner case. No one is talking about Debian stable here. No one is talking about the Enterprise versions of Red Hat or SuSE (you'd find them just as irritating with modern kernels). Debian unstable tracks released code as fast or faster than Fedora and OpenSuSE. They all keep up with releases. But the last release of hal is 0.5.8.1. _Release_, not release candidate. You can't break that. You can't break it for a while, if you want a sane deprecation schedule. These are userspace interfaces. Matt is absolutely correct that you should't deprecate a userspace-kernel interface before you've even provided a release of the tool that detects the change! Joel -- When ideas fail, words come in very handy. - Goethe Joel Becker Principal Software Developer Oracle E-mail: [EMAIL PROTECTED] Phone: (650) 506-8127 - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [patch] do not allow IPW_2100=Y or IPW_2200=Y
On Tue, Jul 11, 2006 at 04:42:13PM +0200, Arjan van de Ven wrote: just load fakephp Thanks! I'd never heard of it :-) Joel -- The only way to get rid of a temptation is to yield to it. - Oscar Wilde Joel Becker Principal Software Developer Oracle E-mail: [EMAIL PROTECTED] Phone: (650) 506-8127 - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [patch] do not allow IPW_2100=Y or IPW_2200=Y
On Mon, Jul 10, 2006 at 08:51:58PM +0200, Arjan van de Ven wrote: Besides, the initramfs runs long after the driver init routine runs which is when the firmware needs to be available. .. unless you use sysfs to do a fake hotunplug + replug the device, at which point the driver init routine runs again. Can we document how to do that? I've wanted to synthesize such things before, and I couldn't quite reason how. In my case, I had RHEL4 module-init-tools that don't wait for modprobe, so I had to compile in scsi and qla2x00, but the qla2x00 needs firmware, and it's too early...etc. Joel -- Baby, even the losers Get luck sometimes. Even the losers Keep a little bit of pride. Joel Becker Principal Software Developer Oracle E-mail: [EMAIL PROTECTED] Phone: (650) 506-8127 - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
