Re: [PATCH] rtlwifi: rtl8822be: Add firmware for new driver/device

[Kyle McMartin]

On Fri, Aug 25, 2017 at 09:23:40AM -0500, Larry Finger wrote:
> A driver for the RTL8822BE has been added to staging. This commit supplies
> the firmware for it.
> 
> Signed-off-by: Larry Finger 
> ---

applied. thanks Larry.

--kyle

Re: [PATCH linux-firmware v2] Mellanox: Add firmware for mlxsw_spectrum

[Kyle McMartin]

On Thu, Jun 01, 2017 at 09:28:10AM +0300, Yotam Gigi wrote:
> Add first firmware for the Mellanox Spectrum switch, as a followup to the
> recently added commit:
> 6b7421992b8d ("mlxsw: spectrum: Validate firmware revision on init")
> 
> The version of the firmware release is 13.1420.122
> 

applied, thanks Yotam.

--kyle

> Signed-off-by: Yotam Gigi 
> ---
>  mellanox/mlxsw_spectrum-13.1420.122.mfa2 | Bin 0 -> 860424 bytes
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  create mode 100644 mellanox/mlxsw_spectrum-13.1420.122.mfa2
> 

Re: [PATCH linux-firmware] Mellanox: Add firmware for mlxsw_spectrum

[Kyle McMartin]

On Mon, May 29, 2017 at 01:42:28PM +0300, Yotam Gigi wrote:
> Add first firmware for the Mellanox Spectrum switch, as a followup to the
> recently added commit:
> 6b7421992b8d ("mlxsw: spectrum: Validate firmware revision on init")
> 
> The version of the firmware release is 13.1420.122
> 
> Signed-off-by: Yotam Gigi 
> ---
>  mlxsw_spectrum-13.1420.122.mfa2 | Bin 0 -> 860424 bytes
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  create mode 100644 mlxsw_spectrum-13.1420.122.mfa2
> 
> diff --git a/mlxsw_spectrum-13.1420.122.mfa2 b/mlxsw_spectrum-13.1420.122.mfa2
> new file mode 100644

Can we please put this in a subdirectory if we're going to be adding
more versions of this in the future?

--Kyle

Re: [PATCH linux-firmware] qed: Add firmware 8.20.0.0

[Kyle McMartin]

On Wed, May 17, 2017 at 02:39:24PM +0300, Yuval Mintz wrote:
> The new QED firmware has 2 main purposes -
> First, it contains fixes to various initializations and firmware
> logic including:
>  - Corrects iSCSI fast retransmit when data digest is enabled.
>  - Stop draining packets when receiving several consecutive PFCs.
>  - Prevent possible assertion when consecutively opening/closing
>many connections.
>  - Prevent possible asserton due to too long BDQ fetch time.
> 
> In addition, this firmware contains sufficient infrastructure on which
> we'll add iWARP support in our drivers.
> 
> Signed-off-by: Yuval Mintz 
> ---
> Hi,
> 
> Please consider applying this to `linux-firmware'.
> 

applied, thanks Yuval.

regards, Kyle

Re: [PATCH] rtl_bt: Update firmware for BT part of rtl8822be

[Kyle McMartin]

On Fri, Apr 14, 2017 at 12:55:52AM -0500, Larry Finger wrote:
> These files were supplied by Realtek.
> 
> Signed-off-by: Larry Finger 

Applied, thanks Larry.

--Kyle

Re: [PATCH linux-firmware] qed: Add firmware 8.15.3.0

[Kyle McMartin]

On Thu, Mar 09, 2017 at 12:00:49PM +0200, Yuval Mintz wrote:
> This new firmware for the qed* adapters fixes multiple issues:
>  - Prevent accidental drops in Tx-switching between VFs.
>  - Corrct VF cleanup for higher VFs.
>  - Better handling of RoCE error flows.
>  - MR registration/deregistration corrections.
>  - Prevent possible HW attention during offloaded TCP teardown.
>  - Corrections to iSCSI retransmit flows.
> 
> In addition, this firmware is a requirement for supporting the
> QL41xxx series of adapters, as it contains the necessary init
> and firmware logic for those.
> 
> Signed-off-by: Yuval Mintz 

applied, thanks Yuval.

regards, --kyle

Re: [PATCH] rtlwifi: rtl8723bs: Add firmware for new driver

[Kyle McMartin]

On Thu, Jan 19, 2017 at 03:04:27PM -0600, Larry Finger wrote:
> This driver is being added for Fedora users, and will then be added
> to the mainline kernel.
> 
> Signed-off-by: Larry Finger 
> c: Hans de Goede 

Applied.

Re: [PATCH] rtlwifi: rtl8192ee: New firmware from Realtek

[Kyle McMartin]

On Sat, Dec 17, 2016 at 12:50:54PM -0600, Larry Finger wrote:
> -Info: Taken from Realtek version 
> rtl_92ce_92se_92de_8723ae_88ee_8723be_92ee_linux_mac80211_0017.1224.2013
> +Info: Initial version taken from Realtek version
> +  
> rtl_92ce_92se_92de_8723ae_88ee_8723be_92ee_linux_mac80211_0017.1224.2013
> +  Updated Jan. 14, 2015 with file added by Realtek to
> +  http://github.com/lwfinger/rtlwifi_new.git.
>  File: rtlwifi/rtl8192eefw.bin
>  

Uh, did something weird happen here? This patch was applied in 2015. ;-)

cheers, Kyle

Re: [PATCH] rtlwifi: Add updates for RTL8723BE and RTL8821AE

[Kyle McMartin]

On Sun, Nov 27, 2016 at 01:28:34PM -0600, Larry Finger wrote:
> The new versions will only work with new versions of the drivers. For
> that reason, they are given new names and the old versions are retained.
> 
> Signed-off-by: Larry Finger 
> ---
>  WHENCE |   4 

applied, thanks Larry.

regards, --kyle

Re: [PATCH linux-firmware] qed: Add firmware 8.10.10.0

[Kyle McMartin]

On Tue, Aug 16, 2016 at 05:33:10PM +0300, Yuval Mintz wrote:
> This new firmware for the qed* adpaters fixes several issues:
>  - Better blocking of malicious VFs.
>  - After FLR, Tx-switching [internal routing] of packets might
>be incorrect.
>  - Deletion of unicast MAC filters would sometime have side-effect
>of corrupting the MAC filters configred for a device.
> It also contains fixes for future qed* drivers that *hopefully* would be
> sent for review in the near future.
> 
> In addition, it would allow driver some new functionality, including:
>  - Allowing PF/VF driver compaitibility with old drivers [running
>pre-8.10.5.0 firmware].
>  - Better debug facilities.
> 
> Signed-off-by: Yuval Mintz 

Applied, thanks Yuval.

--Kyle

Re: [PATCH linux-firmware] qed: Add FW 8.10.5.0

[Kyle McMartin]

On Tue, May 17, 2016 at 12:50:02AM +0300, Yuval Mintz wrote:
> The new QED firmware contains several new additions;
> As for bug-fixes, it fixes a couple of issues:
>  - Wrong classification of packets in 4-port devices.
>  - Anti-spoof interoperability with encapsulated packets.
>  - Tx-switching of encapsulated packets.
> It also slightly improves Tx performance in several scenarios.
> 
> >From the driver's feature-set POV, this firmware would
> allow us to add 2 major enhancements in the near future:
>  - It would allow us produce a register dump from the device,
>as well as other debug-related information.
>  - It should be sufficient for our iscsi driver, which we [hopefully]
>plan to push upstream soon.
> 
> Signed-off-by: Yuval Mintz 

Merged, thanks Yuval.

--Kyle

Re: [PATCH linux-firmware] bnx2x: Add FW 7.13.1.0.

[Kyle McMartin]

On Thu, Nov 19, 2015 at 06:41:26PM +0200, Yuval Mintz wrote:
> This adds new FW for bnx2x, which adds the following:
>  - Ability to change outer vlan ID for some multi-function modes.
>  - FW ability for Geneve RSS classification according to inner headers.
>  - Prevent VFs from sending MAC control frames.
> 
> Signed-off-by: Yuval Mintz 

applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH linux-firmware] qed: Add FW 8.4.2.0.

[Kyle McMartin]

On Mon, Nov 09, 2015 at 09:54:34AM +0200, Yuval Mintz wrote:
> From: Sudarsana Kalluru 
> 
> This adds the first FW entry to the newly added
> Qlogic Ethernet Driver product series.
> 
> Signed-off-by: Sudarsana Kalluru 
> Signed-off-by: Yuval Mintz 

Applied, thanks.

--Kyle
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] bnx2x: Update to FW version 7.12.30

[Kyle McMartin]

On Thu, Jul 16, 2015 at 10:10:43AM +0300, Yuval Mintz wrote:
 The new FW will allow us to utilize some new features in our driver,
 mainly adding vlan stripping offload and vxlan offload support.
 
 In addition, this fixes several issues:
  - Packets from a VF with pvid configured which were sent with a
different vlan were transmitted instead of being discarded.
 
  - FCoE traffic might not recover after a failue while there's traffic
to another function.
 
 Signed-off-by: Yuval Mintz yuval.mi...@qlogic.com
 ---
 As mentioned, this was previously sent only to Ben/David.
 Now designating it to the proper mailing list.

applied.

regards, kyle
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] bnx2x: Update to FW version 7.12.30

[Kyle McMartin]

On Wed, Jul 15, 2015 at 04:50:55AM +, Yuval Mintz wrote:
 Hi Kyle,
 
 I've sent a new bnx2x FW ~3 weeks ago, but I wasn't aware of the
 change in E-mails and that I was supposed to send it to linux-firmware,
 so I addressed it to David/Ben as I used to in the past.
 And I haven't seen any reply to it.
 
 Should I re-send the FW patch to linux-firmware?
 

Yes, please. It's unlikely David or Ben would have time to get around to
it.

regards, --Kyle
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] README: clarify redistribution requirements covering patents

[Kyle McMartin]

On Thu, Jun 11, 2015 at 06:02:56PM -0700, Luis R. Rodriguez wrote:
 On Thu, May 28, 2015 at 5:48 PM, Luis R. Rodriguez mcg...@suse.com wrote:
  On Tue, May 19, 2015 at 1:22 PM, Luis R. Rodriguez
  mcg...@do-not-panic.com wrote:
  This v2 just changes licence to license as requested by Arend.
 
  Please let me know if there is anything else needed.
 
 Just a friendly reminder.
 

Pulled, sorry.

--Kyle
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] bnx2x: Update to FW version 7.12.30

[Kyle McMartin]

On Mon, Jul 13, 2015 at 10:17:24AM +, Yuval Mintz wrote:
The new FW will allow us to utilize some new features in our driver,
mainly adding vlan filtering offload and vxlan offload support.
   
In addition, this fixes several issues:
1. Packets from a VF with pvid configured which were sent with a
   different vlan were transmitted instead of being discarded.
   
2. FCoE traffic might not recover after a failue while there's traffic
   to another function.
   
Signed-off-by: Yuval Mintz yuval.mi...@qlogic.com
  
   Hi, any news about this one?
   Thanks, Yuval
  
  Any updates? I've sent this 3-weeks ago and haven't seen any reply.
 
 Apparently the destination E-mail has changed and I was unaware.
 Is anyone here? ;-)
 

Hmm?

--Kyle
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] mlx4: needs vmalloc.h for vmap()

[Kyle McMartin]

Commit 313abe55a87bc10e55d00f337d609e17ad5f8c9a added a vmap usage to
mlx4. Unfortunately on some platforms (ppc64) linux/vmalloc.h is not
implicitly included. Fix that.

Signed-off-by: Kyle McMartin [EMAIL PROTECTED]

---
diff --git a/drivers/net/mlx4/alloc.c b/drivers/net/mlx4/alloc.c
index 521dc03..75ef9d0 100644
--- a/drivers/net/mlx4/alloc.c
+++ b/drivers/net/mlx4/alloc.c
@@ -34,6 +34,7 @@
 #include linux/slab.h
 #include linux/bitmap.h
 #include linux/dma-mapping.h
+#include linux/vmalloc.h
 
 #include mlx4.h
 
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] tg3: Fix APE induced regression

[Kyle McMartin]

On Thu, Oct 11, 2007 at 06:43:50PM -0700, Matt Carlson wrote:
 This patch fixes a bug caused by the recent APE support added for 5761
 devices.
 
 Signed-off-by: Matt Carlson [EMAIL PROTECTED]
 

Woot, thanks! This just bit me as I was testing git head on some of my
parisc boxes.

Cheers,
Kyle
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [CORRECTION][PATCH] Fix a potential NULL pointer dereference in uli526x_interrupt() in drivers/net/tulip/uli526x.c

[Kyle McMartin]

On Thu, Sep 13, 2007 at 02:03:46AM -0700, Andrew Morton wrote:
 I suspect the fix we want is:
 

ack. The trend seems to be to avoid this redundant check in the
interrupt handler.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 14/24] make atomic_read() behave consistently on parisc

[Kyle McMartin]

On Thu, Aug 09, 2007 at 10:01:54AM -0400, Chris Snook wrote:
 From: Chris Snook [EMAIL PROTECTED]
 
 Purify volatile use for atomic[64]_t on parisc.
 
 Signed-off-by: Chris Snook [EMAIL PROTECTED]
 

Sure, why not.

ACKed-by: Kyle McMartin [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [TULIP] Need new maintainer

[Kyle McMartin]

On Mon, Jul 30, 2007 at 01:04:13PM -0600, Valerie Henson wrote:
 The Tulip network driver needs a new maintainer!  I no longer have
 time to maintain the Tulip network driver and I'm stepping down.  Jeff
 Garzik would be happy to get volunteers.
 

Since I already take care of a major consumer of these devices (parisc,
which pretty much all have tulip) I'm willing to take care of this.
Alternately, Grant is probably willing.

Cheers,
Kyle
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 0/9] tulip patches from parisc-linux

[Kyle McMartin]

[Val asked that I split this out, instead of just publishing a git tree,
so here goes nothing. I don't think I've ever used git-send-email before,
but hopefully I won't screw up too badly.]

The following patch series brings the mainline tulip driver in synch
with the modifications made in parisc-linux. Most of these patches
have been in parisc-linux cvs for the better part of several years,
so they are quite well tested.

It contains the following changes,

 21142.c   |4 +-
 de2104x.c |6 +--
 interrupt.c   |4 ++
 media.c   |   40 +-
 timer.c   |   14 ++-
 tulip.h   |   43 ++--
 tulip_core.c  |  102 --
 winbond-840.c |   68 +-
 8 files changed, 164 insertions(+), 117 deletions(-)

Francois Romieu:
  [TULIP] Defer tulip_select_media() to process context

Grant Grundler:
  [TULIP] Fix PHY init and reset
  [TULIP] Print physical address in tulip_init_one
  [TULIP] Make tulip_stop_rxtx() failure case slightly more informative
  [TULIP] Clean tulip.h so it can be used by winbond-840.c
  [TULIP] Flush MMIO writes in reset sequence
  [TULIP] Fix IRQ/DMA race

Helge Deller:
  [TULIP] Fix section mismatch in de2104x.c

Thibaut Varene:
  [TULIP] Make DS21143 printout match lspci output

Cheers!
Kyle M.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/9] [TULIP] Fix PHY init and reset

[Kyle McMartin]

From: Grant Grundler [EMAIL PROTECTED]

A whole slew of fixes for tulip_select_media for:
 - Flush posted MMIO writes as per PCI spec
 - Polling the reset bit (bit 15) is required to determine when
   the init sequence can be sent.

This fixes tulip on HP PA-RISC systems, which use DP83840A and
LXT971D PHYs. Tested for several years on a variety of HP PA-RISC
systems.

[Initial work done by Grant Grundler, DS21142 support added by
Thibaut Varene.]

Signed-off-by: Grant Grundler [EMAIL PROTECTED]
Signed-off-by: Thibaut Varene [EMAIL PROTECTED]
Signed-off-by: Kyle McMartin [EMAIL PROTECTED]
---
 drivers/net/tulip/media.c |   40 +---
 1 files changed, 37 insertions(+), 3 deletions(-)

diff --git a/drivers/net/tulip/media.c b/drivers/net/tulip/media.c
index e9bc2a9..5093d87 100644
--- a/drivers/net/tulip/media.c
+++ b/drivers/net/tulip/media.c
@@ -44,8 +44,10 @@ static const unsigned char comet_miireg2
 
 /* MII transceiver control section.
Read and write the MII registers using software-generated serial
-   MDIO protocol.  See the MII specifications or DP83840A data sheet
-   for details. */
+   MDIO protocol.
+   See IEEE 802.3-2002.pdf (Section 2, Chapter 22.2.4 Management functions)
+   or DP83840A data sheet for more details.
+   */
 
 int tulip_mdio_read(struct net_device *dev, int phy_id, int location)
 {
@@ -261,24 +263,56 @@ void tulip_select_media(struct net_devic
u16 *reset_sequence = 
((u16*)(p+3))[init_length];
int reset_length = p[2 + init_length*2];
misc_info = reset_sequence + reset_length;
-   if (startup)
+   if (startup) {
+   int timeout = 10;
for (i = 0; i  reset_length; i++)

iowrite32(get_u16(reset_sequence[i])  16, ioaddr + CSR15);
+
+   /* flush posted writes */
+   ioread32(ioaddr + CSR15);
+
+   /* Sect 3.10.3 in DP83840A.pdf (p39) */
+   udelay(500);
+
+   /* Section 4.2 in DP83840A.pdf (p43) */
+   /* and IEEE 802.3 22.2.4.1.1 Reset */
+   while (timeout-- 
+   (tulip_mdio_read (dev, phy_num, 
MII_BMCR)  BMCR_RESET))
+   udelay(100);
+   }
for (i = 0; i  init_length; i++)
iowrite32(get_u16(init_sequence[i])  
16, ioaddr + CSR15);
+
+   ioread32(ioaddr + CSR15);   /* flush posted 
writes */
} else {
u8 *init_sequence = p + 2;
u8 *reset_sequence = p + 3 + init_length;
int reset_length = p[2 + init_length];
misc_info = (u16*)(reset_sequence + 
reset_length);
if (startup) {
+   int timeout = 10;
iowrite32(mtable-csr12dir | 0x100, 
ioaddr + CSR12);
for (i = 0; i  reset_length; i++)
iowrite32(reset_sequence[i], 
ioaddr + CSR12);
+
+   /* flush posted writes */
+   ioread32(ioaddr + CSR12);
+
+   /* Sect 3.10.3 in DP83840A.pdf (p39) */
+   udelay(500);
+
+   /* Section 4.2 in DP83840A.pdf (p43) */
+   /* and IEEE 802.3 22.2.4.1.1 Reset */
+   while (timeout-- 
+   (tulip_mdio_read (dev, phy_num, 
MII_BMCR)  BMCR_RESET))
+   udelay(100);
}
for (i = 0; i  init_length; i++)
iowrite32(init_sequence[i], ioaddr + 
CSR12);
+
+   ioread32(ioaddr + CSR12);   /* flush posted 
writes */
}
+
tmp_info = get_u16(misc_info[1]);
if (tmp_info)
tp-advertising[phy_num] = tmp_info | 1;
-- 
1.4.1.1

-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 7/9] [TULIP] Defer tulip_select_media() to process context

[Kyle McMartin]

From: Francois Romieu [EMAIL PROTECTED]

Move tulip_select_media() processing to a workqueue, instead of delaying
in interrupt context.

[Edit by Kyle to use kevent thread, instead of creating its own
 workqueue.]

Signed-off-by: Kyle McMartin [EMAIL PROTECTED]
---
 drivers/net/tulip/21142.c  |4 +--
 drivers/net/tulip/timer.c  |   14 -
 drivers/net/tulip/tulip.h  |   19 ++--
 drivers/net/tulip/tulip_core.c |   64 +++-
 4 files changed, 60 insertions(+), 41 deletions(-)

diff --git a/drivers/net/tulip/21142.c b/drivers/net/tulip/21142.c
index 683f14b..ffba0c1 100644
--- a/drivers/net/tulip/21142.c
+++ b/drivers/net/tulip/21142.c
@@ -26,9 +26,9 @@ static u16 t21142_csr15[] = { 0x0008, 0x
 
 /* Handle the 21143 uniquely: do autoselect with NWay, not the EEPROM list
of available transceivers.  */
-void t21142_timer(unsigned long data)
+void t21142_media_task(void *data)
 {
-   struct net_device *dev = (struct net_device *)data;
+   struct net_device *dev = data;
struct tulip_private *tp = netdev_priv(dev);
void __iomem *ioaddr = tp-base_addr;
int csr12 = ioread32(ioaddr + CSR12);
diff --git a/drivers/net/tulip/timer.c b/drivers/net/tulip/timer.c
index e058a9f..272ef62 100644
--- a/drivers/net/tulip/timer.c
+++ b/drivers/net/tulip/timer.c
@@ -18,13 +18,14 @@ #include linux/pci.h
 #include tulip.h
 
 
-void tulip_timer(unsigned long data)
+void tulip_media_task(void *data)
 {
-   struct net_device *dev = (struct net_device *)data;
+   struct net_device *dev = data;
struct tulip_private *tp = netdev_priv(dev);
void __iomem *ioaddr = tp-base_addr;
u32 csr12 = ioread32(ioaddr + CSR12);
int next_tick = 2*HZ;
+   unsigned long flags;
 
if (tulip_debug  2) {
printk(KERN_DEBUG %s: Media selection tick, %s, status %8.8x 
mode
@@ -126,6 +127,15 @@ void tulip_timer(unsigned long data)
}
break;
}
+
+
+   spin_lock_irqsave(tp-lock, flags);
+   if (tp-timeout_recovery) {
+   tulip_tx_timeout_complete(tp, ioaddr);
+   tp-timeout_recovery = 0;
+   }
+   spin_unlock_irqrestore(tp-lock, flags);
+
/* mod_timer synchronizes us with potential add_timer calls
 * from interrupts.
 */
diff --git a/drivers/net/tulip/tulip.h b/drivers/net/tulip/tulip.h
index 951af5e..408fe46 100644
--- a/drivers/net/tulip/tulip.h
+++ b/drivers/net/tulip/tulip.h
@@ -43,7 +43,8 @@ struct tulip_chip_table {
int io_size;
int valid_intrs;/* CSR7 interrupt enable settings */
int flags;
-   void (*media_timer) (unsigned long data);
+   void (*media_timer) (unsigned long);
+   void (*media_task) (void *);
 };
 
 
@@ -371,6 +372,7 @@ #endif
unsigned int medialock:1;   /* Don't sense media type. */
unsigned int mediasense:1;  /* Media sensing in progress. */
unsigned int nway:1, nwayset:1; /* 21143 internal NWay. */
+   unsigned int timeout_recovery:1;
unsigned int csr0;  /* CSR0 setting. */
unsigned int csr6;  /* Current CSR6 control settings. */
unsigned char eeprom[EEPROM_SIZE];  /* Serial EEPROM contents. */
@@ -389,6 +391,7 @@ #endif
void __iomem *base_addr;
int csr12_shadow;
int pad0;   /* Used for 8-byte alignment */
+   struct work_struct media_work;
 };
 
 
@@ -403,7 +406,7 @@ struct eeprom_fixup {
 
 /* 21142.c */
 extern u16 t21142_csr14[];
-void t21142_timer(unsigned long data);
+void t21142_media_task(void *data);
 void t21142_start_nway(struct net_device *dev);
 void t21142_lnk_change(struct net_device *dev, int csr5);
 
@@ -441,7 +444,7 @@ void pnic_lnk_change(struct net_device *
 void pnic_timer(unsigned long data);
 
 /* timer.c */
-void tulip_timer(unsigned long data);
+void tulip_media_task(void *data);
 void mxic_timer(unsigned long data);
 void comet_timer(unsigned long data);
 
@@ -493,4 +496,14 @@ static inline void tulip_restart_rxtx(st
tulip_start_rxtx(tp);
 }
 
+static inline void tulip_tx_timeout_complete(struct tulip_private *tp, void 
__iomem *ioaddr)
+{
+   /* Stop and restart the chip's Tx processes. */
+   tulip_restart_rxtx(tp);
+   /* Trigger an immediate transmit demand. */
+   iowrite32(0, ioaddr + CSR1);
+
+   tp-stats.tx_errors++;
+}
+
 #endif /* __NET_TULIP_H__ */
diff --git a/drivers/net/tulip/tulip_core.c b/drivers/net/tulip/tulip_core.c
index 363e5f6..bdb6698 100644
--- a/drivers/net/tulip/tulip_core.c
+++ b/drivers/net/tulip/tulip_core.c
@@ -130,7 +130,14 @@ #else
 int tulip_debug = 1;
 #endif
 
+static void tulip_timer(unsigned long data)
+{
+   struct net_device *dev = (struct net_device *)data;
+   struct tulip_private *tp = netdev_priv(dev);
 
+   if (netif_running(dev))
+   schedule_work(tp-media_work);
+}
 
 /*
  * This table use during operation

[PATCH 9/9] [TULIP] Fix section mismatch in de2104x.c

[Kyle McMartin]

From: Helge Deller [EMAIL PROTECTED]

WARNING: drivers/net/tulip/de2104x.o - Section mismatch: reference to 
.init.text:de_init_one from .data.rel.local after 'de_driver' (at offset 0x20)
WARNING: drivers/net/tulip/de2104x.o - Section mismatch: reference to 
.exit.text:de_remove_one from .data.rel.local after 'de_driver' (at offset 0x28)

Signed-off-by: Helge Deller [EMAIL PROTECTED]
Signed-off-by: Kyle McMartin [EMAIL PROTECTED]
---
 drivers/net/tulip/de2104x.c |6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/tulip/de2104x.c b/drivers/net/tulip/de2104x.c
index d05c5aa..150a05a 100644
--- a/drivers/net/tulip/de2104x.c
+++ b/drivers/net/tulip/de2104x.c
@@ -1730,7 +1730,7 @@ static void __init de21040_get_media_inf
 }
 
 /* Note: this routine returns extra data bits for size detection. */
-static unsigned __init tulip_read_eeprom(void __iomem *regs, int location, int 
addr_len)
+static unsigned __devinit tulip_read_eeprom(void __iomem *regs, int location, 
int addr_len)
 {
int i;
unsigned retval = 0;
@@ -1926,7 +1926,7 @@ bad_srom:
goto fill_defaults;
 }
 
-static int __init de_init_one (struct pci_dev *pdev,
+static int __devinit de_init_one (struct pci_dev *pdev,
  const struct pci_device_id *ent)
 {
struct net_device *dev;
@@ -2082,7 +2082,7 @@ err_out_free:
return rc;
 }
 
-static void __exit de_remove_one (struct pci_dev *pdev)
+static void __devexit de_remove_one (struct pci_dev *pdev)
 {
struct net_device *dev = pci_get_drvdata(pdev);
struct de_private *de = dev-priv;
-- 
1.4.1.1

-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 3/9] [TULIP] Make tulip_stop_rxtx() failure case slightly more informative

[Kyle McMartin]

From: Grant Grundler [EMAIL PROTECTED]

Signed-off-by: Grant Grundler [EMAIL PROTECTED]
Signed-off-by: Kyle McMartin [EMAIL PROTECTED]
---
 drivers/net/tulip/tulip.h |7 +--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/net/tulip/tulip.h b/drivers/net/tulip/tulip.h
index 3bcfbf3..d79c7ae 100644
--- a/drivers/net/tulip/tulip.h
+++ b/drivers/net/tulip/tulip.h
@@ -473,8 +473,11 @@ static inline void tulip_stop_rxtx(struc
udelay(10);
 
if (!i)
-   printk(KERN_DEBUG %s: tulip_stop_rxtx() failed\n,
-   pci_name(tp-pdev));
+   printk(KERN_DEBUG %s: tulip_stop_rxtx() failed
+(CSR5 0x%x CSR6 0x%x)\n,
+   pci_name(tp-pdev),
+   ioread32(ioaddr + CSR5),
+   ioread32(ioaddr + CSR6));
}
 }
 
-- 
1.4.1.1

-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 5/9] [TULIP] Flush MMIO writes in reset sequence

[Kyle McMartin]

From: Grant Grundler [EMAIL PROTECTED]

The obvious safe registers to read is one from PCI config space.

Signed-off-by: Grant Grundler [EMAIL PROTECTED]
Signed-off-by: Kyle McMartin [EMAIL PROTECTED]
---
 drivers/net/tulip/tulip_core.c |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/net/tulip/tulip_core.c b/drivers/net/tulip/tulip_core.c
index 6b54572..81905f4 100644
--- a/drivers/net/tulip/tulip_core.c
+++ b/drivers/net/tulip/tulip_core.c
@@ -295,12 +295,14 @@ static void tulip_up(struct net_device *
 
/* Reset the chip, holding bit 0 set at least 50 PCI cycles. */
iowrite32(0x0001, ioaddr + CSR0);
+   pci_read_config_dword(tp-pdev, PCI_COMMAND, i);  /* flush write */
udelay(100);
 
/* Deassert reset.
   Wait the specified 50 PCI cycles after a reset by initializing
   Tx and Rx queues and the address filter list. */
iowrite32(tp-csr0, ioaddr + CSR0);
+   pci_read_config_dword(tp-pdev, PCI_COMMAND, i);  /* flush write */
udelay(100);
 
if (tulip_debug  1)
-- 
1.4.1.1

-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 6/9] [TULIP] Fix IRQ/DMA race

[Kyle McMartin]

From: Grant Grundler [EMAIL PROTECTED]

IRQs are racing with tulip_down().
DMA can be restarted by tulip_interrupt() _after_ we call
tulip_stop_rxtx() and the DMA buffers are unmapped.  The result
is an MCA (hard crash on ia64) because of an IO TLB miss.

Signed-off-by: Grant Grundler [EMAIL PROTECTED]
Signed-off-by: Kyle McMartin [EMAIL PROTECTED]
---
 drivers/net/tulip/interrupt.c  |4 
 drivers/net/tulip/tulip_core.c |   17 +++--
 2 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/drivers/net/tulip/interrupt.c b/drivers/net/tulip/interrupt.c
index 99ccf2e..19faa0e 100644
--- a/drivers/net/tulip/interrupt.c
+++ b/drivers/net/tulip/interrupt.c
@@ -87,6 +87,10 @@ int tulip_refill_rx(struct net_device *d
}
tp-rx_ring[entry].status = cpu_to_le32(DescOwned);
}
+
+/* FIXME: restarting DMA breaks tulip_down() code path.
+   tulip_down() will unmap the RX and TX descriptors.
+ */
if(tp-chip_id == LC82C168) {
if(((ioread32(tp-base_addr + CSR5)17)0x07) == 4) {
/* Rx stopped due to out of buffers,
diff --git a/drivers/net/tulip/tulip_core.c b/drivers/net/tulip/tulip_core.c
index 81905f4..363e5f6 100644
--- a/drivers/net/tulip/tulip_core.c
+++ b/drivers/net/tulip/tulip_core.c
@@ -742,21 +742,20 @@ #endif
 
/* Disable interrupts by clearing the interrupt mask. */
iowrite32 (0x, ioaddr + CSR7);
+   ioread32 (ioaddr + CSR7);   /* flush posted write */
 
-   /* Stop the Tx and Rx processes. */
-   tulip_stop_rxtx(tp);
+   spin_unlock_irqrestore (tp-lock, flags);
 
-   /* prepare receive buffers */
-   tulip_refill_rx(dev);
+   free_irq (dev-irq, dev);   /* no more races after this */
+   tulip_stop_rxtx(tp);/* Stop DMA */
 
-   /* release any unconsumed transmit buffers */
-   tulip_clean_tx_ring(tp);
+   /* Put driver back into the state we start with */
+   tulip_refill_rx(dev);   /* prepare RX buffers */
+   tulip_clean_tx_ring(tp);/* clean up unsent TX buffers */
 
if (ioread32 (ioaddr + CSR6) != 0x)
tp-stats.rx_missed_errors += ioread32 (ioaddr + CSR8)  0x;
 
-   spin_unlock_irqrestore (tp-lock, flags);
-
init_timer(tp-timer);
tp-timer.data = (unsigned long)dev;
tp-timer.function = tulip_tbl[tp-chip_id].media_timer;
@@ -782,7 +781,6 @@ static int tulip_close (struct net_devic
printk (KERN_DEBUG %s: Shutting down ethercard, status was 
%2.2x.\n,
dev-name, ioread32 (ioaddr + CSR5));
 
-   free_irq (dev-irq, dev);
 
/* Free all the skbuffs in the Rx queue. */
for (i = 0; i  RX_RING_SIZE; i++) {
@@ -1752,7 +1750,6 @@ static int tulip_suspend (struct pci_dev
tulip_down(dev);
 
netif_device_detach(dev);
-   free_irq(dev-irq, dev);
 
pci_save_state(pdev);
pci_disable_device(pdev);
-- 
1.4.1.1

-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 8/9] [TULIP] Make DS21143 printout match lspci output

[Kyle McMartin]

From: Thibaut Varene [EMAIL PROTECTED]

Signed-off-by: Thibaut Varene [EMAIL PROTECTED]
Signed-off-by: Kyle McMartin [EMAIL PROTECTED]
---
 drivers/net/tulip/tulip_core.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/tulip/tulip_core.c b/drivers/net/tulip/tulip_core.c
index bdb6698..21eaeb2 100644
--- a/drivers/net/tulip/tulip_core.c
+++ b/drivers/net/tulip/tulip_core.c
@@ -155,7 +155,7 @@ struct tulip_chip_table tulip_tbl[] = {
tulip_media_task },
 
   /* DC21142, DC21143 */
-  { Digital DS21143 Tulip, 128, 0x0801fbff,
+  { Digital DS21142/43 Tulip, 128, 0x0801fbff,
HAS_MII | HAS_MEDIA_TABLE | ALWAYS_CHECK_MII | HAS_ACPI | HAS_NWAY
| HAS_INTR_MITIGATION | HAS_PCI_MWI, tulip_timer, t21142_media_task },
 
-- 
1.4.1.1

-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 4/9] [TULIP] Clean tulip.h so it can be used by winbond-840.c

[Kyle McMartin]

From: Grant Grundler [EMAIL PROTECTED]

Include tulip.h in winbond-840.c and clean up lots of redundant
definitions.

Signed-off-by: Grant Grundler [EMAIL PROTECTED]
Signed-off-by: Kyle McMartin [EMAIL PROTECTED]
---
 drivers/net/tulip/tulip.h   |   17 ++
 drivers/net/tulip/tulip_core.c  |7 +---
 drivers/net/tulip/winbond-840.c |   68 ++-
 3 files changed, 37 insertions(+), 55 deletions(-)

diff --git a/drivers/net/tulip/tulip.h b/drivers/net/tulip/tulip.h
index d79c7ae..951af5e 100644
--- a/drivers/net/tulip/tulip.h
+++ b/drivers/net/tulip/tulip.h
@@ -30,11 +30,10 @@ #include asm/irq.h
 /* undefine, or define to various debugging levels (4 == obscene levels) */
 #define TULIP_DEBUG 1
 
-/* undefine USE_IO_OPS for MMIO, define for PIO */
 #ifdef CONFIG_TULIP_MMIO
-# undef USE_IO_OPS
+#define TULIP_BAR  1   /* CBMA */
 #else
-# define USE_IO_OPS 1
+#define TULIP_BAR  0   /* CBIO */
 #endif
 
 
@@ -142,6 +141,7 @@ enum status_bits {
RxNoBuf = 0x80,
RxIntr = 0x40,
TxFIFOUnderflow = 0x20,
+   RxErrIntr = 0x10,
TxJabber = 0x08,
TxNoBuf = 0x04,
TxDied = 0x02,
@@ -192,9 +192,14 @@ struct tulip_tx_desc {
 
 
 enum desc_status_bits {
-   DescOwned = 0x8000,
-   RxDescFatalErr = 0x8000,
-   RxWholePkt = 0x0300,
+   DescOwned= 0x8000,
+   DescWholePkt = 0x6000,
+   DescEndPkt   = 0x4000,
+   DescStartPkt = 0x2000,
+   DescEndRing  = 0x0200,
+   DescUseLink  = 0x0100,
+   RxDescFatalErr = 0x008000,
+   RxWholePkt   = 0x0300,
 };
 
 
diff --git a/drivers/net/tulip/tulip_core.c b/drivers/net/tulip/tulip_core.c
index bf93679..6b54572 100644
--- a/drivers/net/tulip/tulip_core.c
+++ b/drivers/net/tulip/tulip_core.c
@@ -1361,11 +1361,8 @@ #endif
if (pci_request_regions (pdev, tulip))
goto err_out_free_netdev;
 
-#ifndef USE_IO_OPS
-   ioaddr =  pci_iomap(pdev, 1, tulip_tbl[chip_idx].io_size);
-#else
-   ioaddr =  pci_iomap(pdev, 0, tulip_tbl[chip_idx].io_size);
-#endif
+   ioaddr =  pci_iomap(pdev, TULIP_BAR, tulip_tbl[chip_idx].io_size);
+
if (!ioaddr)
goto err_out_free_res;
 
diff --git a/drivers/net/tulip/winbond-840.c b/drivers/net/tulip/winbond-840.c
index 7f41481..fa3a7b3 100644
--- a/drivers/net/tulip/winbond-840.c
+++ b/drivers/net/tulip/winbond-840.c
@@ -90,10 +90,8 @@ static int full_duplex[MAX_UNITS] = {-1,
Making the Tx ring too large decreases the effectiveness of channel
bonding and packet priority.
There are no ill effects from too-large receive rings. */
-#define TX_RING_SIZE   16
 #define TX_QUEUE_LEN   10  /* Limit ring entries actually used.  */
 #define TX_QUEUE_LEN_RESTART   5
-#define RX_RING_SIZE   32
 
 #define TX_BUFLIMIT(1024-128)
 
@@ -137,6 +135,8 @@ #include asm/processor.h  /* Processor
 #include asm/io.h
 #include asm/irq.h
 
+#include tulip.h
+
 /* These identify the driver base version and may not be removed. */
 static char version[] __devinitdata =
 KERN_INFO DRV_NAME .c:v DRV_VERSION  (2.4 port)  DRV_RELDATE   Donald 
Becker [EMAIL PROTECTED]\n
@@ -242,8 +242,8 @@ static const struct pci_id_info pci_id_t
 };
 
 /* This driver was written to use PCI memory space, however some x86 systems
-   work only with I/O space accesses.  Pass -DUSE_IO_OPS to use PCI I/O space
-   accesses instead of memory space. */
+   work only with I/O space accesses. See CONFIG_TULIP_MMIO in .config
+*/
 
 /* Offsets to the Command and Status Registers, CSRs.
While similar to the Tulip, these registers are longword aligned.
@@ -261,21 +261,11 @@ enum w840_offsets {
CurTxDescAddr=0x4C, CurTxBufAddr=0x50,
 };
 
-/* Bits in the interrupt status/enable registers. */
-/* The bits in the Intr Status/Enable registers, mostly interrupt sources. */
-enum intr_status_bits {
-   NormalIntr=0x1, AbnormalIntr=0x8000,
-   IntrPCIErr=0x2000, TimerInt=0x800,
-   IntrRxDied=0x100, RxNoBuf=0x80, IntrRxDone=0x40,
-   TxFIFOUnderflow=0x20, RxErrIntr=0x10,
-   TxIdle=0x04, IntrTxStopped=0x02, IntrTxDone=0x01,
-};
-
 /* Bits in the NetworkConfig register. */
 enum rx_mode_bits {
-   AcceptErr=0x80, AcceptRunt=0x40,
-   AcceptBroadcast=0x20, AcceptMulticast=0x10,
-   AcceptAllPhys=0x08, AcceptMyPhys=0x02,
+   AcceptErr=0x80,
+   RxAcceptBroadcast=0x20, AcceptMulticast=0x10,
+   RxAcceptAllPhys=0x08, AcceptMyPhys=0x02,
 };
 
 enum mii_reg_bits {
@@ -297,13 +287,6 @@ struct w840_tx_desc {
u32 buffer1, buffer2;
 };
 
-/* Bits in network_desc.status */
-enum desc_status_bits {
-   DescOwn=0x8000, DescEndRing=0x0200, DescUseLink=0x0100,
-   DescWholePkt=0x6000, DescStartPkt=0x2000, DescEndPkt=0x4000,
-   DescIntr=0x8000,
-};
-
 #define MII_CNT1 /* winbond only supports one MII */
 struct netdev_private {
struct

[PATCH 2/9] [TULIP] Print physical address in tulip_init_one

[Kyle McMartin]

From: Grant Grundler [EMAIL PROTECTED]

As the cookie returned by pci_iomap() is fairly useless...

Signed-off-by: Grant Grundler [EMAIL PROTECTED]
Signed-off-by: Kyle McMartin [EMAIL PROTECTED]
---
 drivers/net/tulip/tulip_core.c |   10 --
 1 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/net/tulip/tulip_core.c b/drivers/net/tulip/tulip_core.c
index 7351831..bf93679 100644
--- a/drivers/net/tulip/tulip_core.c
+++ b/drivers/net/tulip/tulip_core.c
@@ -1644,8 +1644,14 @@ #endif
if (register_netdev(dev))
goto err_out_free_ring;
 
-   printk(KERN_INFO %s: %s rev %d at %p,,
-  dev-name, chip_name, chip_rev, ioaddr);
+   printk(KERN_INFO %s: %s rev %d at 
+#ifdef CONFIG_TULIP_MMIO
+   MMIO
+#else
+   Port
+#endif
+0x%lx,, dev-name, chip_name, chip_rev,
+   pci_resource_start(pdev, TULIP_BAR));
pci_set_drvdata(pdev, dev);
 
if (eeprom_missing)
-- 
1.4.1.1

-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [parisc-linux] [git patches] tulip fixes from parisc-linux

[Kyle McMartin]

On Sat, Jul 29, 2006 at 06:43:39PM -0600, Grant Grundler wrote:
 I just wanted to warn that some of the changes are already in akpm
 's tree (-mm).
 Becuase off hand I've forgotten which ones, would it be better to
 diff against -mm instead?

tulip-fix-shutdown-dma-irq-race.patch
  tulip: fix shutdown DMA/irq race

tulip-fix-for-64-bit-mips.patch
  tulip: fix for 64-bit mips

tulip-natsemi-dp83840a-phy-fix.patch
  tulip: NatSemi DP83840A PHY fix

Are the tulip patches in -mm, found here:
http://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc2/2.6.18-rc2-mm1/broken-out/tulip-fix-for-64-bit-mips.patch
http://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc2/2.6.18-rc2-mm1/broken-out/tulip-fix-shutdown-dma-irq-race.patch
http://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc2/2.6.18-rc2-mm1/broken-out/tulip-natsemi-dp83840a-phy-fix.patch

[akpm: I added you to the CC list, if Val acks the patches can
you see that they make their way into -mm?
git.kernel.org/pub/scm/linux/kernel/git/kyle/tulip-2.6.git#master]

Cheers,
Kyle M.

-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [parisc-linux] [git patches] tulip fixes from parisc-linux

[Kyle McMartin]

On Sun, Jul 30, 2006 at 11:35:32AM -0700, Andrew Morton wrote:
 hm.  A couple of those patches have been futzing around in -mm for over a
 year and have been nacked by Jeff and are a regular source of grumpygrams. 
 I've been sitting on them in the pathetic hope that someone will one day
 get down and address the bugs which they fix in an acceptable fashion,
 whatever that is.
 

Jeff/Val seemed willing to merge the fixes as they stood. parisc-linux
merged Francois' tulip workqueue patch some time ago, and have been
running with it since without issue. This defers the tulip_select_media
work to process context, and so should be less of an issue.

Cheers,
Kyle
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[git patches] tulip fixes from parisc-linux

[Kyle McMartin]

Hi Val,

Sorry it took so long for me to get around to splitting
up the changes from the parisc-linux tree. But here
they finally are. This patchset has been running on a
variety of parisc and ia64 machines for quite some
time (several years...) without issue. Some of these
are more cosmetic changes than anything else.

Cheers,
Kyle M.

The following changes since commit dc710afe95ee9b263ab593c11d86a684f1606872:
  Linus Torvalds:
Merge branch 'upstream-linus' of 
master.kernel.org:/.../jgarzik/libata-dev

are found in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/kyle/tulip-2.6.git

Francois Romieu:
  [TULIP] Defer tulip_select_media() to process context

Grant Grundler:
  [TULIP] Fix PHY init and reset
  [TULIP] Print physical address in tulip_init_one
  [TULIP] Make tulip_stop_rxtx() failure case slightly more informative
  [TULIP] Clean tulip.h so it can be used by winbond-840.c
  [TULIP] Flush MMIO writes in reset sequence
  [TULIP] Fix IRQ/DMA race

Helge Deller:
  [TULIP] Fix section mismatch in de2104x.c

Thibaut Varene:
  [TULIP] Make DS21143 printout match lspci output

 drivers/net/tulip/21142.c   |4 +-
 drivers/net/tulip/de2104x.c |6 +-
 drivers/net/tulip/interrupt.c   |4 ++
 drivers/net/tulip/media.c   |   40 ++-
 drivers/net/tulip/timer.c   |   14 +
 drivers/net/tulip/tulip.h   |   43 
 drivers/net/tulip/tulip_core.c  |  102 +++
 drivers/net/tulip/winbond-840.c |   68 +-
 8 files changed, 164 insertions(+), 117 deletions(-)
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Error acx-20060215 wireless module

[Kyle McMartin]

On Fri, Jul 14, 2006 at 06:08:46PM +0200, VinX wrote:
 I think that it's missing linux/utsrelease.h on this file!
 

Wow. Why does so much out of tree shite want UTS_RELEASE? I'm
(untested) thinking that instead they could just put in their Makefile:

CFLAGS += -D KERNVERSION=$(KERNELVERSION)

And obtain it from the Linux Makefile instead of from UTS_RELEASE.

Of course if they don't use Kbuild this won't work...
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: PATCHv3 2.6.17-rc5 tulip free_irq() called too late

[Kyle McMartin]

On Tue, Jun 13, 2006 at 10:44:12PM -0600, Grant Grundler wrote:
 On Tue, Jun 13, 2006 at 08:33:22PM -0400, Jeff Garzik wrote:
  Grant Grundler wrote:
  o tulip_stop_rxtx() has to be called _after_ free_irq().
ie. v2 patch didn't fix the original race condition
and when under test, dies about as fast as the original code.
  
  You made the race window smaller, but it's still there.  The chip's DMA 
  engines should be stopped before you unregister the interrupt handler.
 
 Switching the order to be:
 tulip_stop_rxtx(tp);/* Stop DMA */
 free_irq (dev-irq, dev);   /* no more races after this */
 

I think the correct sequence would be:

reset tulip interrupt mask
flush posted write

synchronize irq /* make sure we got 'em all */
tulip_stop_rxtx /* turn off dma */
free irq/* bye bye */

The synchronize irq guarantees we shouldn't see another irq
generated by the card because it was held up somewhere.

Cheers,
Kyle M.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] Make in-kernel hostap less annoying

[Kyle McMartin]

Most user don't want their kern.log/dmesg filled with
debugging gibberish, and could turn it on if prompted.

( Example:
wifi0: TXEXC - status=0x0004 ([Discon]) tx_control=000c
retry_count=0 tx_rate=0 fc=0x0108 (Data::0 ToDS)
A1=00:0f:66:43:d7:0a A2=00:05:3c:06:63:01 A3=33:33:00:00:00:16 
A4=00:00:00:00:00:00 )


Also make hostap default to managed mode, instead of master mode, which
has bitten a few users expecting it to behave like the orinoco driver
it is replacing.

Signed-off-by: Kyle McMartin [EMAIL PROTECTED]

---
Two minor things I've been carrying around in my personal tree
for quite some time. (This is only relevant to the in-kernel driver,
I see no reason to change the out-of-tree driver.)

Cheers,
Kyle

diff --git a/drivers/net/wireless/hostap/hostap_config.h 
b/drivers/net/wireless/hostap/hostap_config.h
index c090a5a..bc51fa9 100644
--- a/drivers/net/wireless/hostap/hostap_config.h
+++ b/drivers/net/wireless/hostap/hostap_config.h
@@ -38,7 +38,7 @@ #endif
  */
 
 /* Do not include debug messages into the driver */
-/* #define PRISM2_NO_DEBUG */
+#define PRISM2_NO_DEBUG
 
 /* Do not include /proc/net/prism2/wlan#/{registers,debug} */
 /* #define PRISM2_NO_PROCFS_DEBUG */
diff --git a/drivers/net/wireless/hostap/hostap_hw.c 
b/drivers/net/wireless/hostap/hostap_hw.c
index 328e9a1..57438e8 100644
--- a/drivers/net/wireless/hostap/hostap_hw.c
+++ b/drivers/net/wireless/hostap/hostap_hw.c
@@ -70,7 +70,7 @@ static char essid[33] = test;
 module_param_string(essid, essid, sizeof(essid), 0444);
 MODULE_PARM_DESC(essid, Host AP's ESSID);
 
-static int iw_mode[MAX_PARM_DEVICES] = { IW_MODE_MASTER, DEF_INTS };
+static int iw_mode[MAX_PARM_DEVICES] = { IW_MODE_INFRA, DEF_INTS };
 module_param_array(iw_mode, int, NULL, 0444);
 MODULE_PARM_DESC(iw_mode, Initial operation mode);
 
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2.6.17-rc6] Remove Prism II support from Orinoco

[Kyle McMartin]

On Sun, Jun 11, 2006 at 06:40:54PM -0400, Dave Jones wrote:
 Under hostap, it's a brick, it won't even report any scanning results.
 

Did you switch it into managed mode? The hostap driver, iirc, defaults
to running in master (AP) mode.

Cheers,
Kyle
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated

[Kyle McMartin]

On Sat, Jan 28, 2006 at 08:19:44PM -0500, Benjamin LaHaise wrote:
 The overuse of atomics is horrific in what is being proposed.  All the
 major architectures except powerpc (i386, x86-64, ia64, and sparc64) 
 implement local_t.  It would make far more sense to push the last few 
 stragglers (which mostly seem to be uniprocessor) into writing the 
 appropriate implementations.  Perhaps it's time to add a #error in 
 asm-generic/local.h?


Surely asm-generic/local.h could now be reimplemented using atomic_long_t
to kill that aberration that is the BITS_PER_LONG != 32 case currently...? 
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html