Re: 2.6.24 regression: reference count leak in PPPoE

[Malte Schröder]

On Sun, 20 Jan 2008 20:53:30 +0100
Andi Kleen [EMAIL PROTECTED] wrote:

 
 My workstation running 2.6.24-rc8 just hung during shutdown with an endless 
 (or rather I didn't wait more than a few minutes) loop of 
 
 unregister_netdev: waiting for ppp-device to become free. Usage count = 1
 
 ppp-device was an active PPPoE device.
 
 No more information currently.

Now that you mention it, this happened to me too this morning. My
system stops the ppp interface (pppoe) and starts it again (my provider
shuts down the link every 24 hours, I want that to happen during the
night, so I do a ifdown ppp0).




-- 
---
Malte Schröder
[EMAIL PROTECTED]
ICQ# 68121508
---



signature.asc
Description: PGP signature

Re: Linux 2.6.19

[Malte Schröder]

On Thursday 30 November 2006 03:15, David Miller wrote:
 From: Phil Oester [EMAIL PROTECTED]
 Date: Wed, 29 Nov 2006 17:49:04 -0800

  Getting an oops on boot here, caused by commit
  e81c73596704793e73e6dbb478f41686f15a4b34 titled
  [NET]: Fix MAX_HEADER setting.
 
  Reverting that patch fixes things up for me.  Dave?

 I suspect that it might be because I removed the IPV6
 ifdef from the list,  but I can't imagine why that would
 matter other than due to a bug in the IPV6 stack

 Indeed.

 Looking at ndisc_send_rs() I wonder if it miscalculates
 'len' or similar and the old MAX_HEADER setting was
 merely papering around this bug

 In fact it does, the NDISC code is using MAX_HEADER incorrectly.  It
 needs to explicitly allocate space for the struct ipv6hdr in 'len'.
 Luckily the TCP ipv6 code was doing it right.

 What a horrible bug, this patch should fix it.  Let me know
 if it doesn't, thanks:

I also encountered this bug (wasn't there in -rc6). The patch also fixes it 
for me.

regards
-- 
---
Malte Schröder
[EMAIL PROTECTED]
ICQ# 68121508
---



pgpOqfDpsQNjB.pgp
Description: PGP signature