[PATCH 1/2] dgrs: remove from build, config, and maintainer list
From: Nathanael Nerode Stop building and configuring driver for Digi RightSwitch, which was never actually sold to anyone, and remove it from MAINTAINERS. In response to an investigation into the firmware of the Digi Rightswitch driver, Andres Salomon discovered: Dear Andres: After further research, we found that this product was killed in place and never reached the market. We would like to request that this not be included. Since the product never reached market, clearly nobody is using this orphaned driver. Signed-off-by: Nathanael Nerode [EMAIL PROTECTED] --- This is patch 1 of 2 for removing the Digi Rightswitch (dgrs). Patch 2 would be the patch to remove the actual files. However, that would be around 400K, which doesn't seem suitable for a mailing list -- and this length seems quite unnecessary, given that it would consist solely of full-file deletions. I'm not quite sure what to do about this. Please advise. These are the files to be deleted: ./Documentation/networking/dgrs.txt ./drivers/net/dgrs.c ./drivers/net/dgrs.h ./drivers/net/dgrs_asstruct.h ./drivers/net/dgrs_bcomm.h ./drivers/net/dgrs_es4h.h ./drivers/net/dgrs_ether.h ./drivers/net/dgrs_firmware.c (this is the very large one) ./drivers/net/dgrs_i82596.h ./drivers/net/dgrs_plx9060.h diff -upr linux-2.6.22.6/drivers/net/Kconfig linux-2.6-deleted/drivers/net/Kconfig --- linux-2.6.22.6/drivers/net/Kconfig 2007-08-31 02:21:01.0 -0400 +++ linux-2.6-deleted/drivers/net/Kconfig 2007-09-12 03:28:11.0 -0400 @@ -1447,21 +1447,6 @@ config TC35815 depends on NET_PCI PCI MIPS select MII -config DGRS - tristate Digi Intl. RightSwitch SE-X support - depends on NET_PCI (PCI || EISA) - ---help--- - This is support for the Digi International RightSwitch series of - PCI/EISA Ethernet switch cards. These include the SE-4 and the SE-6 - models. If you have a network card of this type, say Y and read the - Ethernet-HOWTO, available from - http://www.tldp.org/docs.html#howto. More specific - information is contained in file:Documentation/networking/dgrs.txt. - - To compile this driver as a module, choose M here and read - file:Documentation/networking/net-modules.txt. The module - will be called dgrs. - config EEPRO100 tristate EtherExpressPro/100 support (eepro100, original Becker driver) depends on NET_PCI PCI diff -upr linux-2.6.22.6/drivers/net/Makefile linux-2.6-deleted/drivers/net/Makefile --- linux-2.6.22.6/drivers/net/Makefile 2007-08-31 02:21:01.0 -0400 +++ linux-2.6-deleted/drivers/net/Makefile 2007-09-12 03:28:31.0 -0400 @@ -38,7 +38,6 @@ obj-$(CONFIG_CASSINI) += cassini.o obj-$(CONFIG_MACE) += mace.o obj-$(CONFIG_BMAC) += bmac.o -obj-$(CONFIG_DGRS) += dgrs.o obj-$(CONFIG_VORTEX) += 3c59x.o obj-$(CONFIG_TYPHOON) += typhoon.o obj-$(CONFIG_NE2K_PCI) += ne2k-pci.o 8390.o diff -upr linux-2.6.22.6/MAINTAINERS linux-2.6-deleted/MAINTAINERS --- linux-2.6.22.6/MAINTAINERS 2007-08-31 02:21:01.0 -0400 +++ linux-2.6-deleted/MAINTAINERS 2007-09-12 03:27:26.0 -0400 @@ -1234,12 +1234,6 @@ L: [EMAIL PROTECTED] W: http://www.digi.com S: Orphaned -DIGI RIGHTSWITCH NETWORK DRIVER -P: Rick Richardson -L: netdev@vger.kernel.org -W: http://www.digi.com -S: Orphaned - DIRECTORY NOTIFICATION P: Stephen Rothwell M: [EMAIL PROTECTED] -- Nathanael Nerode [EMAIL PROTECTED] [Insert famous quote here] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Please remove useless dgrs driver
An official email from digi.com to Andres Salomon [EMAIL PROTECTED] explained: Dear Andres: After further research, we found that this product was killed in place and never reached the market. We would like to request that this not be included. Copy at http://wiki.debian.org/KernelFirmwareLicensing (this was discovered during research into firmware licensing). The drgs driver is useless (no hardware to drive) and should be removed. The files which should be deleted from the tree are: drivers/net/dgrs.c drivers/net/dgrs.h drivers/net/dgrs_es4h.h drivers/net/dgrs_plx9060.h drivers/net/dgrs_i82596.h drivers/net/dgrs_ether.h drivers/net/dgrs_asstruct.h drivers/net/dgrs_bcomm.h drivers/net/dgrs_firmware.c It will probably also be necessary to delete some stuff from drivers/net/Kconfig and drivers/net/Makefile, but I assume that this will be trivial for any net maintainer. Thanks in advance for doing this. -- Nathanael Nerode [EMAIL PROTECTED] (Instead, we front-load the flamewars and grudges in the interest of efficiency.) --Steve Lanagasek, http://lists.debian.org/debian-devel/2005/09/msg01056.html - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[Fwd: Re: [PATCH 2.6.13-rc3] tg3: Move tg3 firmware into separate file]
Original Message From: - Mon Jul 18 15:34:09 2005 X-Mozilla-Status: 0001 X-Mozilla-Status2: 0080 Message-ID: [EMAIL PROTECTED] Date: Mon, 18 Jul 2005 15:34:07 -0400 From: Nathanael Nerode [EMAIL PROTECTED] User-Agent: Debian Thunderbird 1.0.2 (X11/20050331) X-Accept-Language: en-us, en MIME-Version: 1.0 To: David S. Miller [EMAIL PROTECTED] Subject: Re: [PATCH 2.6.13-rc3] tg3: Move tg3 firmware into separate file References: [EMAIL PROTECTED] [EMAIL PROTECTED] In-Reply-To: [EMAIL PROTECTED] X-Enigmail-Version: 0.91.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit David S. Miller wrote: From: Nathanael Nerode [EMAIL PROTECTED] Date: Sun, 17 Jul 2005 07:55:45 -0400 This is partly for the purpose of doing firmware loading in the future, but it's also a matter of tidiness. So make the change when we do the loading like that in the future. The fact that you are forcing the issue right now makes Not forcing; do what you think best, of course! me suspicious of your real reason for desiring this change. OK, the real reason is that it makes life slightly easier for Debian. Sorry I didn't mention that; I've been a bit flaky lately. Gory details follow. Debian's policy means that it can't ship the firmware in its kernel source package, because that goes in main and has to satisfy all kinds of requirements. Instead the plan is to ship the firmware in a separate package in the non-free section (which is nearly ready to go, actually). Debian already has a form of firmware loading working, but apparently that is not sufficiently ready to be accepted upstream, which is why it hasn't been submitted yet. (I'm working on it. IIRC, necessary elements for acceptance upstream include transitional code which will fall back to the built-in firmware if loadable firmware isn't available, and an automatic installation system for loadable firmware files. Right?) Debian policy further means that the upstream tarball portion of its kernel source package shouldn't contain files which differ from the versions in the real upstream tarball. (Simple deletions or additions are acceptable in a pinch, but changes belong in the Debian local portion.) So due to the current file structure, the tg3.c file is deleted from the upstream tarball, and an entirely new copy is added in the Debian local portion. With the firmware in a separate file, the tg3_firmware.h file could be deleted from the upstream tarball, and a (small) diff to tg3.c could be included in the Debian local portion. Which would make life easier for the Debian maintainers and help avoid accidental version skew in tg3.c versus upstream. In addition, having the firmware in a separate file will make it more straightforward to construct the separate package which will contain the firmware; the source file can then be used as-is, which it can't now. tg3 isn't the only driver for which Debian is doing this sort of thing, but all the others have the firmware in separate files, causing the package maintainers to swear rather more about tg3. I figured it wouldn't hurt to submit this change now rather than waiting until the firmware loading code was ready. I am a habitual code tidier anyway. Hope this helps, Nathanael Nerode - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2.6.13-rc3] tg3: Move tg3 firmware into separate file
David S. Miller wrote: From: Nathanael Nerode [EMAIL PROTECTED] Date: Mon, 18 Jul 2005 15:34:07 -0400 Debian's policy means that it can't ship the firmware in its kernel source package, because that goes in main and has to satisfy all kinds of requirements. Exactly as I suspected, and you removed the CC: list in your response which really angers me. Why can't you show your true reasons for desiring this change on the mailing list? Oh, please forward my message to the mailing list if you wish to. On second thought, I'll save you the trouble and do it myself. I hit reply instead of reply all. Things have been a mess around here lately and I've been flakier than usual. If you're going to get angry, please find a better reason. Are you still angry because I (among other people) wanted to get the copyright license on the firmware fixed so it actually worked? Well, it's fixed now, and thanks for incorporating it. If you wish to keep the firmware in the .c file for whatever reason, that's your prerogative. Personally, I can't see any technical reason for not separating the firmware into a separate header file -- it seems to be the standard practice -- but if you have a reason I'd love to hear it. It's reasonable from a file-size perspective, anyway; the tg3.c file is 300K, and the firmware is 42K of that, so it's not creating any gratuitously small files. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
