RE: [Patch v2] net: phy: marvell: Limit 88m1101 autoneg errata to 88E1145 as well.

2017-12-18 Thread Qiang Zhao 
 From: David Miller <da...@davemloft.net>
 Date: Tue, 19 Dec 2017 2:20AM
> -Original Message-
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Tuesday, December 19, 2017 2:20 AM
> To: Qiang Zhao <qiang.z...@nxp.com>
> Cc: netdev@vger.kernel.org
> Subject: Re: [Patch v2] net: phy: marvell: Limit 88m1101 autoneg errata to
> 88E1145 as well.
> 
> From: Zhao Qiang <qiang.z...@nxp.com>
> Date: Mon, 18 Dec 2017 10:26:43 +0800
> 
> > 88E1145 also need this autoneg errata.
> >
> > Fixes: f2899788353c ("net: phy: marvell: Limit errata to 88m1101")
> > Signed-off-by: Zhao Qiang <qiang.z...@nxp.com>
> > ---
> > Changes for v2
> >     - modify the commit msg in a proper way.
> 
> Applied and queued up for -stable.

Thank you!

Best Regards
Qiang Zhao

RE: [PATCH] Maxim/driver: Add driver for maxim ds26522

2016-06-23 Thread Qiang Zhao 
On Thu, 2016-06-23 at 10:59PM, David Miller wrote:
> -Original Message-
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Thursday, June 23, 2016 10:59 PM
> To: Qiang Zhao <qiang.z...@nxp.com>
> Cc: o...@buserror.net; linux-ker...@vger.kernel.org; netdev@vger.kernel.org;
> Xiaobo Xie <xiaobo@nxp.com>
> Subject: Re: [PATCH] Maxim/driver: Add driver for maxim ds26522
> 
> From: Zhao Qiang <qiang.z...@nxp.com>
> Date: Thu, 23 Jun 2016 09:09:45 +0800
> 
> > +MODULE_DESCRIPTION(DRV_DESC);
> 
> There is no definition of DRV_DESC, so this makes it look like you didn't even
> compile this driver.

I really, really compiled this driver.
Thank you for your review and comments. I will modify it the next version.

[zhaoqiang@titan:~/upstream/linux]$ll drivers/net/wan/slic_ds26522.o
-rw-r--r-- 1 zhaoqiang klocwork 153288 Jun 22 15:48 
drivers/net/wan/slic_ds26522.o
[zhaoqiang@titan:~/upstream/linux]$date
Fri Jun 24 09:42:16 CST 2016

-Zhao Qiang
BR

RE: [v9, 6/7] MAINTAINERS: add entry for Freescale SoC driver

2016-05-04 Thread Qiang Zhao 
On Wed, 2016-05-04 at 11:24 +0800, Yangbo Lu wrote:
> -Original Message-
> From: Yangbo Lu [mailto:yangbo...@nxp.com]
> Sent: Wednesday, May 04, 2016 11:25 AM
> To: linux-...@vger.kernel.org; linuxppc-...@lists.ozlabs.org;
> devicet...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux-
> ker...@vger.kernel.org; linux-...@vger.kernel.org; linux-...@vger.kernel.org;
> io...@lists.linux-foundation.org; netdev@vger.kernel.org
> Cc: ulf.hans...@linaro.org; Scott Wood <o...@buserror.net>; Mark Rutland
> <mark.rutl...@arm.com>; Rob Herring <robh...@kernel.org>; Russell King
> <li...@arm.linux.org.uk>; Jochen Friedrich <joc...@scram.de>; Joerg Roedel
> <j...@8bytes.org>; Claudiu Manoil <claudiu.man...@freescale.com>; Bhupesh
> Sharma <bhupesh.sha...@freescale.com>; Qiang Zhao
> <qiang.z...@nxp.com>; Kumar Gala <ga...@codeaurora.org>; Santosh
> Shilimkar <ssant...@kernel.org>; Yang-Leo Li <leoyang...@nxp.com>; Xiaobo
> Xie <xiaobo@nxp.com>; Yangbo Lu <yangbo...@nxp.com>
> Subject: [v9, 6/7] MAINTAINERS: add entry for Freescale SoC driver
> 
> Add maintainer entry for Freescale SoC driver including the QE library and the
> GUTS driver now. Also add maintainer for QE library.
> 
> Signed-off-by: Yangbo Lu <yangbo...@nxp.com>
> ---
> Changes for v8:
>   - Added this patch
> Changes for v9:
>   - Added linux-arm mail list
>   - Removed GUTS driver entry
> ---
>  MAINTAINERS | 11 ++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 42e65d1..ce91db7 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4622,9 +4622,18 @@ F: drivers/net/ethernet/freescale/fec_ptp.c
>  F:   drivers/net/ethernet/freescale/fec.h
>  F:   Documentation/devicetree/bindings/net/fsl-fec.txt
> 
> +FREESCALE SOC DRIVER
> +M:   Scott Wood <o...@buserror.net>
> +L:   linuxppc-...@lists.ozlabs.org
> +L:   linux-arm-ker...@lists.infradead.org
> +S:   Maintained
> +F:   drivers/soc/fsl/
> +F:   include/linux/fsl/
> +
>  FREESCALE QUICC ENGINE LIBRARY
> +M:   Qiang Zhao <qiang.z...@nxp.com>
>  L:   linuxppc-...@lists.ozlabs.org
> -S:   Orphan
> +S:   Maintained
>  F:   drivers/soc/fsl/qe/
>  F:   include/soc/fsl/*qe*.h
>  F:   include/soc/fsl/*ucc*.h
> --
> 2.1.0.27.g96db324

I am ok!

-Zhao Qiang

RE: [PATCH 5/5] drivers/net: support hdlc function for QE-UCC

2016-04-19 Thread Qiang Zhao 
On 20/04/2016 12:22AM, Christophe Leroy <christophe.le...@c-s.fr> wrote
> -Original Message-
> From: Christophe Leroy [mailto:christophe.le...@c-s.fr]
> Sent: Wednesday, April 20, 2016 12:22 AM
> To: Qiang Zhao <qiang.z...@nxp.com>; da...@davemloft.net
> Cc: gre...@linuxfoundation.org; Xiaobo Xie <xiaobo@nxp.com>; linux-
> ker...@vger.kernel.org; o...@buserror.net; netdev@vger.kernel.org;
> a...@linux-foundation.org; linuxppc-...@lists.ozlabs.org
> Subject: Re: [PATCH 5/5] drivers/net: support hdlc function for QE-UCC
> 
> Le 30/03/2016 10:50, Zhao Qiang a écrit :
> > The driver add hdlc support for Freescale QUICC Engine.
> > It support NMSI and TSA mode.
> When using TSA, how does the TSA gets configured ? Especially how do you
> describe which Timeslot is switched to HDLC channels ?

the TSA is configured statically according to device tree node. 
For " which Timeslot is switched to HDLC channels ", there is a property 
"fsl,tx-timeslot-mask" in device tree to describe it.

> Is it possible to route some Timeslots to one UCC for HDLC, and route some
> others to another UCC for an ALSA sound driver ?

The feature you describe is not supported at present.

> The QE also have a QMC which allows to split all timeslots to a given UCC into
> independant channels that can either be used with HDLC or transparents (for
> audio for instance). Do you intent to also support QMC ?

new QE use UMCC instead of QMC in old QE, we have started to develop UMCC.
 
> According to the compatible property, it looks like your driver is for 
> freescale
> T1040. The MPC83xx also has a Quick Engine, would it work on it too ?

The driver is common, but tested on t1040, it is needed to add node to MPC83xx
If you want to test on mpc83xx.

-Zhao Qiang

RE: [PATCH 4/5] fsl/qe: Add QE TDM lib

2016-03-30 Thread Qiang Zhao 
On Wed, 2016-03-30 at 07:50PM, Joakim Tjernlund wrote:
> -Original Message-
> From: Joakim Tjernlund [mailto:joakim.tjernl...@infinera.com]
> Sent: Wednesday, March 30, 2016 7:50 PM
> To: da...@davemloft.net; Qiang Zhao <qiang.z...@nxp.com>
> Cc: linuxppc-...@lists.ozlabs.org; linux-ker...@vger.kernel.org; Xiaobo Xie
> <xiaobo@nxp.com>; o...@buserror.net; gre...@linuxfoundation.org;
> a...@linux-foundation.org; netdev@vger.kernel.org
> Subject: Re: [PATCH 4/5] fsl/qe: Add QE TDM lib
> 
> On Wed, 2016-03-30 at 16:50 +0800, Zhao Qiang wrote:
> > QE has module to support TDM, some other protocols supported by QE are
> > based on TDM.
> > add a qe-tdm lib, this lib provides functions to the protocols using
> > TDM to configurate QE-TDM.
> >
> > Signed-off-by: Zhao Qiang <qiang.z...@nxp.com>
> > +   utdm->siram_entry_id = val;
> > +
> > +   set_si_param(utdm, ut_info);
> > +
> > +   np2 = of_find_compatible_node(NULL, NULL, "fsl,t1040-qe-si");
> 
> fsl,t1040-qe-si only? What about mpc83xx?
> I recall QE is a little bit different compared to T1040 or will this 
> work(including
> the hdlc driver) on 83xx as well?

The " fsl,t1040-qe-si " is new added to dts and bindings, it is required to 
have SoC specific compatible strings.
mpc83xx will not use qe-si node. If there will be other soc useing qe-si, " 
fsl,t1040-qe-si " will follow the soc specific compatible,
like : 
si1: si@700 {
compatible = "fsl,ls1043-qe-si", "fsl,t1040-qe-si";
reg = <0x700 0x80>;
};

Best Regards
Zhao Qiang