[PATCH] Documentation: Mention chunk format for irq affinity

2015-07-22 Thread Sebastian Poehn
It may not be obvious for everyone that bitmasks in proc require
32bit chunking

Signed-off-by: Sebastian Poehn sebastian.po...@gmail.com
---
 Documentation/IRQ-affinity.txt | 5 +
 1 file changed, 5 insertions(+)

diff --git a/Documentation/IRQ-affinity.txt b/Documentation/IRQ-affinity.txt
index 01a6751..d873dab 100644
--- a/Documentation/IRQ-affinity.txt
+++ b/Documentation/IRQ-affinity.txt
@@ -55,6 +55,11 @@ round-trip min/avg/max = 0.1/0.5/585.4 ms
 This time around IRQ44 was delivered only to the last four processors.
 i.e counters for the CPU0-3 did not change.
 
+Note that you have to split the bitmask to chunks when using more that 32 cpus:
+[root@moon 44]# echo 80,  smp_affinity
+[root@moon 44]# cat smp_affinity
+80,
+
 Here is an example of limiting that same irq (44) to cpus 1024 to 1031:
 
 [root@moon 44]# echo 1024-1031  smp_affinity_list
-- 
2.4.3
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH v2] ip_forward: Drop frames with attached skb-sk

2015-04-20 Thread Sebastian Poehn
Initial discussion was:
[FYI] xfrm: Don't lookup sk_policy for timewait sockets

Forwarded frames should not have a socket attached. Especially
tw sockets will lead to panics later-on in the stack.

This was observed with TPROXY assigning a tw socket and broken
policy routing (misconfigured). As a result frame enters
forwarding path instead of input. We cannot solve this in
TPROXY as it cannot know that policy routing is broken.

v2:
Remove useless comment

Signed-off-by: Sebastian Poehn sebastian.po...@gmail.com
---
diff --git a/net/ipv4/ip_forward.c b/net/ipv4/ip_forward.c
index 939992c..3674484 100644
--- a/net/ipv4/ip_forward.c
+++ b/net/ipv4/ip_forward.c
@@ -82,6 +82,9 @@ int ip_forward(struct sk_buff *skb)
if (skb-pkt_type != PACKET_HOST)
goto drop;
 
+   if (unlikely(skb-sk))
+   goto drop;
+
if (skb_warn_if_lro(skb))
goto drop;
 
--

--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html