Re: [PATCH 4/5] Net: ath5k, license is GPLv2

2007-08-29 Thread Xavier Bestel 
On Wed, 2007-08-29 at 08:35 -0200, Jiri Slaby wrote:
 On 8/29/07, Johannes Berg [EMAIL PROTECTED] wrote:
  On Tue, 2007-08-28 at 12:00 -0400, Jiri Slaby wrote:
 
   The files are available only under GPLv2 since now.
 
  Since the BSD people are already getting upset about (for various
  reasons among which seem to be a clear non-understanding) I'd suggest
  changing it to:
 
 yes, please. Can somebody do it, I'm away from my box.
 
  + * Parts of this file were originally licenced under the BSD licence:
  + *
* Permission to use, copy, modify, and distribute this software for any
* purpose with or without fee is hereby granted, provided that the above
* copyright notice and this permission notice appear in all copies.
*
* THE SOFTWARE IS PROVIDED AS IS AND THE AUTHOR DISCLAIMS ALL
  WARRANTIES
* WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
* MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
* ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
* WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
* ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
* OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  + *
  + * Further changes to this file since the moment this notice was extended
  + * are now distributed under the terms of the GPL version two as published
  + * by the Free Software Foundation yaddaya
 
  johannes

How about asking for changes to be dual-licenced too ?

Xav


-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net: restrict device names from having whitespace

2006-08-18 Thread Xavier Bestel 
On Fri, 2006-08-18 at 08:11, Stephen Hemminger wrote:
 Don't allow spaces in network device names because it makes
 it difficult to provide text interfaces via sysfs.

Personally I would at least avoid all chars = ' ', because an interface
name is meant to be displayed and these control chars do no good on a
console nor in X.

Xav

-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net: restrict device names from having whitespace

2006-08-18 Thread Xavier Bestel 
On Fri, 2006-08-18 at 09:17, Xavier Bestel wrote:
 On Fri, 2006-08-18 at 08:11, Stephen Hemminger wrote:
  Don't allow spaces in network device names because it makes
  it difficult to provide text interfaces via sysfs.
 
 Personally I would at least avoid all chars = ' ', because an interface
 name is meant to be displayed and these control chars do no good on a
 console nor in X.

Something like the following patch (short of a full in-kernel utf8
validator). That said it starts looking like policy in the kernel. Maybe
the no space in devname should just be enforced by some userspace
tool, not by the kernel itself ?

Xav

diff --git a/net/core/dev.c b/net/core/dev.c
index d95e262..906cbf3 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -636,10 +636,23 @@ struct net_device * dev_get_by_flags(uns
  */
 int dev_valid_name(const char *name)
 {
-   return !(*name == '\0' 
-|| !strcmp(name, .)
-|| !strcmp(name, ..)
-|| strchr(name, '/'));
+   if(!*name)  /* empty string */
+   return 0;
+   if(*name == '.') {  /* . or .. */
+   if(!name[1])
+   return 0;
+   if(name[1] == '.'  !name[2])
+   return 0;
+   }
+   /* control char, space or slash */
+   while(*name) {
+   if(*name == '/')
+   return 0;
+   if(*name = ' ')
+   return 0;
+   ++name;
+   }
+   return 1;
 }
 
 /**


-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: bonding: cannot remove certain named devices

2006-08-17 Thread Xavier Bestel 
On Wed, 2006-08-16 at 17:11, Bodo Eggert wrote:
 On Wed, 16 Aug 2006, Bill Nottingham wrote:
  Giacomo A. Catenazzi ([EMAIL PROTECTED]) said: 
 
Are you willing to work to add the special case code necessary to
handle whitespace characters in the device name over all of the kernel
code and also all of the userland tools too?
   
   But if you don't handle spaces in userspace, you handle *, ?, [, ], $,
   , ', \  in userspace? Should kernel disable also these (insane device
   chars) chars?
  
  Don't forget unicode characters!
 
 And long names or control characters.
 
  Seriously, while it might be insane to use some of these, I'm wondering
  if trying to filter names is more work than fixing the tools.
 
 I think it's sane to avoid control characters and unicode/iso*, since they
 can interfere with log output or analysis. I only thought about the kernel
 itself and the corresponding userspace tools, which should handle any
 character sequence just fine or could be easily fixed.

Why not simply retricting chars to isalnum() ones ?

Xav

-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html