Re: [PATCH net] ping: implement proper locking

2017-03-24 Thread Xose Vazquez Perez 
Solar Designer wrote:

> We should credit the original reporter, who most likely found this by
> fuzzing.  It's danieljiang0415 on GitHub and Twitter.  Unfortunately, I
> don't know their e-mail address.  I'll try asking.

Daniel Jiang

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-20 Thread Xose Vazquez Perez 
Arnd Bergmann  wrote:

> rtlwifi, but I found the older r8712u device to work fine with
> the staging/rtl8712 driver.

A replacement for "staging/rtl8712", with MAC80211 support, is
available at: https://github.com/chunkeey/rtl8192su

Also a fullmac/cfg80211 driver(r92su) is available at the
same repository.

Re: [PATCH v2] carl9170: Clarify kconfig text

2016-04-18 Thread Xose Vazquez Perez 
Christian Lamparter wrote:

> Sure, but this could be a different patch then. I think Intel devices 
> (iwlwifi, iwlegacy and ipw2x00) have a similar text about "download
> firmware from this device from our homepage here" too. So if we want,
> we can remove them altogether?

linux-firmware.git does not contain firmware for all drivers. _At least_
zd1211rw [1], atmel [2] and ipw2x00 [3] are out of the tree.

[1] http://sf.net/projects/zd1211/files/
[2] 
http://web.archive.org/web/20121016132320/http://at76c503a.berlios.de/fw_dl.html
[3] http://ipw2100.sf.net/firmware.php http://ipw2200.sf.net/firmware.php

[BUG] ISIC + 2.6.22 (via-rhine)

2007-07-31 Thread Xose Vazquez Perez 

hi,

Running  ISIC -- IP Stack Integrity Checker ( http://isic.sf.net ),
in Fedora-7-i386 with 2.6.22, the NIC stopped to send packages.
But one second latter it began to send out more of them.
dmesg shows the bug.


command is:
# tcpsic -s rand -d 172.26.0.2 -I100


driver is:
via-rhine.c:v1.10-LK1.4.3 2007-03-06 Written by Donald Becker
eth0: VIA Rhine II at 0xbc00, 00:11:d8:54:e9:3c, IRQ 19.
eth0: MII PHY found at address 1, status 0x786d advertising 01e1 Link 45e1.
eth0: link up, 100Mbps, full-duplex, lpa 0x45E1
eth0: no IPv6 routers present

---lspci--
00:12.0 0200: 1106:3065 (rev 78)
Subsystem: 1043:80ed
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV+ VGASnoop- ParErr- 
Stepping+ SERR- FastB2B-
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=medium TAbort- TAbort- 
MAbort- SERR- PERR-
Latency: 32 (750ns min, 2000ns max), Cache Line Size: 32 bytes
Interrupt: pin A routed to IRQ 19
Region 0: I/O ports at 7000 [size=256]
Region 1: Memory at bc00 (32-bit, non-prefetchable) [size=256]
Capabilities: [40] Power Management version 2
Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA 
PME(D0+,D1+,D2+,D3hot+,D3cold+)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
--end--


--dmesg output--
[...]
NETDEV WATCHDOG: eth0: transmit timed out
eth0: Transmit timed out, status , PHY status 786d, resetting...

=
[ INFO: inconsistent lock state ]
2.6.22 #1
-
inconsistent {in-hardirq-W} - {hardirq-on-W} usage.
swapper/0 [HC0[0]:SC1[1]:HE1:SE0] takes:
 (rp-lock){++..}, at: [f8c890db] rhine_tx_timeout+0x6f/0xf4 [via_rhine]
{in-hardirq-W} state was registered at:
  [c04440d4] __lock_acquire+0x38c/0xb12
  [c0444c1b] lock_acquire+0x56/0x6f
  [c0615279] _spin_lock+0x2b/0x38
  [f8c87b49] rhine_interrupt+0x16b/0x69b [via_rhine]
  [c045aac6] handle_IRQ_event+0x1a/0x46
  [c045bbc0] handle_fasteoi_irq+0x7d/0xb6
  [c0407089] do_IRQ+0xb1/0xd8
  [] 0x
irq event stamp: 18052892
hardirqs last  enabled at (18052892): [c061567d] 
_spin_unlock_irqrestore+0x36/0x3c
hardirqs last disabled at (18052891): [c061558d] _spin_lock_irqsave+0x12/0x44
softirqs last  enabled at (18052876): [c042d272] __do_softirq+0xe3/0xe9
softirqs last disabled at (18052887): [c0406f72] do_softirq+0x61/0xc7

other info that might help us debug this:
1 lock held by swapper/0:
 #0:  (_xmit_ETHER){-+..}, at: [c05c042a] dev_watchdog+0x14/0xbf

stack backtrace:
 [c0405e6a] show_trace_log_lvl+0x1a/0x2f
 [c04068cf] show_trace+0x12/0x14
 [c0406928] dump_stack+0x16/0x18
 [c0442ccd] print_usage_bug+0x141/0x14b
 [c04434fd] mark_lock+0x1fd/0x409
 [c0444144] __lock_acquire+0x3fc/0xb12
 [c0444c1b] lock_acquire+0x56/0x6f
 [c0615279] _spin_lock+0x2b/0x38
 [f8c890db] rhine_tx_timeout+0x6f/0xf4 [via_rhine]
 [c05c048c] dev_watchdog+0x76/0xbf
 [c04303be] run_timer_softirq+0x11a/0x182
 [c042d1fe] __do_softirq+0x6f/0xe9
 [c0406f72] do_softirq+0x61/0xc7
 ===
via-rhine: Reset not complete yet. Trying harder.
eth0: link up, 100Mbps, full-duplex, lpa 0x45E1
--end---



-thanks-


--
Politicos de mierda, yo no soy un terrorista.

-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [BUG] ISIC + 2.6.22 (via-rhine)

2007-07-31 Thread Xose Vazquez Perez 

Arjan van de Ven wrote:


=
[ INFO: inconsistent lock state ]
2.6.22 #1
-
inconsistent {in-hardirq-W} - {hardirq-on-W} usage.
swapper/0 [HC0[0]:SC1[1]:HE1:SE0] takes:
  (rp-lock){++..}, at: [f8c890db] rhine_tx_timeout+0x6f/0xf4 [via_rhine]




this is a case of homegrown locking: the via-rhine driver does

/* protect against concurrent rx interrupts */
disable_irq(rp-pdev-irq);

spin_lock(rp-lock);

/* clear all descriptors */
free_tbufs(dev);
free_rbufs(dev);
alloc_tbufs(dev);
alloc_rbufs(dev);

/* Reinitialize the hardware. */
rhine_chip_reset(dev);
init_registers(dev);  


spin_unlock(rp-lock);
enable_irq(rp-pdev-irq);


as a way to protect code against interrupts... rather than using the
normal mechanism.


the annotation is pretty simple (untested, not even compiled):

--- linux-2.6.22/drivers/net/via-rhine.c.org2007-07-31 14:22:06.0 
-0700
+++ linux-2.6.22/drivers/net/via-rhine.c2007-07-31 14:22:26.0 
-0700
@@ -1191,7 +1191,7 @@
   mdio_read(dev, rp-mii_if.phy_id, MII_BMSR));
 
 	/* protect against concurrent rx interrupts */

-   disable_irq(rp-pdev-irq);
+   disable_irq_lockdep(rp-pdev-irq);
 
 	spin_lock(rp-lock);
 
@@ -1206,7 +1206,7 @@

init_registers(dev);
 
 	spin_unlock(rp-lock);

-   enable_irq(rp-pdev-irq);
+   enable_irq_lockdep(rp-pdev-irq);
 
 	dev-trans_start = jiffies;

rp-stats.tx_errors++;


thanks Arjan. Patch applied and now I get:

NETDEV WATCHDOG: eth0: transmit timed out
eth0: Transmit timed out, status , PHY status 786d, resetting...

==
[ INFO: hard-safe - hard-unsafe lock order detected ]
2.6.22 #1
--
swapper/0 [HC0[0]:SC1[1]:HE0:SE0] is trying to acquire:
 (af_callback_keys + sk-sk_family#3){-.-?}, at: [c05ab7d3] 
sock_def_write_space+0x18/0x96

and this task is already holding:
 (rp-lock){++..}, at: [f8d0a0e1] rhine_tx_timeout+0x75/0x102 [via_rhine]
which would create a new lock dependency:
 (rp-lock){++..} - (af_callback_keys + sk-sk_family#3){-.-?}

but this new dependency connects a hard-irq-safe lock:
 (rp-lock){++..}
... which became hard-irq-safe at:
  [c04440d4] __lock_acquire+0x38c/0xb12
  [c0444c1b] lock_acquire+0x56/0x6f
  [c0615279] _spin_lock+0x2b/0x38
  [f8d08b49] rhine_interrupt+0x16b/0x69b [via_rhine]
  [c045aac6] handle_IRQ_event+0x1a/0x46
  [c045bbc0] handle_fasteoi_irq+0x7d/0xb6
  [c0407089] do_IRQ+0xb1/0xd8
  [] 0x

to a hard-irq-unsafe lock:
 (af_callback_keys + sk-sk_family#3){-.-?}
... which became hard-irq-unsafe at:
...  [c0444144] __lock_acquire+0x3fc/0xb12
  [c0444c1b] lock_acquire+0x56/0x6f
  [c061532b] _write_lock_bh+0x30/0x3d
  [c05d829e] tcp_close+0x24e/0x531
  [c05f1175] inet_release+0x43/0x49
  [c05a85d4] sock_release+0x17/0x62
  [c05a89fb] sock_close+0x2d/0x33
  [c047db0f] __fput+0xbe/0x168
  [c047dbd0] fput+0x17/0x19
  [c047b4b5] filp_close+0x54/0x5c
  [c047c444] sys_close+0x78/0xb0
  [c0404e26] sysenter_past_esp+0x5f/0x99
  [] 0x

other info that might help us debug this:

2 locks held by swapper/0:
 #0:  (_xmit_ETHER){-+..}, at: [c05c042a] dev_watchdog+0x14/0xbf
 #1:  (rp-lock){++..}, at: [f8d0a0e1] rhine_tx_timeout+0x75/0x102 
[via_rhine]

the hard-irq-safe lock's dependencies:
- (rp-lock){++..} ops: 0 {
   initial-use  at:
[c044417d] __lock_acquire+0x435/0xb12
[c0444c1b] lock_acquire+0x56/0x6f
[c06155af] _spin_lock_irqsave+0x34/0x44
[f8d0a19b] rhine_get_stats+0x2d/0x9d [via_rhine]
[c05b9017] rtnl_fill_ifinfo+0x2e9/0x414
[c05b9547] rtmsg_ifinfo+0x57/0xd4
[c05b95fc] rtnetlink_event+0x38/0x3c
[c0616f9e] notifier_call_chain+0x2b/0x4a
[c0433984] __raw_notifier_call_chain+0x19/0x1e
[c04339a3] raw_notifier_call_chain+0x1a/0x1c
[c05b14a3] register_netdevice+0x335/0x33f
[c05b27d6] register_netdev+0x40/0x4d
[f8d09d07] rhine_init_one+0x515/0x6c7 [via_rhine]
[c04f8085] pci_device_probe+0x39/0x5b
[c055cffc] driver_probe_device+0xe9/0x16a
[c055d1a6] __driver_attach+0x76/0xaf
[c055c4ec] bus_for_each_dev+0x3a/0x5f
[c055ce47] driver_attach+0x19/0x1b
[c055c80a] bus_add_driver+0x79/0x181
[c055d3a1] driver_register+0x67/0x6c
[c04f81dd] __pci_register_driver+0x56/0x83
[f885f06c] 0xf885f06c
[c044b77f] sys_init_module+0x1579/0x16ca

[BUG] ISIC + 2.6.22 (via-rhine)

2007-07-09 Thread Xose Vazquez Perez 

hi,

Running  ISIC -- IP Stack Integrity Checker ( http://isic.sf.net ),
in Fedora-7-i386 with 2.6.22, the NIC stopped to send packages.
But 1 second latter it began to send out more of them.
dmesg shows the bug.


command is:
# tcpsic -s rand -d 172.26.0.2 -I100


driver is:
via-rhine.c:v1.10-LK1.4.3 2007-03-06 Written by Donald Becker
eth0: VIA Rhine II at 0xbc00, 00:11:d8:54:e9:3c, IRQ 19.
eth0: MII PHY found at address 1, status 0x786d advertising 01e1 Link 45e1.
eth0: link up, 100Mbps, full-duplex, lpa 0x45E1
eth0: no IPv6 routers present

---lspci--
00:12.0 0200: 1106:3065 (rev 78)
Subsystem: 1043:80ed
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV+ VGASnoop- ParErr- 
Stepping+ SERR- FastB2B-
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=medium TAbort- TAbort- 
MAbort- SERR- PERR-
Latency: 32 (750ns min, 2000ns max), Cache Line Size: 32 bytes
Interrupt: pin A routed to IRQ 19
Region 0: I/O ports at 7000 [size=256]
Region 1: Memory at bc00 (32-bit, non-prefetchable) [size=256]
Capabilities: [40] Power Management version 2
Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA 
PME(D0+,D1+,D2+,D3hot+,D3cold+)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
--end--


--dmesg output--
[...]
NETDEV WATCHDOG: eth0: transmit timed out
eth0: Transmit timed out, status , PHY status 786d, resetting...

=
[ INFO: inconsistent lock state ]
2.6.22 #1
-
inconsistent {in-hardirq-W} - {hardirq-on-W} usage.
swapper/0 [HC0[0]:SC1[1]:HE1:SE0] takes:
 (rp-lock){++..}, at: [f8c890db] rhine_tx_timeout+0x6f/0xf4 [via_rhine]
{in-hardirq-W} state was registered at:
  [c04440d4] __lock_acquire+0x38c/0xb12
  [c0444c1b] lock_acquire+0x56/0x6f
  [c0615279] _spin_lock+0x2b/0x38
  [f8c87b49] rhine_interrupt+0x16b/0x69b [via_rhine]
  [c045aac6] handle_IRQ_event+0x1a/0x46
  [c045bbc0] handle_fasteoi_irq+0x7d/0xb6
  [c0407089] do_IRQ+0xb1/0xd8
  [] 0x
irq event stamp: 18052892
hardirqs last  enabled at (18052892): [c061567d] 
_spin_unlock_irqrestore+0x36/0x3c
hardirqs last disabled at (18052891): [c061558d] _spin_lock_irqsave+0x12/0x44
softirqs last  enabled at (18052876): [c042d272] __do_softirq+0xe3/0xe9
softirqs last disabled at (18052887): [c0406f72] do_softirq+0x61/0xc7

other info that might help us debug this:
1 lock held by swapper/0:
 #0:  (_xmit_ETHER){-+..}, at: [c05c042a] dev_watchdog+0x14/0xbf

stack backtrace:
 [c0405e6a] show_trace_log_lvl+0x1a/0x2f
 [c04068cf] show_trace+0x12/0x14
 [c0406928] dump_stack+0x16/0x18
 [c0442ccd] print_usage_bug+0x141/0x14b
 [c04434fd] mark_lock+0x1fd/0x409
 [c0444144] __lock_acquire+0x3fc/0xb12
 [c0444c1b] lock_acquire+0x56/0x6f
 [c0615279] _spin_lock+0x2b/0x38
 [f8c890db] rhine_tx_timeout+0x6f/0xf4 [via_rhine]
 [c05c048c] dev_watchdog+0x76/0xbf
 [c04303be] run_timer_softirq+0x11a/0x182
 [c042d1fe] __do_softirq+0x6f/0xe9
 [c0406f72] do_softirq+0x61/0xc7
 ===
via-rhine: Reset not complete yet. Trying harder.
eth0: link up, 100Mbps, full-duplex, lpa 0x45E1
--end---



-thanks-


--
Politicos de mierda, yo no soy un terrorista.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

-x qla3xxx* and ifenslave.c to a package

2007-06-17 Thread Xose Vazquez Perez 

hi,

Jeff please:

remove the x file access permission of:
drivers/net/qla3xxx.c
drivers/net/qla3xxx.h

move Documentation/networking/ifenslave.c to a user
space package(iputils, net-tools, )


-thanks-


regards,
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html