Re: [2/2] iwlegacy: convert hex_dump_to_buffer() to %*ph

[Kalle Valo]

 There is no need to use hex_dump_to_buffer() in the cases like this:
 
   hexdump_to_buffer(buf, len, 16, 1, outbuf, outlen, false);  /* len 
 = 16 */
   sprintf(%s\n, outbuf);
 
 since it maybe easily converted to simple:
 
   sprintf(%*ph\n, len, buf);
 
 Note: it seems in the case the output is groupped by 2 bytes and looks like a
 typo. Thus, patch changes that to plain byte stream.
 
 Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com

Thanks, applied to wireless-drivers-next.git.

Kalle Valo
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] iwlegacy: convert hex_dump_to_buffer() to %*ph

[Andy Shevchenko]

There is no need to use hex_dump_to_buffer() in the cases like this:

hexdump_to_buffer(buf, len, 16, 1, outbuf, outlen, false);  /* len 
= 16 */
sprintf(%s\n, outbuf);

since it maybe easily converted to simple:

sprintf(%*ph\n, len, buf);

Note: it seems in the case the output is groupped by 2 bytes and looks like a
typo. Thus, patch changes that to plain byte stream.

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
 drivers/net/wireless/iwlegacy/3945-mac.c | 2 +-
 drivers/net/wireless/iwlegacy/debug.c| 8 ++--
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/net/wireless/iwlegacy/3945-mac.c 
b/drivers/net/wireless/iwlegacy/3945-mac.c
index 7f4cb69..af1b3e6 100644
--- a/drivers/net/wireless/iwlegacy/3945-mac.c
+++ b/drivers/net/wireless/iwlegacy/3945-mac.c
@@ -3259,7 +3259,7 @@ il3945_show_measurement(struct device *d, struct 
device_attribute *attr,
 
while (size  PAGE_SIZE - len) {
hex_dump_to_buffer(data + ofs, size, 16, 1, buf + len,
-  PAGE_SIZE - len, 1);
+  PAGE_SIZE - len, true);
len = strlen(buf);
if (PAGE_SIZE - len)
buf[len++] = '\n';
diff --git a/drivers/net/wireless/iwlegacy/debug.c 
b/drivers/net/wireless/iwlegacy/debug.c
index 3440101..908b9f4 100644
--- a/drivers/net/wireless/iwlegacy/debug.c
+++ b/drivers/net/wireless/iwlegacy/debug.c
@@ -515,12 +515,8 @@ il_dbgfs_nvm_read(struct file *file, char __user 
*user_buf, size_t count,
scnprintf(buf + pos, buf_size - pos, EEPROM  version: 0x%x\n,
  eeprom_ver);
for (ofs = 0; ofs  eeprom_len; ofs += 16) {
-   pos += scnprintf(buf + pos, buf_size - pos, 0x%.4x , ofs);
-   hex_dump_to_buffer(ptr + ofs, 16, 16, 2, buf + pos,
-  buf_size - pos, 0);
-   pos += strlen(buf + pos);
-   if (buf_size - pos  0)
-   buf[pos++] = '\n';
+   pos += scnprintf(buf + pos, buf_size - pos, 0x%.4x %16ph\n,
+ofs, ptr + ofs);
}
 
ret = simple_read_from_buffer(user_buf, count, ppos, buf, pos);
-- 
2.1.4

--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html