Re: [2.6 patch] drivers/net/ns83820.c: fix a check-after-use

2007-07-02 Thread Jeff Garzik 

Adrian Bunk wrote:

This patch fixes a check-after-use spotted by the Coverity checker.

Signed-off-by: Adrian Bunk [EMAIL PROTECTED]


applied


-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[2.6 patch] drivers/net/ns83820.c: fix a check-after-use

2007-07-01 Thread Adrian Bunk 
This patch fixes a check-after-use spotted by the Coverity checker.

Signed-off-by: Adrian Bunk [EMAIL PROTECTED]

---
--- linux-2.6.22-rc6-mm1/drivers/net/ns83820.c.old  2007-06-29 
22:12:22.0 +0200
+++ linux-2.6.22-rc6-mm1/drivers/net/ns83820.c  2007-06-29 22:13:59.0 
+0200
@@ -1985,11 +1985,13 @@ static int __devinit ns83820_init_one(st
 
ndev = alloc_etherdev(sizeof(struct ns83820));
dev = PRIV(ndev);
-   dev-ndev = ndev;
+
err = -ENOMEM;
if (!dev)
goto out;
 
+   dev-ndev = ndev;
+
spin_lock_init(dev-rx_info.lock);
spin_lock_init(dev-tx_lock);
spin_lock_init(dev-misc_lock);

-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html