[2.6 patch] fix IP_FIB_HASH kconfig warning
This patch fixes the following kconfig warning: net/ipv4/Kconfig:92:warning: defaults for choice values not supported Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch was already sent on: - 9 Jul 2005 --- linux-2.6.13-rc2-mm1-modular/net/ipv4/Kconfig.old 2005-07-08 23:55:31.0 +0200 +++ linux-2.6.13-rc2-mm1-modular/net/ipv4/Kconfig 2005-07-08 23:56:23.0 +0200 @@ -56,9 +56,9 @@ choice prompt "Choose IP: FIB lookup algorithm (choose FIB_HASH if unsure)" depends on IP_ADVANCED_ROUTER - default IP_FIB_HASH + default ASK_IP_FIB_HASH -config IP_FIB_HASH +config ASK_IP_FIB_HASH bool "FIB_HASH" ---help--- Current FIB is very proven and good enough for most users. @@ -84,12 +84,8 @@ endchoice -# If the user does not enable advanced routing, he gets the safe -# default of the fib-hash algorithm. config IP_FIB_HASH - bool - depends on !IP_ADVANCED_ROUTER - default y + def_bool ASK_IP_FIB_HASH || !IP_ADVANCED_ROUTER config IP_MULTIPLE_TABLES bool "IP: policy routing" - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[2.6 patch] fix IP_FIB_HASH kconfig warning
On Mon, Jul 04, 2005 at 08:27:56PM +0200, Roman Zippel wrote: >... > config IP_FIB_HASH > def_bool ASK_IP_FIB_HASH || !IP_ADVANCED_ROUTER An updated patch is below. > bye, Roman cu Adrian <-- snip --> This patch fixes the following kconfig warning: net/ipv4/Kconfig:92:warning: defaults for choice values not supported Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- linux-2.6.13-rc2-mm1-modular/net/ipv4/Kconfig.old 2005-07-08 23:55:31.0 +0200 +++ linux-2.6.13-rc2-mm1-modular/net/ipv4/Kconfig 2005-07-08 23:56:23.0 +0200 @@ -56,9 +56,9 @@ choice prompt "Choose IP: FIB lookup algorithm (choose FIB_HASH if unsure)" depends on IP_ADVANCED_ROUTER - default IP_FIB_HASH + default ASK_IP_FIB_HASH -config IP_FIB_HASH +config ASK_IP_FIB_HASH bool "FIB_HASH" ---help--- Current FIB is very proven and good enough for most users. @@ -84,12 +84,8 @@ endchoice -# If the user does not enable advanced routing, he gets the safe -# default of the fib-hash algorithm. config IP_FIB_HASH - bool - depends on !IP_ADVANCED_ROUTER - default y + def_bool ASK_IP_FIB_HASH || !IP_ADVANCED_ROUTER config IP_MULTIPLE_TABLES bool "IP: policy routing" - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [2.6 patch] fix IP_FIB_HASH kconfig warning
Hi, On Mon, 4 Jul 2005, Adrian Bunk wrote: > --- linux-2.6.13-rc1-mm1-full/net/ipv4/Kconfig.old2005-07-02 > 20:07:25.0 +0200 > +++ linux-2.6.13-rc1-mm1-full/net/ipv4/Kconfig2005-07-02 > 20:13:05.0 +0200 > @@ -58,8 +58,9 @@ > depends on IP_ADVANCED_ROUTER > default IP_FIB_HASH > > -config IP_FIB_HASH > +config ASK_IP_FIB_HASH > bool "FIB_HASH" > + select IP_FIB_HASH > ---help--- > Current FIB is very proven and good enough for most users. > > @@ -84,12 +85,9 @@ > > endchoice > > -# If the user does not enable advanced routing, he gets the safe > -# default of the fib-hash algorithm. > config IP_FIB_HASH > bool > - depends on !IP_ADVANCED_ROUTER > - default y > + default y if !IP_ADVANCED_ROUTER > > config IP_MULTIPLE_TABLES > bool "IP: policy routing" I'd prefer to do it without select. config IP_FIB_HASH def_bool ASK_IP_FIB_HASH || !IP_ADVANCED_ROUTER bye, Roman - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
