Re: [stable] [2.6.20.17 review 35/58] forcedeth bug fix: realtek phy
On Thu, Aug 23, 2007 at 05:50:41PM +0200, Prakash Punnoor wrote: > On the day of Thursday 23 August 2007 Greg KH hast written: > > On Wed, Aug 22, 2007 at 10:42:25PM +0200, Willy Tarreau wrote: > > > On Wed, Aug 22, 2007 at 08:15:03PM +0200, Prakash Punnoor wrote: > > > > Hi, > > > > > > > > even if Greg is waiting for some special invitation > > > > (http://lkml.org/lkml/2007/8/14/229), I suggest putting this patch by > > > > Ayaz on top: > > > > > > > > http://lkml.org/lkml/2007/8/10/296 > > > > > > That's what I prepare first, but then noticed it's not in mainline. > > > > > > > Perhaps Ayaz wants to give Greg the clarification he needs... :sigh: > > > > > > He should, as the fix is not in mainline either :-( > > > I don't think Greg asks for specific clarification, just a plain patch > > > with a short commit log on its own which does not include remains of > > > older mails. > > > > Exactly, that is what I am waiting for. > > > > And also I need the change to go into mainline first, as we can not > > diverge with the -stable releases. > > Can we get that into mainline then? I haven't seen forcedeth in MAINTAINERS, > so I added netdev to the cc list. It might help if someone sends a real patch that can be applied :) thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [2.6.20.17 review 35/58] forcedeth bug fix: realtek phy
On the day of Thursday 23 August 2007 Greg KH hast written: > On Wed, Aug 22, 2007 at 10:42:25PM +0200, Willy Tarreau wrote: > > On Wed, Aug 22, 2007 at 08:15:03PM +0200, Prakash Punnoor wrote: > > > Hi, > > > > > > even if Greg is waiting for some special invitation > > > (http://lkml.org/lkml/2007/8/14/229), I suggest putting this patch by > > > Ayaz on top: > > > > > > http://lkml.org/lkml/2007/8/10/296 > > > > That's what I prepare first, but then noticed it's not in mainline. > > > > > Perhaps Ayaz wants to give Greg the clarification he needs... :sigh: > > > > He should, as the fix is not in mainline either :-( > > I don't think Greg asks for specific clarification, just a plain patch > > with a short commit log on its own which does not include remains of > > older mails. > > Exactly, that is what I am waiting for. > > And also I need the change to go into mainline first, as we can not > diverge with the -stable releases. Can we get that into mainline then? I haven't seen forcedeth in MAINTAINERS, so I added netdev to the cc list. bye, -- (°= =°) //\ Prakash Punnoor /\\ V_/ \_V signature.asc Description: This is a digitally signed message part.
Re: [2.6.20.17 review 35/58] forcedeth bug fix: realtek phy
On Wed, Aug 22, 2007 at 11:56:42AM -0400, Chuck Ebbert wrote:
> On 08/22/2007 05:39 AM, Willy Tarreau wrote:
> > This patch contains errata fixes for the realtek phy. It only renamed the
> > defines to be phy specific.
> >
> > Signed-off-by: Ayaz Abdulla <[EMAIL PROTECTED]>
> > Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
> > Signed-off-by: Willy Tarreau <[EMAIL PROTECTED]>
> > ---
> > drivers/net/forcedeth.c | 54
> > +++
> > 1 files changed, 54 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c
> > index c383dc3..dbfdbed 100644
> > --- a/drivers/net/forcedeth.c
> > +++ b/drivers/net/forcedeth.c
> > @@ -554,6 +554,7 @@ union ring_type {
> > #define PHY_OUI_MARVELL0x5043
> > #define PHY_OUI_CICADA 0x03f1
> > #define PHY_OUI_VITESSE0x01c1
> > +#define PHY_OUI_REALTEK0x01c1
> > #define PHYID1_OUI_MASK0x03ff
> > #define PHYID1_OUI_SHFT6
> > #define PHYID2_OUI_MASK0xfc00
>
> Realtek is 0x0732
>
> This is still wrong upstream -- what happened to the patch to fix it?
Good catch, thanks Chuck! I've already seen the fix somewhere, I believe it
was on netdev, though I'm not sure. I'm fixing the patch in place right now.
I can add your signoff if you want.
Cheers,
Willy
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
