[NETROM] Drop lock before calling nr_destroy_socket

[Ralf Baechle]

nr_destroy_socket takes the socket lock itself so it should better be
called with the socket unlocked.

Signed-off-by: Ralf Baechle [EMAIL PROTECTED]

---

diff --git a/net/netrom/nr_timer.c b/net/netrom/nr_timer.c
index 75b72d3..ddba1c1 100644
--- a/net/netrom/nr_timer.c
+++ b/net/netrom/nr_timer.c
@@ -138,8 +138,8 @@ static void nr_heartbeat_expiry(unsigned
if (sock_flag(sk, SOCK_DESTROY) ||
(sk-sk_state == TCP_LISTEN  sock_flag(sk, SOCK_DEAD))) {
sock_hold(sk);
-   nr_destroy_socket(sk);
bh_unlock_sock(sk);
+   nr_destroy_socket(sk);
sock_put(sk);
return;
}
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [NETROM] Drop lock before calling nr_destroy_socket

[David Miller]

From: Ralf Baechle [EMAIL PROTECTED]
Date: Tue, 11 Jul 2006 00:25:45 +0100

 nr_destroy_socket takes the socket lock itself so it should better be
 called with the socket unlocked.
 
 Signed-off-by: Ralf Baechle [EMAIL PROTECTED]

Applied, thanks Ralf.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html