Re: [PATCH][RESEND] drivers/base: export (un)register_memory_notifier

2008-02-11 Thread Jan-Bernd Themann 
On Monday 11 February 2008 11:12, Dave Hansen wrote:
 On Mon, 2008-02-11 at 10:49 +0100, Jan-Bernd Themann wrote:
  are you the right person to address this patch to?
 
 You might want to check the top of the file. ;)
 
  --- a/drivers/base/memory.c
  +++ b/drivers/base/memory.c
  @@ -52,11 +52,13 @@ int register_memory_notifier(struct notifier_block *nb)
   {
   return blocking_notifier_chain_register(memory_chain, nb);
   }
  +EXPORT_SYMBOL(register_memory_notifier);
   
   void unregister_memory_notifier(struct notifier_block *nb)
   {
   blocking_notifier_chain_unregister(memory_chain, nb);
   }
  +EXPORT_SYMBOL(unregister_memory_notifier);
 
 Is there a particular reason these can't be GPL?
 

I don't object to make them GPL. Greg, what do you think?

Regards,
Jan-Bernd

--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH][RESEND] drivers/base: export (un)register_memory_notifier

2008-02-11 Thread Jan-Bernd Themann 
Drivers like eHEA need memory notifiers in order to 
update their internal DMA memory map when memory is added
to or removed from the system.

Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]

---
Hi Greg,

are you the right person to address this patch to?

Regards,
Jan-Bernd

 drivers/base/memory.c |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/base/memory.c b/drivers/base/memory.c
index 7ae413f..1e1bd4c 100644
--- a/drivers/base/memory.c
+++ b/drivers/base/memory.c
@@ -52,11 +52,13 @@ int register_memory_notifier(struct notifier_block *nb)
 {
 return blocking_notifier_chain_register(memory_chain, nb);
 }
+EXPORT_SYMBOL(register_memory_notifier);
 
 void unregister_memory_notifier(struct notifier_block *nb)
 {
 blocking_notifier_chain_unregister(memory_chain, nb);
 }
+EXPORT_SYMBOL(unregister_memory_notifier);
 
 /*
  * register_memory - Setup a sysfs device for a memory block
-- 
1.5.2

--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH][RESEND] drivers/base: export (un)register_memory_notifier

2008-02-11 Thread Dave Hansen 
On Mon, 2008-02-11 at 10:49 +0100, Jan-Bernd Themann wrote:
 are you the right person to address this patch to?

You might want to check the top of the file. ;)

 --- a/drivers/base/memory.c
 +++ b/drivers/base/memory.c
 @@ -52,11 +52,13 @@ int register_memory_notifier(struct notifier_block *nb)
  {
  return blocking_notifier_chain_register(memory_chain, nb);
  }
 +EXPORT_SYMBOL(register_memory_notifier);
  
  void unregister_memory_notifier(struct notifier_block *nb)
  {
  blocking_notifier_chain_unregister(memory_chain, nb);
  }
 +EXPORT_SYMBOL(unregister_memory_notifier);

Is there a particular reason these can't be GPL?

-- Dave

--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH][RESEND] drivers/base: export (un)register_memory_notifier

2008-02-11 Thread Greg KH 
On Mon, Feb 11, 2008 at 11:47:50AM +0100, Jan-Bernd Themann wrote:
 On Monday 11 February 2008 11:12, Dave Hansen wrote:
  On Mon, 2008-02-11 at 10:49 +0100, Jan-Bernd Themann wrote:
   are you the right person to address this patch to?
  
  You might want to check the top of the file. ;)
  
   --- a/drivers/base/memory.c
   +++ b/drivers/base/memory.c
   @@ -52,11 +52,13 @@ int register_memory_notifier(struct notifier_block 
   *nb)
{
return blocking_notifier_chain_register(memory_chain, nb);
}
   +EXPORT_SYMBOL(register_memory_notifier);

void unregister_memory_notifier(struct notifier_block *nb)
{
blocking_notifier_chain_unregister(memory_chain, nb);
}
   +EXPORT_SYMBOL(unregister_memory_notifier);
  
  Is there a particular reason these can't be GPL?
  
 
 I don't object to make them GPL. Greg, what do you think?

They should be _GPL to match the rest of the driver core.

Care to resend this?

thanks,

greg k-h
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html