Re: [PATCH][RFC][RESEND] remove broken URLs from net drivers' output

2006-08-17 Thread Alan Cox
Ar Iau, 2006-08-17 am 11:30 +0200, ysgrifennodd Markus Dahms:
> Remove broken URLs (www.scyld.com) from network drivers' logging output.
> URLs in comments and other strings are left intact.
> 
> Signed-off-by: Markus Dahms <[EMAIL PROTECTED]>

Acked-by: Alan Cox <[EMAIL PROTECTED]>

Bcc'd to one of the penguincomputing folks in case they want to put them
back/provide alternate URLs


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH][RFC][RESEND] remove broken URLs from net drivers' output

2006-08-17 Thread Jesper Juhl

On 17/08/06, Markus Dahms <[EMAIL PROTECTED]> wrote:

Remove broken URLs (www.scyld.com) from network drivers' logging output.
URLs in comments and other strings are left intact.


Makes good sense to me.
No point in refering to URLs that are no longer operational.
The best thing would be to find a replacement URL if one exist, but
failing that removing the wrong ones is a good thing IMHO.

--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please  http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH][RFC][RESEND] remove broken URLs from net drivers' output

2006-08-17 Thread Markus Dahms
Remove broken URLs (www.scyld.com) from network drivers' logging output.
URLs in comments and other strings are left intact.

Signed-off-by: Markus Dahms <[EMAIL PROTECTED]>

---

(second try, got no reaction last time)

I was tired of always seeing an URL not working anymore on initialization
of 3c59x and natsemi. So this is an attempt to get rid of these messages.

The patch is against 2.6.18-rc4-git
(c4e321b85a89d7cd392d3105b2c033a6c58ed337 from .../gregkh/linux-2.6).

Btw: Is there a policy for message output for drivers with respect to
author name, email addresses, copyright messages or home pages?

Markus

 3c509.c |5 ++---
 3c59x.c |2 +-
 atp.c   |8 +++-
 eepro100.c  |2 +-
 epic100.c   |   10 --
 natsemi.c   |1 -
 ne2k-pci.c  |3 +--
 sundance.c  |3 +--
 yellowfin.c |1 -
 9 files changed, 13 insertions(+), 22 deletions(-)


diff --git a/drivers/net/3c509.c b/drivers/net/3c509.c
index cbdae54..dccf142 100644
--- a/drivers/net/3c509.c
+++ b/drivers/net/3c509.c
@@ -96,8 +96,7 @@ #include 
 #include 
 #include 
 
-static char versionA[] __initdata = DRV_NAME ".c:" DRV_VERSION " " DRV_RELDATE 
" [EMAIL PROTECTED]";
-static char versionB[] __initdata = 
"http://www.scyld.com/network/3c509.html\n";;
+static char version[] __initdata = DRV_NAME ".c:" DRV_VERSION " " DRV_RELDATE 
" [EMAIL PROTECTED]";
 
 #if defined(CONFIG_PM) && (defined(CONFIG_MCA) || defined(CONFIG_EISA))
 #define EL3_SUSPEND
@@ -360,7 +359,7 @@ #endif
printk(", IRQ %d.\n", dev->irq);
 
if (el3_debug > 0)
-   printk(KERN_INFO "%s" KERN_INFO "%s", versionA, versionB);
+   printk(KERN_INFO "%s", version);
return 0;
 
 }
diff --git a/drivers/net/3c59x.c b/drivers/net/3c59x.c
index 80e8ca0..098c7aa 100644
--- a/drivers/net/3c59x.c
+++ b/drivers/net/3c59x.c
@@ -103,7 +103,7 @@ #include 
 
 
 static char version[] __devinitdata =
-DRV_NAME ": Donald Becker and others. www.scyld.com/network/vortex.html\n";
+DRV_NAME ": Donald Becker and others.\n";
 
 MODULE_AUTHOR("Donald Becker <[EMAIL PROTECTED]>");
 MODULE_DESCRIPTION("3Com 3c59x/3c9xx ethernet driver ");
diff --git a/drivers/net/atp.c b/drivers/net/atp.c
index bfa674e..697967f 100644
--- a/drivers/net/atp.c
+++ b/drivers/net/atp.c
@@ -31,10 +31,8 @@
 
 */
 
-static const char versionA[] =
+static const char version[] =
 "atp.c:v1.09=ac 2002/10/01 Donald Becker <[EMAIL PROTECTED]>\n";
-static const char versionB[] =
-"  http://www.scyld.com/network/atp.html\n";;
 
 /* The user-configurable values.
These may be modified when a driver module is loaded.*/
@@ -324,7 +322,7 @@ #endif
 
 #ifndef MODULE
if (net_debug)
-   printk(KERN_INFO "%s" KERN_INFO "%s", versionA, versionB);
+   printk(KERN_INFO "%s", version);
 #endif
 
printk(KERN_NOTICE "%s: Pocket adapter found at %#3lx, IRQ %d, SAPROM "
@@ -932,7 +930,7 @@ static void set_rx_mode_8012(struct net_
 
 static int __init atp_init_module(void) {
if (debug)  /* Emit version even if 
no cards detected. */
-   printk(KERN_INFO "%s" KERN_INFO "%s", versionA, versionB);
+   printk(KERN_INFO "%s", version);
return atp_init();
 }
 
diff --git a/drivers/net/eepro100.c b/drivers/net/eepro100.c
index e445988..0f4b495 100644
--- a/drivers/net/eepro100.c
+++ b/drivers/net/eepro100.c
@@ -28,7 +28,7 @@
 */
 
 static const char * const version =
-"eepro100.c:v1.09j-t 9/29/99 Donald Becker 
http://www.scyld.com/network/eepro100.html\n";
+"eepro100.c:v1.09j-t 9/29/99 Donald Becker\n"
 "eepro100.c: $Revision: 1.36 $ 2000/11/17 Modified by Andrey V. Savochkin 
<[EMAIL PROTECTED]> and others\n";
 
 /* A few user-configurable values that apply to all boards.
diff --git a/drivers/net/epic100.c b/drivers/net/epic100.c
index a67650c..ebef8ae 100644
--- a/drivers/net/epic100.c
+++ b/drivers/net/epic100.c
@@ -93,8 +93,6 @@ #include 
 static char version[] __devinitdata =
 DRV_NAME ".c:v1.11 1/7/2001 Written by Donald Becker <[EMAIL PROTECTED]>\n";
 static char version2[] __devinitdata =
-"  http://www.scyld.com/network/epic100.html\n";;
-static char version3[] __devinitdata =
 "  (unofficial 2.4.x kernel port, version " DRV_VERSION ", " DRV_RELDATE ")\n";
 
 MODULE_AUTHOR("Donald Becker <[EMAIL PROTECTED]>");
@@ -323,8 +321,8 @@ static int __devinit epic_init_one (stru
 #ifndef MODULE
static int printed_version;
if (!printed_version++)
-   printk (KERN_INFO "%s" KERN_INFO "%s" KERN_INFO "%s",
-   version, version2, version3);
+   printk (KERN_INFO "%s" KERN_INFO "%s",
+   version, version2);
 #endif
 
card_idx++;
@@ -1600,8 +1598,8 @@ static int __init epic_init (void)
 {
 /* when a module, this is printed whether or not devices are found in probe */
 #ifdef MODULE
-   printk (KERN_INFO "%s" KERN_INFO "%s" KERN_INFO "%s",
-   version, version2, ver